* [PATCH 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus
@ 2021-11-08 7:27 Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 2/7] arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board Hsin-Yi Wang
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Hsin-Yi Wang @ 2021-11-08 7:27 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
EDID is read from bridge, so the ddc-i2c-bus is unused.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index d8826c82bcda29..8f7bf33f607da2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -9,7 +9,6 @@ / {
panel: panel {
compatible = "auo,b116xw03";
power-supply = <&pp3300_panel>;
- ddc-i2c-bus = <&i2c4>;
backlight = <&backlight_lcd0>;
port {
--
2.34.0.rc0.344.g81b53c2807-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/7] arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board
2021-11-08 7:27 [PATCH 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus Hsin-Yi Wang
@ 2021-11-08 7:27 ` Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 3/7] arm64: dts: mt8183: Add more fennel SKUs Hsin-Yi Wang
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Hsin-Yi Wang @ 2021-11-08 7:27 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Cozmo is known as Acer Chromebook 314 (CB314-2H/CB314-2HT)
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/Makefile | 1 +
.../mediatek/mt8183-kukui-jacuzzi-cozmo.dts | 36 +++++++++++++++++++
2 files changed, 37 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 4f68ebed2e3188..045927402269a9 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -14,6 +14,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-burnet.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-cozmo.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-damu.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-fennel-sku1.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-fennel-sku6.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts
new file mode 100644
index 00000000000000..072133fb0f0162
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi.dtsi"
+#include "mt8183-kukui-audio-ts3a227e-max98357a.dtsi"
+
+/ {
+ model = "Google cozmo board";
+ compatible = "google,cozmo", "mediatek,mt8183";
+};
+
+&i2c_tunnel {
+ google,remote-bus = <0>;
+};
+
+&i2c2 {
+ trackpad@2c {
+ compatible = "hid-over-i2c";
+ reg = <0x2c>;
+ hid-descr-addr = <0x20>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&trackpad_pins>;
+
+ interrupts-extended = <&pio 7 IRQ_TYPE_LEVEL_LOW>;
+
+ wakeup-source;
+ };
+};
+
+&qca_wifi {
+ qcom,ath10k-calibration-variant = "GO_COZMO";
+};
--
2.34.0.rc0.344.g81b53c2807-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/7] arm64: dts: mt8183: Add more fennel SKUs
2021-11-08 7:27 [PATCH 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 2/7] arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board Hsin-Yi Wang
@ 2021-11-08 7:27 ` Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 4/7] arm64: dts: mt8183: Add kakadu sku22 Hsin-Yi Wang
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Hsin-Yi Wang @ 2021-11-08 7:27 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Add fennel sku7 and fennel14 sku2, which use different audio codec than
previous fennel/fennel14 boards.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/Makefile | 2 ++
.../mt8183-kukui-jacuzzi-fennel-sku1.dts | 1 +
.../mt8183-kukui-jacuzzi-fennel-sku6.dts | 1 +
.../mt8183-kukui-jacuzzi-fennel-sku7.dts | 33 +++++++++++++++++++
.../mediatek/mt8183-kukui-jacuzzi-fennel.dtsi | 1 -
.../mt8183-kukui-jacuzzi-fennel14-sku2.dts | 17 ++++++++++
.../mt8183-kukui-jacuzzi-fennel14.dts | 1 +
7 files changed, 55 insertions(+), 1 deletion(-)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dts
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 045927402269a9..9834bd659d1530 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -18,7 +18,9 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-cozmo.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-damu.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-fennel-sku1.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-fennel-sku6.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-fennel-sku7.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-fennel14.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-fennel14-sku2.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-juniper-sku16.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-kappa.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-kenzo.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
index ef6257c9a2d2ff..dec11a4eb59e30 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts
@@ -5,6 +5,7 @@
/dts-v1/;
#include "mt8183-kukui-jacuzzi-fennel.dtsi"
+#include "mt8183-kukui-audio-da7219-rt1015p.dtsi"
/ {
model = "Google fennel sku1 board";
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
index 899c2e42385c27..37e6e58f63b7e3 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts
@@ -5,6 +5,7 @@
/dts-v1/;
#include "mt8183-kukui-jacuzzi-fennel.dtsi"
+#include "mt8183-kukui-audio-da7219-rt1015p.dtsi"
/ {
model = "Google fennel sku6 board";
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
new file mode 100644
index 00000000000000..0e09604004d5e7
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts
@@ -0,0 +1,33 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi-fennel.dtsi"
+#include "mt8183-kukui-audio-ts3a227e-rt1015p.dtsi"
+
+/ {
+ model = "Google fennel sku7 board";
+ compatible = "google,fennel-sku7", "google,fennel", "mediatek,mt8183";
+};
+
+&touchscreen {
+ status = "okay";
+
+ compatible = "hid-over-i2c";
+ reg = <0x10>;
+ interrupt-parent = <&pio>;
+ interrupts = <155 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&touchscreen_pins>;
+
+ post-power-on-delay-ms = <10>;
+ hid-descr-addr = <0x0001>;
+};
+
+
+&qca_wifi {
+ qcom,ath10k-calibration-variant = "GO_FENNEL";
+};
+
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi
index 577519a775c057..bbe6c338f465ee 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi
@@ -5,7 +5,6 @@
/dts-v1/;
#include "mt8183-kukui-jacuzzi.dtsi"
-#include "mt8183-kukui-audio-da7219-rt1015p.dtsi"
&mt6358codec {
mediatek,dmic-mode = <1>; /* one-wire */
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dts
new file mode 100644
index 00000000000000..3fc5a6181d7e66
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-jacuzzi-fennel.dtsi"
+#include "mt8183-kukui-audio-ts3a227e-rt1015p.dtsi"
+
+/ {
+ model = "Google fennel14 sku2 board";
+ compatible = "google,fennel-sku2", "google,fennel", "mediatek,mt8183";
+};
+
+&qca_wifi {
+ qcom,ath10k-calibration-variant = "GO_FENNEL14";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dts
index e8c41f6b4b0d4e..23ad0b91e9776f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dts
@@ -5,6 +5,7 @@
/dts-v1/;
#include "mt8183-kukui-jacuzzi-fennel.dtsi"
+#include "mt8183-kukui-audio-da7219-rt1015p.dtsi"
/ {
model = "Google fennel14 sku0 board";
--
2.34.0.rc0.344.g81b53c2807-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/7] arm64: dts: mt8183: Add kakadu sku22
2021-11-08 7:27 [PATCH 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 2/7] arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 3/7] arm64: dts: mt8183: Add more fennel SKUs Hsin-Yi Wang
@ 2021-11-08 7:27 ` Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 5/7] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-cozmo Hsin-Yi Wang
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Hsin-Yi Wang @ 2021-11-08 7:27 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Kakadu sku22 is using mediatek,mt8183_mt6358_ts3a227_rt1015p audio codec
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/Makefile | 1 +
.../mediatek/mt8183-kukui-kakadu-sku22.dts | 19 +++++++++++++++++++
2 files changed, 20 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dts
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 9834bd659d1530..1613259b686576 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-kenzo.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-willow-sku0.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-jacuzzi-willow-sku1.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kakadu.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kakadu-sku22.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku16.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku272.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku288.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dts
new file mode 100644
index 00000000000000..3a724e6f915cd5
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dts
@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2021 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-kakadu.dtsi"
+#include "mt8183-kukui-audio-rt1015p.dtsi"
+
+/ {
+ model = "MediaTek kakadu board sku22";
+ compatible = "google,kakadu-rev3-sku22", "google,kakadu-rev2-sku22",
+ "google,kakadu", "mediatek,mt8183";
+};
+
+&sound {
+ compatible = "mediatek,mt8183_mt6358_ts3a227_rt1015p";
+};
+
--
2.34.0.rc0.344.g81b53c2807-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/7] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-cozmo
2021-11-08 7:27 [PATCH 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus Hsin-Yi Wang
` (2 preceding siblings ...)
2021-11-08 7:27 ` [PATCH 4/7] arm64: dts: mt8183: Add kakadu sku22 Hsin-Yi Wang
@ 2021-11-08 7:27 ` Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 6/7] dt-bindings: arm64: dts: mediatek: Add more SKUs for mt8183 fennel board Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board Hsin-Yi Wang
5 siblings, 0 replies; 10+ messages in thread
From: Hsin-Yi Wang @ 2021-11-08 7:27 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Cozmo is known as Acer Chromebook 314 (CB314-2H/CB314-2HT) Chromebook.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 0fa55497b96fd2..7cf0c76cd31006 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -134,6 +134,10 @@ properties:
- google,krane-sku176
- const: google,krane
- const: mediatek,mt8183
+ - description: Google Cozmo (Acer Chromebook 314)
+ items:
+ - const: google,cozmo
+ - const: mediatek,mt8183
- description: Google Damu (ASUS Chromebook Flip CM3)
items:
- const: google,damu
--
2.34.0.rc0.344.g81b53c2807-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/7] dt-bindings: arm64: dts: mediatek: Add more SKUs for mt8183 fennel board
2021-11-08 7:27 [PATCH 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus Hsin-Yi Wang
` (3 preceding siblings ...)
2021-11-08 7:27 ` [PATCH 5/7] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-cozmo Hsin-Yi Wang
@ 2021-11-08 7:27 ` Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board Hsin-Yi Wang
5 siblings, 0 replies; 10+ messages in thread
From: Hsin-Yi Wang @ 2021-11-08 7:27 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Add sku2 and sku7 which uses different audio codec than other fennel boards.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 7cf0c76cd31006..99e7f8e294cd03 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -147,7 +147,9 @@ properties:
- enum:
- google,fennel-sku0
- google,fennel-sku1
+ - google,fennel-sku2
- google,fennel-sku6
+ - google,fennel-sku7
- const: google,fennel
- const: mediatek,mt8183
- description: Google Juniper (Acer Chromebook Spin 311) / Kenzo (Acer Chromebook 311)
--
2.34.0.rc0.344.g81b53c2807-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board
2021-11-08 7:27 [PATCH 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus Hsin-Yi Wang
` (4 preceding siblings ...)
2021-11-08 7:27 ` [PATCH 6/7] dt-bindings: arm64: dts: mediatek: Add more SKUs for mt8183 fennel board Hsin-Yi Wang
@ 2021-11-08 7:27 ` Hsin-Yi Wang
2021-11-08 8:10 ` Chen-Yu Tsai
5 siblings, 1 reply; 10+ messages in thread
From: Hsin-Yi Wang @ 2021-11-08 7:27 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
Add sku22 which uses different audio codec than previous kakadu board.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 99e7f8e294cd03..da5f9ecc1a9b37 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -161,8 +161,11 @@ properties:
- const: mediatek,mt8183
- description: Google Kakadu (ASUS Chromebook Detachable CM3)
items:
- - const: google,kakadu-rev3
- - const: google,kakadu-rev2
+ - enum:
+ - google,kakadu-rev2
+ - google,kakadu-rev2-sku22
+ - google,kakadu-rev3
+ - google,kakadu-rev3-sku22
- const: google,kakadu
- const: mediatek,mt8183
- description: Google Kappa (HP Chromebook 11a)
--
2.34.0.rc0.344.g81b53c2807-goog
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board
2021-11-08 7:27 ` [PATCH 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board Hsin-Yi Wang
@ 2021-11-08 8:10 ` Chen-Yu Tsai
2021-11-08 8:27 ` Hsin-Yi Wang
0 siblings, 1 reply; 10+ messages in thread
From: Chen-Yu Tsai @ 2021-11-08 8:10 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Rob Herring, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel
On Mon, Nov 8, 2021 at 3:29 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> Add sku22 which uses different audio codec than previous kakadu board.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 99e7f8e294cd03..da5f9ecc1a9b37 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -161,8 +161,11 @@ properties:
> - const: mediatek,mt8183
> - description: Google Kakadu (ASUS Chromebook Detachable CM3)
> items:
> - - const: google,kakadu-rev3
> - - const: google,kakadu-rev2
> + - enum:
> + - google,kakadu-rev2
> + - google,kakadu-rev2-sku22
> + - google,kakadu-rev3
> + - google,kakadu-rev3-sku22
> - const: google,kakadu
> - const: mediatek,mt8183
This matches
"google,kakadu-rev[23](-sku22)?", "google,kakadu", "mediatek,mt8183",
which isn't what you want. You want:
"google,kakadu-rev3", "google,kakadu-rev2", "google,kakadu",
"mediatek,mt8183"
or
"google,kakadu-rev3-sku22", "google,kakadu-rev2-sku22", "google,kakadu",
"mediatek,mt8183"
I think the following is closer, but I'm not sure if nesting "items" is valid.
items:
- oneOf:
- items:
- const: google,kakadu-rev3-sku22
- const: google,kakadu-rev2-sku22
- items:
- const: google,kakadu-rev3
- const: google,kakadu-rev2
- const: google,kakadu
- const: mediatek,mt8183
ChenYu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board
2021-11-08 8:10 ` Chen-Yu Tsai
@ 2021-11-08 8:27 ` Hsin-Yi Wang
2021-11-08 8:35 ` Chen-Yu Tsai
0 siblings, 1 reply; 10+ messages in thread
From: Hsin-Yi Wang @ 2021-11-08 8:27 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Matthias Brugger, Rob Herring, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel
On Mon, Nov 8, 2021 at 4:10 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Mon, Nov 8, 2021 at 3:29 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> >
> > Add sku22 which uses different audio codec than previous kakadu board.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index 99e7f8e294cd03..da5f9ecc1a9b37 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -161,8 +161,11 @@ properties:
> > - const: mediatek,mt8183
> > - description: Google Kakadu (ASUS Chromebook Detachable CM3)
> > items:
> > - - const: google,kakadu-rev3
> > - - const: google,kakadu-rev2
> > + - enum:
> > + - google,kakadu-rev2
> > + - google,kakadu-rev2-sku22
> > + - google,kakadu-rev3
> > + - google,kakadu-rev3-sku22
> > - const: google,kakadu
> > - const: mediatek,mt8183
>
> This matches
>
> "google,kakadu-rev[23](-sku22)?", "google,kakadu", "mediatek,mt8183",
>
> which isn't what you want. You want:
>
> "google,kakadu-rev3", "google,kakadu-rev2", "google,kakadu",
> "mediatek,mt8183"
>
> or
>
> "google,kakadu-rev3-sku22", "google,kakadu-rev2-sku22", "google,kakadu",
> "mediatek,mt8183"
>
> I think the following is closer, but I'm not sure if nesting "items" is valid.
>
> items:
> - oneOf:
> - items:
> - const: google,kakadu-rev3-sku22
> - const: google,kakadu-rev2-sku22
> - items:
> - const: google,kakadu-rev3
> - const: google,kakadu-rev2
> - const: google,kakadu
> - const: mediatek,mt8183
>
How about
items:
- enum:
- google,kakadu-rev2
- google,kakadu-rev2-sku22
- enum:
- google,kakadu-rev3
- google,kakadu-rev3-sku22
- const: google,kakadu
....
>
> ChenYu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board
2021-11-08 8:27 ` Hsin-Yi Wang
@ 2021-11-08 8:35 ` Chen-Yu Tsai
0 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2021-11-08 8:35 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Rob Herring, linux-arm-kernel, linux-mediatek,
devicetree, linux-kernel
On Mon, Nov 8, 2021 at 4:28 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> On Mon, Nov 8, 2021 at 4:10 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
> >
> > On Mon, Nov 8, 2021 at 3:29 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> > >
> > > Add sku22 which uses different audio codec than previous kakadu board.
> > >
> > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > > ---
> > > Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > > index 99e7f8e294cd03..da5f9ecc1a9b37 100644
> > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > > @@ -161,8 +161,11 @@ properties:
> > > - const: mediatek,mt8183
> > > - description: Google Kakadu (ASUS Chromebook Detachable CM3)
> > > items:
> > > - - const: google,kakadu-rev3
> > > - - const: google,kakadu-rev2
> > > + - enum:
> > > + - google,kakadu-rev2
> > > + - google,kakadu-rev2-sku22
> > > + - google,kakadu-rev3
> > > + - google,kakadu-rev3-sku22
> > > - const: google,kakadu
> > > - const: mediatek,mt8183
> >
> > This matches
> >
> > "google,kakadu-rev[23](-sku22)?", "google,kakadu", "mediatek,mt8183",
> >
> > which isn't what you want. You want:
> >
> > "google,kakadu-rev3", "google,kakadu-rev2", "google,kakadu",
> > "mediatek,mt8183"
> >
> > or
> >
> > "google,kakadu-rev3-sku22", "google,kakadu-rev2-sku22", "google,kakadu",
> > "mediatek,mt8183"
> >
> > I think the following is closer, but I'm not sure if nesting "items" is valid.
> >
> > items:
> > - oneOf:
> > - items:
> > - const: google,kakadu-rev3-sku22
> > - const: google,kakadu-rev2-sku22
> > - items:
> > - const: google,kakadu-rev3
> > - const: google,kakadu-rev2
> > - const: google,kakadu
> > - const: mediatek,mt8183
> >
> How about
>
> items:
> - enum:
> - google,kakadu-rev2
> - google,kakadu-rev2-sku22
> - enum:
> - google,kakadu-rev3
> - google,kakadu-rev3-sku22
> - const: google,kakadu
> ....
This would also match:
"google,kakadu-rev2", "google,kakadu-rev3-sku22", ...
"google,kakadu-rev2-sku22", "google,kakadu-rev3", ...
which is not correct. Also I believe rev3 should be in front of rev2?
ChenYu
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-11-08 8:35 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-08 7:27 [PATCH 1/7] arm64: dts: mt8183: jacuzzi: remove unused ddc-i2c-bus Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 2/7] arm64: dts: mt8183: Add kukui-jacuzzi-cozmo board Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 3/7] arm64: dts: mt8183: Add more fennel SKUs Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 4/7] arm64: dts: mt8183: Add kakadu sku22 Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 5/7] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-jacuzzi-cozmo Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 6/7] dt-bindings: arm64: dts: mediatek: Add more SKUs for mt8183 fennel board Hsin-Yi Wang
2021-11-08 7:27 ` [PATCH 7/7] dt-bindings: arm64: dts: mediatek: Add sku22 for mt8183 kakadu board Hsin-Yi Wang
2021-11-08 8:10 ` Chen-Yu Tsai
2021-11-08 8:27 ` Hsin-Yi Wang
2021-11-08 8:35 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).