* [PATCH] drm/amdkfd: make SPDX License expression more sound
@ 2021-12-16 9:45 Lukas Bulwahn
2021-12-16 17:14 ` Richard Fontana
2022-01-05 19:27 ` Felix Kuehling
0 siblings, 2 replies; 5+ messages in thread
From: Lukas Bulwahn @ 2021-12-16 9:45 UTC (permalink / raw)
To: Felix Kuehling, Jonathan Kim, Alex Deucher, amd-gfx
Cc: Thomas Gleixner, Greg Kroah-Hartman, linux-spdx, linux-kernel,
Lukas Bulwahn
Commit b5f57384805a ("drm/amdkfd: Add sysfs bitfields and enums to uAPI")
adds include/uapi/linux/kfd_sysfs.h with the "GPL-2.0 OR MIT WITH
Linux-syscall-note" SPDX-License expression.
The command ./scripts/spdxcheck.py warns:
include/uapi/linux/kfd_sysfs.h: 1:48 Exception not valid for license MIT: Linux-syscall-note
For a uapi header, the file under GPLv2 License must be combined with the
Linux-syscall-note, but combining the MIT License with the
Linux-syscall-note makes no sense, as the note provides an exception for
GPL-licensed code, not for permissively licensed code.
So, reorganize the SPDX expression to only combine the note with the GPL
License condition. This makes spdxcheck happy again.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
I am not a lawyer and I do not intend to modify the actual licensing of
this header file. So, I really would like to have an Ack from some AMD
developer here.
Maybe also a lawyer on the linux-spdx list can check my reasoning on the
licensing with the exception note?
include/uapi/linux/kfd_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/kfd_sysfs.h b/include/uapi/linux/kfd_sysfs.h
index e1fb78b4bf09..3e330f368917 100644
--- a/include/uapi/linux/kfd_sysfs.h
+++ b/include/uapi/linux/kfd_sysfs.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 OR MIT WITH Linux-syscall-note */
+/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR MIT */
/*
* Copyright 2021 Advanced Micro Devices, Inc.
*
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdkfd: make SPDX License expression more sound
2021-12-16 9:45 [PATCH] drm/amdkfd: make SPDX License expression more sound Lukas Bulwahn
@ 2021-12-16 17:14 ` Richard Fontana
2021-12-16 19:21 ` Kate Stewart
2022-01-05 19:27 ` Felix Kuehling
1 sibling, 1 reply; 5+ messages in thread
From: Richard Fontana @ 2021-12-16 17:14 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Felix Kuehling, Jonathan Kim, Alex Deucher, amd-gfx,
Thomas Gleixner, Greg Kroah-Hartman, linux-spdx, linux-kernel
On Thu, Dec 16, 2021 at 4:45 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit b5f57384805a ("drm/amdkfd: Add sysfs bitfields and enums to uAPI")
> adds include/uapi/linux/kfd_sysfs.h with the "GPL-2.0 OR MIT WITH
> Linux-syscall-note" SPDX-License expression.
>
> The command ./scripts/spdxcheck.py warns:
>
> include/uapi/linux/kfd_sysfs.h: 1:48 Exception not valid for license MIT: Linux-syscall-note
>
> For a uapi header, the file under GPLv2 License must be combined with the
> Linux-syscall-note, but combining the MIT License with the
> Linux-syscall-note makes no sense, as the note provides an exception for
> GPL-licensed code, not for permissively licensed code.
>
> So, reorganize the SPDX expression to only combine the note with the GPL
> License condition. This makes spdxcheck happy again.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> I am not a lawyer and I do not intend to modify the actual licensing of
> this header file. So, I really would like to have an Ack from some AMD
> developer here.
>
> Maybe also a lawyer on the linux-spdx list can check my reasoning on the
> licensing with the exception note?
I believe "MIT WITH Linux-syscall-note" is a syntactically correct
SPDX expression but is otherwise sort of non-meaningful.
"(GPL-2.0 WITH Linux-syscall-note) OR MIT" is presumably what is
intended here. But yes would be good to get confirmation from someone
associated with AMD.
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdkfd: make SPDX License expression more sound
2021-12-16 17:14 ` Richard Fontana
@ 2021-12-16 19:21 ` Kate Stewart
0 siblings, 0 replies; 5+ messages in thread
From: Kate Stewart @ 2021-12-16 19:21 UTC (permalink / raw)
To: Richard Fontana
Cc: Lukas Bulwahn, Felix Kuehling, Jonathan Kim, Alex Deucher,
amd-gfx, Thomas Gleixner, Greg Kroah-Hartman, linux-spdx,
linux-kernel
On Thu, Dec 16, 2021 at 11:14 AM Richard Fontana <rfontana@redhat.com> wrote:
>
> On Thu, Dec 16, 2021 at 4:45 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > Commit b5f57384805a ("drm/amdkfd: Add sysfs bitfields and enums to uAPI")
> > adds include/uapi/linux/kfd_sysfs.h with the "GPL-2.0 OR MIT WITH
> > Linux-syscall-note" SPDX-License expression.
> >
> > The command ./scripts/spdxcheck.py warns:
> >
> > include/uapi/linux/kfd_sysfs.h: 1:48 Exception not valid for license MIT: Linux-syscall-note
> >
> > For a uapi header, the file under GPLv2 License must be combined with the
> > Linux-syscall-note, but combining the MIT License with the
> > Linux-syscall-note makes no sense, as the note provides an exception for
> > GPL-licensed code, not for permissively licensed code.
> >
> > So, reorganize the SPDX expression to only combine the note with the GPL
> > License condition. This makes spdxcheck happy again.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > I am not a lawyer and I do not intend to modify the actual licensing of
> > this header file. So, I really would like to have an Ack from some AMD
> > developer here.
> >
> > Maybe also a lawyer on the linux-spdx list can check my reasoning on the
> > licensing with the exception note?
>
> I believe "MIT WITH Linux-syscall-note" is a syntactically correct
> SPDX expression but is otherwise sort of non-meaningful.
> "(GPL-2.0 WITH Linux-syscall-note) OR MIT" is presumably what is
> intended here. But yes would be good to get confirmation from someone
> associated with AMD.
Thanks Lukas, I agree that this is indeed clearer.
+1
Reviewed-by: kstewart@linuxfoundation.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdkfd: make SPDX License expression more sound
2021-12-16 9:45 [PATCH] drm/amdkfd: make SPDX License expression more sound Lukas Bulwahn
2021-12-16 17:14 ` Richard Fontana
@ 2022-01-05 19:27 ` Felix Kuehling
2022-01-10 21:22 ` Felix Kuehling
1 sibling, 1 reply; 5+ messages in thread
From: Felix Kuehling @ 2022-01-05 19:27 UTC (permalink / raw)
To: Lukas Bulwahn, Jonathan Kim, Alex Deucher, amd-gfx
Cc: Thomas Gleixner, Greg Kroah-Hartman, linux-spdx, linux-kernel
Am 2021-12-16 um 4:45 a.m. schrieb Lukas Bulwahn:
> Commit b5f57384805a ("drm/amdkfd: Add sysfs bitfields and enums to uAPI")
> adds include/uapi/linux/kfd_sysfs.h with the "GPL-2.0 OR MIT WITH
> Linux-syscall-note" SPDX-License expression.
>
> The command ./scripts/spdxcheck.py warns:
>
> include/uapi/linux/kfd_sysfs.h: 1:48 Exception not valid for license MIT: Linux-syscall-note
>
> For a uapi header, the file under GPLv2 License must be combined with the
> Linux-syscall-note, but combining the MIT License with the
> Linux-syscall-note makes no sense, as the note provides an exception for
> GPL-licensed code, not for permissively licensed code.
>
> So, reorganize the SPDX expression to only combine the note with the GPL
> License condition. This makes spdxcheck happy again.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> I am not a lawyer and I do not intend to modify the actual licensing of
> this header file. So, I really would like to have an Ack from some AMD
> developer here.
>
> Maybe also a lawyer on the linux-spdx list can check my reasoning on the
> licensing with the exception note?
>
> include/uapi/linux/kfd_sysfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/kfd_sysfs.h b/include/uapi/linux/kfd_sysfs.h
> index e1fb78b4bf09..3e330f368917 100644
> --- a/include/uapi/linux/kfd_sysfs.h
> +++ b/include/uapi/linux/kfd_sysfs.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0 OR MIT WITH Linux-syscall-note */
> +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR MIT */
> /*
> * Copyright 2021 Advanced Micro Devices, Inc.
> *
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdkfd: make SPDX License expression more sound
2022-01-05 19:27 ` Felix Kuehling
@ 2022-01-10 21:22 ` Felix Kuehling
0 siblings, 0 replies; 5+ messages in thread
From: Felix Kuehling @ 2022-01-10 21:22 UTC (permalink / raw)
To: Lukas Bulwahn, Jonathan Kim, Alex Deucher, amd-gfx
Cc: Greg Kroah-Hartman, Thomas Gleixner, linux-kernel, linux-spdx
On 2022-01-05 2:27 p.m., Felix Kuehling wrote:
> Am 2021-12-16 um 4:45 a.m. schrieb Lukas Bulwahn:
>> Commit b5f57384805a ("drm/amdkfd: Add sysfs bitfields and enums to uAPI")
>> adds include/uapi/linux/kfd_sysfs.h with the "GPL-2.0 OR MIT WITH
>> Linux-syscall-note" SPDX-License expression.
>>
>> The command ./scripts/spdxcheck.py warns:
>>
>> include/uapi/linux/kfd_sysfs.h: 1:48 Exception not valid for license MIT: Linux-syscall-note
>>
>> For a uapi header, the file under GPLv2 License must be combined with the
>> Linux-syscall-note, but combining the MIT License with the
>> Linux-syscall-note makes no sense, as the note provides an exception for
>> GPL-licensed code, not for permissively licensed code.
>>
>> So, reorganize the SPDX expression to only combine the note with the GPL
>> License condition. This makes spdxcheck happy again.
>>
>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
I applied the patch to amd-staging-drm-next.
Regards,
Felix
>
>
>> ---
>> I am not a lawyer and I do not intend to modify the actual licensing of
>> this header file. So, I really would like to have an Ack from some AMD
>> developer here.
>>
>> Maybe also a lawyer on the linux-spdx list can check my reasoning on the
>> licensing with the exception note?
>>
>> include/uapi/linux/kfd_sysfs.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/kfd_sysfs.h b/include/uapi/linux/kfd_sysfs.h
>> index e1fb78b4bf09..3e330f368917 100644
>> --- a/include/uapi/linux/kfd_sysfs.h
>> +++ b/include/uapi/linux/kfd_sysfs.h
>> @@ -1,4 +1,4 @@
>> -/* SPDX-License-Identifier: GPL-2.0 OR MIT WITH Linux-syscall-note */
>> +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR MIT */
>> /*
>> * Copyright 2021 Advanced Micro Devices, Inc.
>> *
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-10 21:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 9:45 [PATCH] drm/amdkfd: make SPDX License expression more sound Lukas Bulwahn
2021-12-16 17:14 ` Richard Fontana
2021-12-16 19:21 ` Kate Stewart
2022-01-05 19:27 ` Felix Kuehling
2022-01-10 21:22 ` Felix Kuehling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).