linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] reset: sunxi: fix number of reset lines
@ 2017-08-11 10:40 Philipp Zabel
  2017-08-11 15:42 ` Chen-Yu Tsai
  0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2017-08-11 10:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: Maxime Ripard, Chen-Yu Tsai, Philipp Zabel

The Allwinner reset controller has 32-bit registers, but resource_size
is measured in bytes, not number of registers.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/reset/reset-sunxi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
index cd585cd2f04dd..2c7dd1fd08df6 100644
--- a/drivers/reset/reset-sunxi.c
+++ b/drivers/reset/reset-sunxi.c
@@ -107,7 +107,7 @@ static int sunxi_reset_init(struct device_node *np)
 	spin_lock_init(&data->lock);
 
 	data->rcdev.owner = THIS_MODULE;
-	data->rcdev.nr_resets = size * 32;
+	data->rcdev.nr_resets = size * 8;
 	data->rcdev.ops = &sunxi_reset_ops;
 	data->rcdev.of_node = np;
 
@@ -162,7 +162,7 @@ static int sunxi_reset_probe(struct platform_device *pdev)
 	spin_lock_init(&data->lock);
 
 	data->rcdev.owner = THIS_MODULE;
-	data->rcdev.nr_resets = resource_size(res) * 32;
+	data->rcdev.nr_resets = resource_size(res) * 8;
 	data->rcdev.ops = &sunxi_reset_ops;
 	data->rcdev.of_node = pdev->dev.of_node;
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] reset: sunxi: fix number of reset lines
  2017-08-11 10:40 [PATCH] reset: sunxi: fix number of reset lines Philipp Zabel
@ 2017-08-11 15:42 ` Chen-Yu Tsai
  0 siblings, 0 replies; 2+ messages in thread
From: Chen-Yu Tsai @ 2017-08-11 15:42 UTC (permalink / raw)
  To: Philipp Zabel; +Cc: linux-kernel, Maxime Ripard, Chen-Yu Tsai

On Fri, Aug 11, 2017 at 6:40 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> The Allwinner reset controller has 32-bit registers, but resource_size
> is measured in bytes, not number of registers.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Acked-by: Chen-Yu Tsai <wens@csie.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-11 15:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-11 10:40 [PATCH] reset: sunxi: fix number of reset lines Philipp Zabel
2017-08-11 15:42 ` Chen-Yu Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).