linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* device tree binding for poly-phased regulators
@ 2019-02-22 11:21 Torsten Duwe
  2019-03-06  3:47 ` Chen-Yu Tsai
  0 siblings, 1 reply; 2+ messages in thread
From: Torsten Duwe @ 2019-02-22 11:21 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Carlo Caione, Olliver Schinagl, Lee Jones, Rob Herring,
	Mark Rutland, Jagan Teki, Icenowy Zheng, devicetree,
	linux-kernel

Hi!

Documentation/devicetree/bindings/mfd/axp20x.txt nicely describes the
capabilities of the X-powers PMICs; however, it seems polyphasing is
left to comments only.

May I suggest to add a property "poly-phased", just to get the discussion
started? It could be a simple property in the current case for the axp803
and axp806 ("poly-phased with you-know-which") or a phandle in the future.

BTW the axp803 datasheet is quite terse in that respect: is there one
"master" reulator whose settings are copied or does a driver have to keep
them in sync.

Anyway, comments welcome!

	Torsten


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: device tree binding for poly-phased regulators
  2019-02-22 11:21 device tree binding for poly-phased regulators Torsten Duwe
@ 2019-03-06  3:47 ` Chen-Yu Tsai
  0 siblings, 0 replies; 2+ messages in thread
From: Chen-Yu Tsai @ 2019-03-06  3:47 UTC (permalink / raw)
  To: Torsten Duwe
  Cc: Carlo Caione, Olliver Schinagl, Lee Jones, Rob Herring,
	Mark Rutland, Jagan Teki, Icenowy Zheng, devicetree,
	linux-kernel

On Fri, Feb 22, 2019 at 7:21 PM Torsten Duwe <duwe@lst.de> wrote:
>
> Hi!
>
> Documentation/devicetree/bindings/mfd/axp20x.txt nicely describes the
> capabilities of the X-powers PMICs; however, it seems polyphasing is
> left to comments only.
>
> May I suggest to add a property "poly-phased", just to get the discussion
> started? It could be a simple property in the current case for the axp803
> and axp806 ("poly-phased with you-know-which") or a phandle in the future.

These PMICs are customized in a way that the outputs are poly-phased by
default. They are customized to match a specific SoC, and that is about
the only use for them. As such, there's really no way to test whether a
poly-phase property and implementation works or not. If you get it wrong
you risk frying your device.

A poly-phase property in genernal would be nice, however I don't think
this is the right device to start with.

> BTW the axp803 datasheet is quite terse in that respect: is there one
> "master" reulator whose settings are copied or does a driver have to keep
> them in sync.

The datasheet says, when outputs are poly-phased, only the settings of the
first phase applies, i.e. the other settings are ignored, not even copied.

ChenYu

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-06  3:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 11:21 device tree binding for poly-phased regulators Torsten Duwe
2019-03-06  3:47 ` Chen-Yu Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).