From: Oleksandr Suvorov <cryosay@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Sanchayan Maity <maitysanchayan@gmail.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>
Subject: Re: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties
Date: Wed, 12 Feb 2020 13:02:16 +0200 [thread overview]
Message-ID: <CAGgjyvFKWKoQ-Em8n0X2nKeuQ5CZybB3ChvdWsw6c=YpqD5N3A@mail.gmail.com> (raw)
In-Reply-To: <20200212104629.20272-1-johan@kernel.org>
On Wed, Feb 12, 2020 at 12:46 PM Johan Hovold <johan@kernel.org> wrote:
>
> The sram-node compatible properties have mistakingly combined the
> model-specific string with the generic "mtd-ram" string.
>
> Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
> "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
> not present in any binding.
>
> The physmap driver will however bind to platform devices that specify
> "mtd-ram".
>
> Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
> Cc: Sanchayan Maity <maitysanchayan@gmail.com>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> ---
> arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> index cd075621de52..84fcc203a2e4 100644
> --- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> @@ -275,7 +275,7 @@ &weim {
>
> /* SRAM on Colibri nEXT_CS0 */
> sram@0,0 {
> - compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> + compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
> reg = <0 0 0x00010000>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -286,7 +286,7 @@ sram@0,0 {
>
> /* SRAM on Colibri nEXT_CS1 */
> sram@1,0 {
> - compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> + compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
> reg = <1 0 0x00010000>;
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 2.24.1
>
--
Best regards
Oleksandr Suvorov
cryosay@gmail.com
next prev parent reply other threads:[~2020-02-12 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 10:46 [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties Johan Hovold
2020-02-12 11:02 ` Oleksandr Suvorov [this message]
2020-02-17 6:36 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGgjyvFKWKoQ-Em8n0X2nKeuQ5CZybB3ChvdWsw6c=YpqD5N3A@mail.gmail.com' \
--to=cryosay@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=johan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).