* [PATCH] clk: nxp: clk-lpc18xx-ccu: Unmap region obtained by of_iomap
@ 2016-09-20 10:39 Arvind Yadav
2016-10-08 10:58 ` Joachim Eastwood
2016-11-02 0:32 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2016-09-20 10:39 UTC (permalink / raw)
To: mturquette, sboyd, manabian
Cc: linux-clk, linux-arm-kernel, linux-kernel, Arvind Yadav
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Free memory mapping, if lpc18xx_ccu_init is not successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clk/nxp/clk-lpc18xx-ccu.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/nxp/clk-lpc18xx-ccu.c b/drivers/clk/nxp/clk-lpc18xx-ccu.c
index f7136b9..27781b4 100644
--- a/drivers/clk/nxp/clk-lpc18xx-ccu.c
+++ b/drivers/clk/nxp/clk-lpc18xx-ccu.c
@@ -277,12 +277,15 @@ static void __init lpc18xx_ccu_init(struct device_node *np)
}
clk_data = kzalloc(sizeof(*clk_data), GFP_KERNEL);
- if (!clk_data)
+ if (!clk_data) {
+ iounmap(reg_base);
return;
+ }
clk_data->num = of_property_count_strings(np, "clock-names");
clk_data->name = kcalloc(clk_data->num, sizeof(char *), GFP_KERNEL);
if (!clk_data->name) {
+ iounmap(reg_base);
kfree(clk_data);
return;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: nxp: clk-lpc18xx-ccu: Unmap region obtained by of_iomap
2016-09-20 10:39 [PATCH] clk: nxp: clk-lpc18xx-ccu: Unmap region obtained by of_iomap Arvind Yadav
@ 2016-10-08 10:58 ` Joachim Eastwood
2016-11-02 0:32 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Joachim Eastwood @ 2016-10-08 10:58 UTC (permalink / raw)
To: Arvind Yadav
Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-arm-kernel,
linux-kernel
Hi Arvind,
On 20 September 2016 at 12:39, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Free memory mapping, if lpc18xx_ccu_init is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Joachim Eastwood <manabian@gmail.com>
One comment below:
> ---
> drivers/clk/nxp/clk-lpc18xx-ccu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/nxp/clk-lpc18xx-ccu.c b/drivers/clk/nxp/clk-lpc18xx-ccu.c
> index f7136b9..27781b4 100644
> --- a/drivers/clk/nxp/clk-lpc18xx-ccu.c
> +++ b/drivers/clk/nxp/clk-lpc18xx-ccu.c
> @@ -277,12 +277,15 @@ static void __init lpc18xx_ccu_init(struct device_node *np)
> }
>
> clk_data = kzalloc(sizeof(*clk_data), GFP_KERNEL);
> - if (!clk_data)
> + if (!clk_data) {
> + iounmap(reg_base);
> return;
> + }
You could also move the kzalloc() at the beginning of the function to
save a few lines. I am fine either way.
>
> clk_data->num = of_property_count_strings(np, "clock-names");
> clk_data->name = kcalloc(clk_data->num, sizeof(char *), GFP_KERNEL);
> if (!clk_data->name) {
> + iounmap(reg_base);
> kfree(clk_data);
> return;
> }
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: nxp: clk-lpc18xx-ccu: Unmap region obtained by of_iomap
2016-09-20 10:39 [PATCH] clk: nxp: clk-lpc18xx-ccu: Unmap region obtained by of_iomap Arvind Yadav
2016-10-08 10:58 ` Joachim Eastwood
@ 2016-11-02 0:32 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2016-11-02 0:32 UTC (permalink / raw)
To: Arvind Yadav
Cc: mturquette, manabian, linux-clk, linux-arm-kernel, linux-kernel
On 09/20, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Free memory mapping, if lpc18xx_ccu_init is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-02 0:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-20 10:39 [PATCH] clk: nxp: clk-lpc18xx-ccu: Unmap region obtained by of_iomap Arvind Yadav
2016-10-08 10:58 ` Joachim Eastwood
2016-11-02 0:32 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).