[PATCH] staging: android: ion: fix coding style issue

[PATCH] staging: android: ion: fix coding style issue

[Adheer Chandravanshi]

Use tab instead of spaces for indentation, as reported by checkpatch.pl

Signed-off-by: Adheer Chandravanshi <adheerchandravanshi@gmail.com>
---
 drivers/staging/android/ion/ion_cma_heap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index dc2a913..a0949bc 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -108,7 +108,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
 
 int __ion_add_cma_heaps(struct cma *cma, void *data)
 {
-        struct ion_heap *heap;
+	struct ion_heap *heap;
 
 	heap = __ion_cma_heap_create(cma);
 	if (IS_ERR(heap))
@@ -116,8 +116,8 @@ int __ion_add_cma_heaps(struct cma *cma, void *data)
 
 	heap->name = cma_get_name(cma);
 
-        ion_device_add_heap(heap);
-        return 0;
+	ion_device_add_heap(heap);
+	return 0;
 }
 
 static int ion_add_cma_heaps(void)
-- 
1.9.1

Re: [PATCH] staging: android: ion: fix coding style issue

[Greg KH]

On Sun, Apr 23, 2017 at 03:37:29PM +0530, Adheer Chandravanshi wrote:
> Use tab instead of spaces for indentation, as reported by checkpatch.pl
> 
> Signed-off-by: Adheer Chandravanshi <adheerchandravanshi@gmail.com>
> ---
>  drivers/staging/android/ion/ion_cma_heap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Someone else sent this patch right before you did, sorry :(

Re: [PATCH] staging: android: ion: fix coding style issue

[adheer chandravanshi]

On Wed, Apr 26, 2017 at 12:26 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Apr 23, 2017 at 03:37:29PM +0530, Adheer Chandravanshi wrote:
>> Use tab instead of spaces for indentation, as reported by checkpatch.pl
>>
>> Signed-off-by: Adheer Chandravanshi <adheerchandravanshi@gmail.com>
>> ---
>>  drivers/staging/android/ion/ion_cma_heap.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> Someone else sent this patch right before you did, sorry :(

No issues, thanks for letting me know about it.

[PATCH] staging: android: ion: fix coding style issue

[Youngdo, Lee]

Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl.

Signed-off-by: Youngdo, Lee <oss.ydlee@gmail.com>
---
 drivers/staging/android/ion/ion_cma_heap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index 22b9582..6c40685 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -55,7 +55,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
 	if (align > PAGE_SIZE)
 		return -EINVAL;
 
-	info = kzalloc(sizeof(struct ion_cma_buffer_info), GFP_KERNEL);
+	info = kzalloc(sizeof(*info), GFP_KERNEL);
 	if (!info)
 		return -ENOMEM;
 
@@ -67,7 +67,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
 		goto err;
 	}
 
-	info->table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
+	info->table = kmalloc(sizeof(*info->table), GFP_KERNEL);
 	if (!info->table)
 		goto free_mem;
 
@@ -140,7 +140,7 @@ struct ion_heap *ion_cma_heap_create(struct ion_platform_heap *data)
 {
 	struct ion_cma_heap *cma_heap;
 
-	cma_heap = kzalloc(sizeof(struct ion_cma_heap), GFP_KERNEL);
+	cma_heap = kzalloc(sizeof(*cma_heap), GFP_KERNEL);
 
 	if (!cma_heap)
 		return ERR_PTR(-ENOMEM);
-- 
1.9.1