* Incorrect checkpatch warning
@ 2011-11-04 8:00 Adrian Hunter
2011-11-04 10:23 ` Girish K S
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Hunter @ 2011-11-04 8:00 UTC (permalink / raw)
To: joe; +Cc: linux-kernel, linux-mmc
Hi
This checkpatch warning looks wrong:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#73: FILE: drivers/mmc/host/sdhci-pci-data.c:5:
+EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
The patch has this:
diff --git a/drivers/mmc/host/sdhci-pci-data.c b/drivers/mmc/host/sdhci-pci-data.c
new file mode 100644
index 0000000..a611217
--- /dev/null
+++ b/drivers/mmc/host/sdhci-pci-data.c
@@ -0,0 +1,5 @@
+#include <linux/module.h>
+#include <linux/mmc/sdhci-pci-data.h>
+
+struct sdhci_pci_data *(*sdhci_pci_get_data)(struct pci_dev *pdev, int slotno);
+EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
Regards
Adrian
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Incorrect checkpatch warning
2011-11-04 8:00 Incorrect checkpatch warning Adrian Hunter
@ 2011-11-04 10:23 ` Girish K S
0 siblings, 0 replies; 2+ messages in thread
From: Girish K S @ 2011-11-04 10:23 UTC (permalink / raw)
To: Adrian Hunter; +Cc: joe, linux-kernel, linux-mmc
On 4 November 2011 04:00, Adrian Hunter <adrian.hunter@intel.com> wrote:
> Hi
>
> This checkpatch warning looks wrong:
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #73: FILE: drivers/mmc/host/sdhci-pci-data.c:5:
> +EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
>
> The patch has this:
>
> diff --git a/drivers/mmc/host/sdhci-pci-data.c b/drivers/mmc/host/sdhci-pci-data.c
> new file mode 100644
> index 0000000..a611217
> --- /dev/null
> +++ b/drivers/mmc/host/sdhci-pci-data.c
> @@ -0,0 +1,5 @@
> +#include <linux/module.h>
> +#include <linux/mmc/sdhci-pci-data.h>
> +
> +struct sdhci_pci_data *(*sdhci_pci_get_data)(struct pci_dev *pdev, int slotno);
> +EXPORT_SYMBOL_GPL(sdhci_pci_get_data);
>since it is a prototype you get that message. use EXPORT_SYMBOL below the function definition and not below prototype declaration
>
> Regards
> Adrian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-04 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-04 8:00 Incorrect checkpatch warning Adrian Hunter
2011-11-04 10:23 ` Girish K S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).