* Re: [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power
@ 2023-06-14 9:13 Mithil
2023-06-14 13:30 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Mithil @ 2023-06-14 9:13 UTC (permalink / raw)
To: robh
Cc: bavishimithil, contact, devicetree, dmitry.torokhov,
krzysztof.kozlowski+dt, lee, linux-arm-kernel, linux-input,
linux-kernel, linux-omap, linux-pm, linux, sre, tony
Subject: Re: [PATCH 05/10] dt-bindings: power: reset: Add bindings for
twl6030-power
On Tue, Aug 23, 2022 at 12:54 AM Rob Herring <robh@kernel.org> wrote:
>
> On Sat, Aug 20, 2022 at 12:46:55PM +0530, Mithil Bavishi wrote:
> > Adds documentation for the twl6030 power driver.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
> > ---
> > .../bindings/power/reset/twl6030-power.txt | 31 +++++++++++++++++++
>
> New bindings must be DT schema format.
>
> > 1 file changed, 31 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/reset/twl6030-power.txt
> >
> > diff --git a/Documentation/devicetree/bindings/power/reset/twl6030-power.txt b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
> > new file mode 100644
> > index 000000000..946bb3d9f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
> > @@ -0,0 +1,31 @@
> > +Texas Instruments TWL family (twl6030) reset and power management module
> > +
> > +For now, the binding only supports the complete shutdown of the system after
> > +poweroff.
> > +
> > +Required properties:
> > +- compatible : must be
> > + "ti,twl6030-power"
> > +
> > +Optional properties:
> > +
> > +- ti,system-power-controller: This indicates that TWL6030 is the
>
> We have a generic property for this.
>
What is property is that? And how would it get implemented here?
> > + power supply master of the system. With this flag, the chip will
> > + initiate an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> > + system poweroffs.
> > +
> > +Example:
> > +&i2c1 {
> > + clock-frequency = <2600000>;
> > +
> > + twl: twl@48 {
> > + reg = <0x48>;
> > + interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> > + interrupt-parent = <&intc>;
> > +
> > + twl_power: power {
> > + compatible = "ti,twl6030-power";
> > + ti,system-power-controller;
>
> Why do you need a child node here? There aren't any resources for the
> sub-block.
>
Just an example and how it is used on a device as well, is it fine if
just the block is as-is?
Mithil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power
2023-06-14 9:13 [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power Mithil
@ 2023-06-14 13:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-14 13:30 UTC (permalink / raw)
To: Mithil, robh
Cc: contact, devicetree, dmitry.torokhov, krzysztof.kozlowski+dt,
lee, linux-arm-kernel, linux-input, linux-kernel, linux-omap,
linux-pm, linux, sre, tony
On 14/06/2023 11:13, Mithil wrote:
> Subject: Re: [PATCH 05/10] dt-bindings: power: reset: Add bindings for
> twl6030-power
>
> On Tue, Aug 23, 2022 at 12:54 AM Rob Herring <robh@kernel.org> wrote:
>>
>> On Sat, Aug 20, 2022 at 12:46:55PM +0530, Mithil Bavishi wrote:
>>> Adds documentation for the twl6030 power driver.
>>>
>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>>> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
>>> ---
>>> .../bindings/power/reset/twl6030-power.txt | 31 +++++++++++++++++++
>>
>> New bindings must be DT schema format.
>>
>>> 1 file changed, 31 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/power/reset/twl6030-power.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/reset/twl6030-power.txt b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
>>> new file mode 100644
>>> index 000000000..946bb3d9f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
>>> @@ -0,0 +1,31 @@
>>> +Texas Instruments TWL family (twl6030) reset and power management module
>>> +
>>> +For now, the binding only supports the complete shutdown of the system after
>>> +poweroff.
>>> +
>>> +Required properties:
>>> +- compatible : must be
>>> + "ti,twl6030-power"
>>> +
>>> +Optional properties:
>>> +
>>> +- ti,system-power-controller: This indicates that TWL6030 is the
>>
>> We have a generic property for this.
>>
>
> What is property is that? And how would it get implemented here?
Easy to guess...
git grep system-power-controller
>
>>> + power supply master of the system. With this flag, the chip will
>>> + initiate an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
>>> + system poweroffs.
>>> +
>>> +Example:
>>> +&i2c1 {
>>> + clock-frequency = <2600000>;
>>> +
>>> + twl: twl@48 {
>>> + reg = <0x48>;
>>> + interrupts = <7>; /* SYS_NIRQ cascaded to intc */
>>> + interrupt-parent = <&intc>;
>>> +
>>> + twl_power: power {
>>> + compatible = "ti,twl6030-power";
>>> + ti,system-power-controller;
>>
>> Why do you need a child node here? There aren't any resources for the
>> sub-block.
>>
>
> Just an example and how it is used on a device as well, is it fine if
> just the block is as-is?
The question is not about example. Question was why do you need child
node at all. Children without resources are usually useless.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power
2022-08-20 7:16 ` [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power Mithil Bavishi
@ 2022-08-22 19:24 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-08-22 19:24 UTC (permalink / raw)
To: Mithil Bavishi
Cc: linux-input, devicetree, linux-kernel, linux-pm, linux-omap,
linux-arm-kernel, dmitry.torokhov, krzysztof.kozlowski+dt, lee,
sre, tony, linux, contact
On Sat, Aug 20, 2022 at 12:46:55PM +0530, Mithil Bavishi wrote:
> Adds documentation for the twl6030 power driver.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
> ---
> .../bindings/power/reset/twl6030-power.txt | 31 +++++++++++++++++++
New bindings must be DT schema format.
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/reset/twl6030-power.txt
>
> diff --git a/Documentation/devicetree/bindings/power/reset/twl6030-power.txt b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
> new file mode 100644
> index 000000000..946bb3d9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
> @@ -0,0 +1,31 @@
> +Texas Instruments TWL family (twl6030) reset and power management module
> +
> +For now, the binding only supports the complete shutdown of the system after
> +poweroff.
> +
> +Required properties:
> +- compatible : must be
> + "ti,twl6030-power"
> +
> +Optional properties:
> +
> +- ti,system-power-controller: This indicates that TWL6030 is the
We have a generic property for this.
> + power supply master of the system. With this flag, the chip will
> + initiate an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> + system poweroffs.
> +
> +Example:
> +&i2c1 {
> + clock-frequency = <2600000>;
> +
> + twl: twl@48 {
> + reg = <0x48>;
> + interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> + interrupt-parent = <&intc>;
> +
> + twl_power: power {
> + compatible = "ti,twl6030-power";
> + ti,system-power-controller;
Why do you need a child node here? There aren't any resources for the
sub-block.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power
2022-08-20 7:16 [PATCH 00/10] Add TWL6030 power off and powerbutton support Mithil Bavishi
@ 2022-08-20 7:16 ` Mithil Bavishi
2022-08-22 19:24 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Mithil Bavishi @ 2022-08-20 7:16 UTC (permalink / raw)
To: linux-input, devicetree, linux-kernel, linux-pm, linux-omap,
linux-arm-kernel
Cc: dmitry.torokhov, robh+dt, krzysztof.kozlowski+dt, lee, sre, tony,
linux, bavishimithil, contact
Adds documentation for the twl6030 power driver.
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
---
.../bindings/power/reset/twl6030-power.txt | 31 +++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/reset/twl6030-power.txt
diff --git a/Documentation/devicetree/bindings/power/reset/twl6030-power.txt b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
new file mode 100644
index 000000000..946bb3d9f
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/twl6030-power.txt
@@ -0,0 +1,31 @@
+Texas Instruments TWL family (twl6030) reset and power management module
+
+For now, the binding only supports the complete shutdown of the system after
+poweroff.
+
+Required properties:
+- compatible : must be
+ "ti,twl6030-power"
+
+Optional properties:
+
+- ti,system-power-controller: This indicates that TWL6030 is the
+ power supply master of the system. With this flag, the chip will
+ initiate an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
+ system poweroffs.
+
+Example:
+&i2c1 {
+ clock-frequency = <2600000>;
+
+ twl: twl@48 {
+ reg = <0x48>;
+ interrupts = <7>; /* SYS_NIRQ cascaded to intc */
+ interrupt-parent = <&intc>;
+
+ twl_power: power {
+ compatible = "ti,twl6030-power";
+ ti,system-power-controller;
+ };
+ };
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-14 13:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 9:13 [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power Mithil
2023-06-14 13:30 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2022-08-20 7:16 [PATCH 00/10] Add TWL6030 power off and powerbutton support Mithil Bavishi
2022-08-20 7:16 ` [PATCH 05/10] dt-bindings: power: reset: Add bindings for twl6030-power Mithil Bavishi
2022-08-22 19:24 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).