* [PATCH] fs: cifs: Remove unnecessary struct declaration
@ 2021-04-01 7:51 Wan Jiabing
2021-04-02 15:42 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-04-01 7:51 UTC (permalink / raw)
To: Steve French, linux-cifs, samba-technical, linux-kernel
Cc: kael_w, Wan Jiabing
struct cifs_readdata is declared twice. One is declared
at 208th line.
And struct cifs_readdata is defined blew.
The declaration here is not needed. Remove the duplicate.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
fs/cifs/cifsglob.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 67c056a9a519..ec824ab8c5ca 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -1283,8 +1283,6 @@ struct cifs_aio_ctx {
bool direct_io;
};
-struct cifs_readdata;
-
/* asynchronous read support */
struct cifs_readdata {
struct kref refcount;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: cifs: Remove unnecessary struct declaration
2021-04-01 7:51 [PATCH] fs: cifs: Remove unnecessary struct declaration Wan Jiabing
@ 2021-04-02 15:42 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2021-04-02 15:42 UTC (permalink / raw)
To: Wan Jiabing; +Cc: Steve French, CIFS, samba-technical, LKML, kael_w
merged into cifs-2.6.git for-next
On Thu, Apr 1, 2021 at 2:52 AM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> struct cifs_readdata is declared twice. One is declared
> at 208th line.
> And struct cifs_readdata is defined blew.
> The declaration here is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> fs/cifs/cifsglob.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 67c056a9a519..ec824ab8c5ca 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1283,8 +1283,6 @@ struct cifs_aio_ctx {
> bool direct_io;
> };
>
> -struct cifs_readdata;
> -
> /* asynchronous read support */
> struct cifs_readdata {
> struct kref refcount;
> --
> 2.25.1
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-02 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 7:51 [PATCH] fs: cifs: Remove unnecessary struct declaration Wan Jiabing
2021-04-02 15:42 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).