* [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()
@ 2014-06-10 10:03 Björn Baumbach
2014-06-16 13:49 ` Stefan (metze) Metzmacher
0 siblings, 1 reply; 4+ messages in thread
From: Björn Baumbach @ 2014-06-10 10:03 UTC (permalink / raw)
To: Steve French
Cc: linux-cifs, linux-kernel, Pavel Shilovsky, stable,
Björn Baumbach, Stefan Metzmacher
commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
("CIFS: Cleanup cifs open codepath")
changed disposition to FILE_OPEN.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Cc: <stable@vger.kernel.org> # v3.14+
Cc: Pavel Shilovsky <piastry@etersoft.ru>
Cc: Steve French <sfrench@samba.org>
---
fs/cifs/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 264ece7..68559fd 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
oparms.cifs_sb = cifs_sb;
oparms.desired_access = GENERIC_WRITE;
oparms.create_options = create_options;
- oparms.disposition = FILE_OPEN;
+ oparms.disposition = FILE_CREATE;
oparms.path = path;
oparms.fid = &fid;
oparms.reconnect = false;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()
2014-06-10 10:03 [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink() Björn Baumbach
@ 2014-06-16 13:49 ` Stefan (metze) Metzmacher
2014-06-16 22:07 ` Steve French
0 siblings, 1 reply; 4+ messages in thread
From: Stefan (metze) Metzmacher @ 2014-06-16 13:49 UTC (permalink / raw)
To: Björn Baumbach, Steve French
Cc: linux-cifs, linux-kernel, stable, Steve French, Pavel Shilovsky
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
Hi Steve,
any comments on this? How can we get this fixed upstream?
Thanks!
metze
Am 10.06.2014 12:03, schrieb Björn Baumbach:
> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
> ("CIFS: Cleanup cifs open codepath")
> changed disposition to FILE_OPEN.
>
> Signed-off-by: Björn Baumbach <bb@sernet.de>
> Signed-off-by: Stefan Metzmacher <metze@samba.org>
> Reviewed-by: Stefan Metzmacher <metze@samba.org>
> Cc: <stable@vger.kernel.org> # v3.14+
> Cc: Pavel Shilovsky <piastry@etersoft.ru>
> Cc: Steve French <sfrench@samba.org>
> ---
> fs/cifs/link.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> index 264ece7..68559fd 100644
> --- a/fs/cifs/link.c
> +++ b/fs/cifs/link.c
> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
> oparms.cifs_sb = cifs_sb;
> oparms.desired_access = GENERIC_WRITE;
> oparms.create_options = create_options;
> - oparms.disposition = FILE_OPEN;
> + oparms.disposition = FILE_CREATE;
> oparms.path = path;
> oparms.fid = &fid;
> oparms.reconnect = false;
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()
2014-06-16 13:49 ` Stefan (metze) Metzmacher
@ 2014-06-16 22:07 ` Steve French
2014-06-17 8:56 ` Stefan (metze) Metzmacher
0 siblings, 1 reply; 4+ messages in thread
From: Steve French @ 2014-06-16 22:07 UTC (permalink / raw)
To: Stefan (metze) Metzmacher
Cc: Björn Baumbach, Steve French, linux-cifs, LKML, stable,
Pavel Shilovsky
Although I have merged this into cifs-2.6.git for-next, in my testing
I am also seeing this fail with vers=3.0 (and probably 2.0 and 2.1) so
I would like to fix that too (and mfsymlinks may be at least as
important there)
On Mon, Jun 16, 2014 at 8:49 AM, Stefan (metze) Metzmacher
<metze@samba.org> wrote:
> Hi Steve,
>
> any comments on this? How can we get this fixed upstream?
>
> Thanks!
> metze
>
> Am 10.06.2014 12:03, schrieb Björn Baumbach:
>> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
>> ("CIFS: Cleanup cifs open codepath")
>> changed disposition to FILE_OPEN.
>>
>> Signed-off-by: Björn Baumbach <bb@sernet.de>
>> Signed-off-by: Stefan Metzmacher <metze@samba.org>
>> Reviewed-by: Stefan Metzmacher <metze@samba.org>
>> Cc: <stable@vger.kernel.org> # v3.14+
>> Cc: Pavel Shilovsky <piastry@etersoft.ru>
>> Cc: Steve French <sfrench@samba.org>
>> ---
>> fs/cifs/link.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
>> index 264ece7..68559fd 100644
>> --- a/fs/cifs/link.c
>> +++ b/fs/cifs/link.c
>> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
>> oparms.cifs_sb = cifs_sb;
>> oparms.desired_access = GENERIC_WRITE;
>> oparms.create_options = create_options;
>> - oparms.disposition = FILE_OPEN;
>> + oparms.disposition = FILE_CREATE;
>> oparms.path = path;
>> oparms.fid = &fid;
>> oparms.reconnect = false;
>>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()
2014-06-16 22:07 ` Steve French
@ 2014-06-17 8:56 ` Stefan (metze) Metzmacher
0 siblings, 0 replies; 4+ messages in thread
From: Stefan (metze) Metzmacher @ 2014-06-17 8:56 UTC (permalink / raw)
To: Steve French
Cc: Björn Baumbach, Steve French, linux-cifs, LKML, stable,
Pavel Shilovsky
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
Hi Steve,
> Although I have merged this into cifs-2.6.git for-next, in my testing
> I am also seeing this fail with vers=3.0 (and probably 2.0 and 2.1) so
> I would like to fix that too (and mfsymlinks may be at least as
> important there)
Thanks! When can we expect this to be proposed for 3.16 (and stable
3.14/3.15)?
metze
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-17 8:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-10 10:03 [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink() Björn Baumbach
2014-06-16 13:49 ` Stefan (metze) Metzmacher
2014-06-16 22:07 ` Steve French
2014-06-17 8:56 ` Stefan (metze) Metzmacher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).