* [PATCH] cifs: Fix crash on unload of cifs_arc4.ko
@ 2021-12-07 11:54 Vincent Whitchurch
2021-12-08 4:33 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Vincent Whitchurch @ 2021-12-07 11:54 UTC (permalink / raw)
To: Steve French, Namjae Jeon, Sergey Senozhatsky, Hyunchul Lee
Cc: kernel, Vincent Whitchurch, Steve French, Ronnie Sahlberg,
linux-cifs, samba-technical, linux-kernel
The exit function is wrongly placed in the __init section and this leads
to a crash when the module is unloaded. Just remove both the init and
exit functions since this module does not need them.
Fixes: 71c02863246167b3d ("cifs: fork arc4 and create a separate module...")
Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
---
fs/smbfs_common/cifs_arc4.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/fs/smbfs_common/cifs_arc4.c b/fs/smbfs_common/cifs_arc4.c
index 85ba15a60b13..043e4cb839fa 100644
--- a/fs/smbfs_common/cifs_arc4.c
+++ b/fs/smbfs_common/cifs_arc4.c
@@ -72,16 +72,3 @@ void cifs_arc4_crypt(struct arc4_ctx *ctx, u8 *out, const u8 *in, unsigned int l
ctx->y = y;
}
EXPORT_SYMBOL_GPL(cifs_arc4_crypt);
-
-static int __init
-init_smbfs_common(void)
-{
- return 0;
-}
-static void __init
-exit_smbfs_common(void)
-{
-}
-
-module_init(init_smbfs_common)
-module_exit(exit_smbfs_common)
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cifs: Fix crash on unload of cifs_arc4.ko
2021-12-07 11:54 [PATCH] cifs: Fix crash on unload of cifs_arc4.ko Vincent Whitchurch
@ 2021-12-08 4:33 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2021-12-08 4:33 UTC (permalink / raw)
To: Vincent Whitchurch
Cc: Steve French, Namjae Jeon, Sergey Senozhatsky, Hyunchul Lee,
CIFS, samba-technical, LKML, Ronnie Sahlberg, kernel,
Steve French
merged into cifs-2.6.git for-next
On Tue, Dec 7, 2021 at 6:11 AM Vincent Whitchurch via samba-technical
<samba-technical@lists.samba.org> wrote:
>
> The exit function is wrongly placed in the __init section and this leads
> to a crash when the module is unloaded. Just remove both the init and
> exit functions since this module does not need them.
>
> Fixes: 71c02863246167b3d ("cifs: fork arc4 and create a separate module...")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> ---
> fs/smbfs_common/cifs_arc4.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/fs/smbfs_common/cifs_arc4.c b/fs/smbfs_common/cifs_arc4.c
> index 85ba15a60b13..043e4cb839fa 100644
> --- a/fs/smbfs_common/cifs_arc4.c
> +++ b/fs/smbfs_common/cifs_arc4.c
> @@ -72,16 +72,3 @@ void cifs_arc4_crypt(struct arc4_ctx *ctx, u8 *out, const u8 *in, unsigned int l
> ctx->y = y;
> }
> EXPORT_SYMBOL_GPL(cifs_arc4_crypt);
> -
> -static int __init
> -init_smbfs_common(void)
> -{
> - return 0;
> -}
> -static void __init
> -exit_smbfs_common(void)
> -{
> -}
> -
> -module_init(init_smbfs_common)
> -module_exit(exit_smbfs_common)
> --
> 2.33.1
>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-08 4:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-07 11:54 [PATCH] cifs: Fix crash on unload of cifs_arc4.ko Vincent Whitchurch
2021-12-08 4:33 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).