* [PATCH] Clean up lirc zilog error codes
@ 2017-07-11 17:57 Yves Lemée
2017-07-12 5:44 ` Frans Klaver
0 siblings, 1 reply; 2+ messages in thread
From: Yves Lemée @ 2017-07-11 17:57 UTC (permalink / raw)
To: mchehab; +Cc: gregkh, linux-media, devel, linux-kernel
According the coding style guidelines, the ENOSYS error code must be returned
in case of a non existent system call. This code has been replaced with
the ENOTTY error code indicating, a missing functionality.
Signed-off-by: Yves Lemée <yves.lemee.kernel@gmail.com>
---
drivers/staging/media/lirc/lirc_zilog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
index 015e41bd036e..26dd32d5b5b2 100644
--- a/drivers/staging/media/lirc/lirc_zilog.c
+++ b/drivers/staging/media/lirc/lirc_zilog.c
@@ -1249,7 +1249,7 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
break;
case LIRC_GET_REC_MODE:
if (!(features & LIRC_CAN_REC_MASK))
- return -ENOSYS;
+ return -ENOTTY;
result = put_user(LIRC_REC2MODE
(features & LIRC_CAN_REC_MASK),
@@ -1257,21 +1257,21 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
break;
case LIRC_SET_REC_MODE:
if (!(features & LIRC_CAN_REC_MASK))
- return -ENOSYS;
+ return -ENOTTY;
result = get_user(mode, uptr);
if (!result && !(LIRC_MODE2REC(mode) & features))
- result = -EINVAL;
+ result = -ENOTTY;
break;
case LIRC_GET_SEND_MODE:
if (!(features & LIRC_CAN_SEND_MASK))
- return -ENOSYS;
+ return -ENOTTY;
result = put_user(LIRC_MODE_PULSE, uptr);
break;
case LIRC_SET_SEND_MODE:
if (!(features & LIRC_CAN_SEND_MASK))
- return -ENOSYS;
+ return -ENOTTY;
result = get_user(mode, uptr);
if (!result && mode != LIRC_MODE_PULSE)
--
2.13.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Clean up lirc zilog error codes
2017-07-11 17:57 [PATCH] Clean up lirc zilog error codes Yves Lemée
@ 2017-07-12 5:44 ` Frans Klaver
0 siblings, 0 replies; 2+ messages in thread
From: Frans Klaver @ 2017-07-12 5:44 UTC (permalink / raw)
To: Yves Lemée; +Cc: mchehab, driverdevel, Greg KH, linux-kernel, linux-media
On Tue, Jul 11, 2017 at 7:57 PM, Yves Lemée <yves.lemee.kernel@gmail.com> wrote:
> According the coding style guidelines, the ENOSYS error code must be returned
> in case of a non existent system call. This code has been replaced with
> the ENOTTY error code indicating, a missing functionality.
>
> Signed-off-by: Yves Lemée <yves.lemee.kernel@gmail.com>
Your subject line is not according to the patch submission guidelines.
Also, on a nit-picking note, that comma after 'indicating' is rather
oddly placed. Please move or remove it.
Frans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-12 5:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11 17:57 [PATCH] Clean up lirc zilog error codes Yves Lemée
2017-07-12 5:44 ` Frans Klaver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).