* [PATCH] audit: fixed a braces coding style issue
@ 2018-09-21 23:38 Przemysław Głębocki
2018-09-22 20:21 ` Paul Moore
0 siblings, 1 reply; 3+ messages in thread
From: Przemysław Głębocki @ 2018-09-21 23:38 UTC (permalink / raw)
To: paul; +Cc: linux-audit, linux-kernel, Przemysław Głębocki
Fixed a coding style issue.
Signed-off-by: Przemysław Głębocki <glebocki.przemyslaw@gmail.com>
---
kernel/audit_tree.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
index ea43181cde4a..3d0e45fa765d 100644
--- a/kernel/audit_tree.c
+++ b/kernel/audit_tree.c
@@ -112,10 +112,9 @@ static void free_chunk(struct audit_chunk *chunk)
{
int i;
- for (i = 0; i < chunk->count; i++) {
+ for (i = 0; i < chunk->count; i++)
if (chunk->owners[i].owner)
put_tree(chunk->owners[i].owner);
- }
kfree(chunk);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] audit: fixed a braces coding style issue
2018-09-21 23:38 [PATCH] audit: fixed a braces coding style issue Przemysław Głębocki
@ 2018-09-22 20:21 ` Paul Moore
0 siblings, 0 replies; 3+ messages in thread
From: Paul Moore @ 2018-09-22 20:21 UTC (permalink / raw)
To: glebocki.przemyslaw; +Cc: linux-audit, linux-kernel
On Fri, Sep 21, 2018 at 7:38 PM Przemysław Głębocki
<glebocki.przemyslaw@gmail.com> wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Przemysław Głębocki <glebocki.przemyslaw@gmail.com>
> ---
> kernel/audit_tree.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
I generally dislike accepting coding style patches from people who
haven't made any significant code contributions. Would you be
interested in participating in upstream audit development? We have a
number of open issues that you could take a look at if you are
interested ...
* https://github.com/linux-audit/audit-kernel/issues
> diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
> index ea43181cde4a..3d0e45fa765d 100644
> --- a/kernel/audit_tree.c
> +++ b/kernel/audit_tree.c
> @@ -112,10 +112,9 @@ static void free_chunk(struct audit_chunk *chunk)
> {
> int i;
>
> - for (i = 0; i < chunk->count; i++) {
> + for (i = 0; i < chunk->count; i++)
> if (chunk->owners[i].owner)
> put_tree(chunk->owners[i].owner);
> - }
> kfree(chunk);
> }
>
> --
> 2.17.1
>
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] audit: fixed a braces coding style issue
@ 2018-09-22 12:38 Przemysław Głębocki
0 siblings, 0 replies; 3+ messages in thread
From: Przemysław Głębocki @ 2018-09-22 12:38 UTC (permalink / raw)
To: eparis; +Cc: linux-audit, linux-kernel, Przemysław Głębocki
Fixed a coding style issue.
Signed-off-by: Przemysław Głębocki <glebocki.przemyslaw@gmail.com>
---
kernel/audit_tree.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
index ea43181cde4a..3d0e45fa765d 100644
--- a/kernel/audit_tree.c
+++ b/kernel/audit_tree.c
@@ -112,10 +112,9 @@ static void free_chunk(struct audit_chunk *chunk)
{
int i;
- for (i = 0; i < chunk->count; i++) {
+ for (i = 0; i < chunk->count; i++)
if (chunk->owners[i].owner)
put_tree(chunk->owners[i].owner);
- }
kfree(chunk);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-22 20:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-21 23:38 [PATCH] audit: fixed a braces coding style issue Przemysław Głębocki
2018-09-22 20:21 ` Paul Moore
2018-09-22 12:38 Przemysław Głębocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).