* [PATCH -next] selinux: Fix kernel-doc
@ 2021-06-10 9:38 Yang Li
2021-06-11 1:06 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-06-10 9:38 UTC (permalink / raw)
To: paul
Cc: stephen.smalley.work, eparis, nathan, ndesaulniers, selinux,
linux-kernel, clang-built-linux, Yang Li
Fix function name in ss/services.c kernel-doc comment
to remove a warning found by running make W=1 LLVM=1.
security/selinux/ss/services.c:2437: warning: expecting prototype for
security_pkey_sid(). Prototype was for security_ib_pkey_sid() instead.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
security/selinux/ss/services.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 3658488..bb043bf 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -2423,7 +2423,7 @@ int security_port_sid(struct selinux_state *state,
}
/**
- * security_pkey_sid - Obtain the SID for a pkey.
+ * security_ib_pkey_sid - Obtain the SID for a pkey.
* @subnet_prefix: Subnet Prefix
* @pkey_num: pkey number
* @out_sid: security identifier
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] selinux: Fix kernel-doc
2021-06-10 9:38 [PATCH -next] selinux: Fix kernel-doc Yang Li
@ 2021-06-11 1:06 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2021-06-11 1:06 UTC (permalink / raw)
To: Yang Li
Cc: Stephen Smalley, Eric Paris, nathan, ndesaulniers, selinux,
linux-kernel, clang-built-linux
On Thu, Jun 10, 2021 at 5:38 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Fix function name in ss/services.c kernel-doc comment
> to remove a warning found by running make W=1 LLVM=1.
>
> security/selinux/ss/services.c:2437: warning: expecting prototype for
> security_pkey_sid(). Prototype was for security_ib_pkey_sid() instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> security/selinux/ss/services.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
> index 3658488..bb043bf 100644
> --- a/security/selinux/ss/services.c
> +++ b/security/selinux/ss/services.c
> @@ -2423,7 +2423,7 @@ int security_port_sid(struct selinux_state *state,
> }
>
> /**
> - * security_pkey_sid - Obtain the SID for a pkey.
> + * security_ib_pkey_sid - Obtain the SID for a pkey.
> * @subnet_prefix: Subnet Prefix
> * @pkey_num: pkey number
> * @out_sid: security identifier
This kdoc function header block is also missing the selinux_state
description. Would you mind adding something like the following and
resubmitting your patch?
* @state: SELinux state
... I suspect there are a number of function header comments with
similar problems in the SELinux code.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-11 1:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 9:38 [PATCH -next] selinux: Fix kernel-doc Yang Li
2021-06-11 1:06 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).