From: Paul Moore <paul@paul-moore.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
James Morris <jmorris@namei.org>,
LSM List <linux-security-module@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [GIT PULL] Security subsystem updates for 4.14
Date: Fri, 8 Sep 2017 13:36:29 -0400 [thread overview]
Message-ID: <CAHC9VhR2c1rC4--1Br0cx+3eALLdB8Oishw7wwcGwb1_3qN8+w@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFwMgUJSMQ96XdKnTbn8UsxzHTb8tZQdH40nxDeF7fWObw@mail.gmail.com>
On Fri, Sep 8, 2017 at 1:25 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Sep 8, 2017 at 12:09 AM, Christoph Hellwig <hch@infradead.org> wrote:
>>
>> But yes, for the init-time integrity_read_file this is incorrect.
>> It never tripped up, and I explicitly added the lockdep annotations
>> so that anything would show up, and it's been half a year since
>> I sent that first RFC patch..
>
> I don't think anybody actually tests linux-next kernels in any big
> way, and the automated tests that do get run probably don't run with
> any integrity checking enabled.
>
> Which is why I actually look at the code when merging unexpected stuff.
>
> This is also why I tend to prefer getting multiple branches for
> independent things.
>
> Now the whole security pull will be ignored because of this thing. I
> refuse to pull garbage where I notice major fundamental problems in
> code that has obviously never ever been tested.
Is it time to start sending pull request for each LSM and thing under
security/ directly? I'm not sure I have a strong preference either
way, I just don't want to see the SELinux changes ignored during the
merge window.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2017-09-08 17:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 10:29 [GIT PULL] Security subsystem updates for 4.14 James Morris
2017-09-07 18:19 ` Linus Torvalds
2017-09-08 4:48 ` James Morris
2017-09-08 7:09 ` Christoph Hellwig
2017-09-08 17:25 ` Linus Torvalds
2017-09-08 17:36 ` Paul Moore [this message]
2017-09-10 4:32 ` James Morris
2017-09-10 4:53 ` James Morris
2017-09-11 22:30 ` Paul Moore
2017-09-14 21:09 ` Kees Cook
2017-09-14 21:13 ` James Morris
2017-09-14 21:25 ` Kees Cook
2017-09-08 19:57 ` James Morris
2017-09-17 7:36 ` Mimi Zohar
2017-09-10 8:10 ` Christoph Hellwig
2017-09-10 14:02 ` Mimi Zohar
2017-09-11 6:38 ` Christoph Hellwig
2017-09-11 21:34 ` Mimi Zohar
2017-09-08 22:38 ` Theodore Ts'o
2017-09-10 2:08 ` James Morris
2017-09-10 7:13 ` Mimi Zohar
2017-09-10 12:17 ` Theodore Ts'o
2017-09-10 6:46 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhR2c1rC4--1Br0cx+3eALLdB8Oishw7wwcGwb1_3qN8+w@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=hch@infradead.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).