linux-next: build warning after merge of the audit tree

linux-next: build warning after merge of the audit tree

[Stephen Rothwell]

Hi Paul,

After merging the audit tree, today's linux-next build (i386 defconfig
and others) produced this warning:

security/lsm_audit.c: In function 'dump_common_audit_data':
security/lsm_audit.c:340:9: warning: passing argument 1 of 'unix_sk' discards 'const' qualifier from pointer target type
     u = unix_sk(sk);
         ^
In file included from security/lsm_audit.c:22:0:
include/net/af_unix.h:67:33: note: expected 'struct sock *' but argument is of type 'const struct sock *'
 static inline struct unix_sock *unix_sk(struct sock *sk)
                                 ^

Introduced by commit

  43cfd5e38587 ("audit: constify parts of common_audit_data and lsm_network_audit")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build warning after merge of the audit tree

[Paul Moore]

On Tue, Oct 6, 2015 at 1:46 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Paul,
>
> After merging the audit tree, today's linux-next build (i386 defconfig
> and others) produced this warning:
>
> security/lsm_audit.c: In function 'dump_common_audit_data':
> security/lsm_audit.c:340:9: warning: passing argument 1 of 'unix_sk' discards 'const' qualifier from pointer target type
>      u = unix_sk(sk);
>          ^
> In file included from security/lsm_audit.c:22:0:
> include/net/af_unix.h:67:33: note: expected 'struct sock *' but argument is of type 'const struct sock *'
>  static inline struct unix_sock *unix_sk(struct sock *sk)
>                                  ^
>
> Introduced by commit
>
>   43cfd5e38587 ("audit: constify parts of common_audit_data and lsm_network_audit")

Hi Stephen,

I apologize for the build warning, for some reason it works just fine
in audit#next but causes problems on top of more current trees.  I'm
going to drop the patch until I've resolved the issue.

-- 
paul moore
www.paul-moore.com