* [PATCH v2] selinux: Fix error return code in sel_ib_pkey_sid_slow()
@ 2020-11-12 13:53 Chen Zhou
2020-11-13 1:17 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2020-11-12 13:53 UTC (permalink / raw)
To: paul, stephen.smalley.work, eparis, danielj, dledford
Cc: selinux, linux-kernel, chenzhou10, Hulk Robot
Fix to return a negative error code from the error handling case
instead of 0 in function sel_ib_pkey_sid_slow(), as done elsewhere
in this function.
Fixes: 409dcf31538a ("selinux: Add a cache for quicker retreival of PKey SIDs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
security/selinux/ibpkey.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/security/selinux/ibpkey.c b/security/selinux/ibpkey.c
index f68a7617cfb9..3a63a989e55e 100644
--- a/security/selinux/ibpkey.c
+++ b/security/selinux/ibpkey.c
@@ -151,8 +151,10 @@ static int sel_ib_pkey_sid_slow(u64 subnet_prefix, u16 pkey_num, u32 *sid)
* is valid, it just won't be added to the cache.
*/
new = kzalloc(sizeof(*new), GFP_ATOMIC);
- if (!new)
+ if (!new) {
+ ret = -ENOMEM;
goto out;
+ }
new->psec.subnet_prefix = subnet_prefix;
new->psec.pkey = pkey_num;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] selinux: Fix error return code in sel_ib_pkey_sid_slow()
2020-11-12 13:53 [PATCH v2] selinux: Fix error return code in sel_ib_pkey_sid_slow() Chen Zhou
@ 2020-11-13 1:17 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2020-11-13 1:17 UTC (permalink / raw)
To: Chen Zhou
Cc: Stephen Smalley, Eric Paris, danielj, dledford, selinux,
linux-kernel, Hulk Robot
On Thu, Nov 12, 2020 at 8:48 AM Chen Zhou <chenzhou10@huawei.com> wrote:
>
> Fix to return a negative error code from the error handling case
> instead of 0 in function sel_ib_pkey_sid_slow(), as done elsewhere
> in this function.
>
> Fixes: 409dcf31538a ("selinux: Add a cache for quicker retreival of PKey SIDs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> security/selinux/ibpkey.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thanks for the fix! I've merged this into the selinux/stable-5.10
branch and I'll send this up to Linus tomorrow or early next week.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-13 1:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 13:53 [PATCH v2] selinux: Fix error return code in sel_ib_pkey_sid_slow() Chen Zhou
2020-11-13 1:17 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).