* [PATCH] LSM: Avoid warnings about potentially unused hook variables
@ 2021-10-13 17:28 Kees Cook
2021-10-13 17:53 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2021-10-13 17:28 UTC (permalink / raw)
To: linux-kernel
Cc: Kees Cook, James Morris, Serge E. Hallyn, Paul Moore,
Casey Schaufler, KP Singh, linux-security-module,
kernel test robot, linux-hardening
Building with W=1 shows many unused const variable warnings. These can
be silenced, as we're well aware of their being potentially unused:
./include/linux/lsm_hook_defs.h:36:18: error: 'ptrace_access_check_default' defined but not used [-Werror=unused-const-variable=]
36 | LSM_HOOK(int, 0, ptrace_access_check, struct task_struct *child,
| ^~~~~~~~~~~~~~~~~~~
security/security.c:706:32: note: in definition of macro 'LSM_RET_DEFAULT'
706 | #define LSM_RET_DEFAULT(NAME) (NAME##_default)
| ^~~~
security/security.c:711:9: note: in expansion of macro 'DECLARE_LSM_RET_DEFAULT_int'
711 | DECLARE_LSM_RET_DEFAULT_##RET(DEFAULT, NAME)
| ^~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/lsm_hook_defs.h:36:1: note: in expansion of macro 'LSM_HOOK'
36 | LSM_HOOK(int, 0, ptrace_access_check, struct task_struct *child,
| ^~~~~~~~
Cc: James Morris <jmorris@namei.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Paul Moore <paul@paul-moore.com>
Cc: Casey Schaufler <casey@schaufler-ca.com>
Cc: KP Singh <kpsingh@chromium.org>
Cc: linux-security-module@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/linux-mm/202110131608.zms53FPR-lkp@intel.com/
Fixes: 98e828a0650f ("security: Refactor declaration of LSM hooks")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
security/security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/security.c b/security/security.c
index 9ffa9e9c5c55..462f14354c2c 100644
--- a/security/security.c
+++ b/security/security.c
@@ -706,7 +706,7 @@ static int lsm_superblock_alloc(struct super_block *sb)
#define LSM_RET_DEFAULT(NAME) (NAME##_default)
#define DECLARE_LSM_RET_DEFAULT_void(DEFAULT, NAME)
#define DECLARE_LSM_RET_DEFAULT_int(DEFAULT, NAME) \
- static const int LSM_RET_DEFAULT(NAME) = (DEFAULT);
+ static const int __maybe_unused LSM_RET_DEFAULT(NAME) = (DEFAULT);
#define LSM_HOOK(RET, DEFAULT, NAME, ...) \
DECLARE_LSM_RET_DEFAULT_##RET(DEFAULT, NAME)
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] LSM: Avoid warnings about potentially unused hook variables
2021-10-13 17:28 [PATCH] LSM: Avoid warnings about potentially unused hook variables Kees Cook
@ 2021-10-13 17:53 ` Paul Moore
2021-10-13 21:51 ` James Morris
0 siblings, 1 reply; 4+ messages in thread
From: Paul Moore @ 2021-10-13 17:53 UTC (permalink / raw)
To: Kees Cook
Cc: linux-kernel, James Morris, Serge E. Hallyn, Casey Schaufler,
KP Singh, linux-security-module, kernel test robot,
linux-hardening
On Wed, Oct 13, 2021 at 1:31 PM Kees Cook <keescook@chromium.org> wrote:
>
> Building with W=1 shows many unused const variable warnings. These can
> be silenced, as we're well aware of their being potentially unused:
>
> ./include/linux/lsm_hook_defs.h:36:18: error: 'ptrace_access_check_default' defined but not used [-Werror=unused-const-variable=]
> 36 | LSM_HOOK(int, 0, ptrace_access_check, struct task_struct *child,
> | ^~~~~~~~~~~~~~~~~~~
> security/security.c:706:32: note: in definition of macro 'LSM_RET_DEFAULT'
> 706 | #define LSM_RET_DEFAULT(NAME) (NAME##_default)
> | ^~~~
> security/security.c:711:9: note: in expansion of macro 'DECLARE_LSM_RET_DEFAULT_int'
> 711 | DECLARE_LSM_RET_DEFAULT_##RET(DEFAULT, NAME)
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/lsm_hook_defs.h:36:1: note: in expansion of macro 'LSM_HOOK'
> 36 | LSM_HOOK(int, 0, ptrace_access_check, struct task_struct *child,
> | ^~~~~~~~
>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: Casey Schaufler <casey@schaufler-ca.com>
> Cc: KP Singh <kpsingh@chromium.org>
> Cc: linux-security-module@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/linux-mm/202110131608.zms53FPR-lkp@intel.com/
> Fixes: 98e828a0650f ("security: Refactor declaration of LSM hooks")
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> security/security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks reasonable to me, thanks Kees. Unless James wants to pick this
up for the security tree, I can pull this into the SElinux tree with
the io_uring change which is causing the testing robot to complain.
Acked-by: Paul Moore <paul@paul-moore.com>
> diff --git a/security/security.c b/security/security.c
> index 9ffa9e9c5c55..462f14354c2c 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -706,7 +706,7 @@ static int lsm_superblock_alloc(struct super_block *sb)
> #define LSM_RET_DEFAULT(NAME) (NAME##_default)
> #define DECLARE_LSM_RET_DEFAULT_void(DEFAULT, NAME)
> #define DECLARE_LSM_RET_DEFAULT_int(DEFAULT, NAME) \
> - static const int LSM_RET_DEFAULT(NAME) = (DEFAULT);
> + static const int __maybe_unused LSM_RET_DEFAULT(NAME) = (DEFAULT);
> #define LSM_HOOK(RET, DEFAULT, NAME, ...) \
> DECLARE_LSM_RET_DEFAULT_##RET(DEFAULT, NAME)
>
> --
> 2.30.2
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] LSM: Avoid warnings about potentially unused hook variables
2021-10-13 17:53 ` Paul Moore
@ 2021-10-13 21:51 ` James Morris
2021-10-14 20:10 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: James Morris @ 2021-10-13 21:51 UTC (permalink / raw)
To: Paul Moore
Cc: Kees Cook, linux-kernel, Serge E. Hallyn, Casey Schaufler,
KP Singh, linux-security-module, kernel test robot,
linux-hardening
On Wed, 13 Oct 2021, Paul Moore wrote:
> Looks reasonable to me, thanks Kees. Unless James wants to pick this
> up for the security tree, I can pull this into the SElinux tree with
> the io_uring change which is causing the testing robot to complain.
>
> Acked-by: Paul Moore <paul@paul-moore.com>
Sounds good.
Acked-by: James Morris <jamorris@linux.microsoft.com>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] LSM: Avoid warnings about potentially unused hook variables
2021-10-13 21:51 ` James Morris
@ 2021-10-14 20:10 ` Paul Moore
0 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2021-10-14 20:10 UTC (permalink / raw)
To: James Morris
Cc: Kees Cook, linux-kernel, Serge E. Hallyn, Casey Schaufler,
KP Singh, linux-security-module, kernel test robot,
linux-hardening
On Wed, Oct 13, 2021 at 6:01 PM James Morris <jmorris@namei.org> wrote:
> On Wed, 13 Oct 2021, Paul Moore wrote:
>
> > Looks reasonable to me, thanks Kees. Unless James wants to pick this
> > up for the security tree, I can pull this into the SElinux tree with
> > the io_uring change which is causing the testing robot to complain.
> >
> > Acked-by: Paul Moore <paul@paul-moore.com>
>
> Sounds good.
>
> Acked-by: James Morris <jamorris@linux.microsoft.com>
I just merged this into selinux/next, thanks everyone!
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-14 20:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 17:28 [PATCH] LSM: Avoid warnings about potentially unused hook variables Kees Cook
2021-10-13 17:53 ` Paul Moore
2021-10-13 21:51 ` James Morris
2021-10-14 20:10 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).