* [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing
@ 2020-12-02 13:59 Adam Ford
2021-01-05 3:03 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Adam Ford @ 2020-12-02 13:59 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Rob Herring, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
devicetree, linux-kernel
The WiFi chip is capable of communication at SDR104 speeds, and
the pinmux was configured to support this, but the sdhc1 controller
didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux
as was originally intended.
Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
index 6de86a4f0ec4..90fd15e95798 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
@@ -217,8 +217,10 @@
&usdhc1 {
#address-cells = <1>;
#size-cells = <0>;
- pinctrl-names = "default";
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
pinctrl-0 = <&pinctrl_usdhc1>;
+ pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+ pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
bus-width = <4>;
non-removable;
cap-power-off-card;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing
2020-12-02 13:59 [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing Adam Ford
@ 2021-01-05 3:03 ` Shawn Guo
2021-01-05 12:48 ` Adam Ford
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2021-01-05 3:03 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Rob Herring, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
devicetree, linux-kernel
On Wed, Dec 02, 2020 at 07:59:50AM -0600, Adam Ford wrote:
> The WiFi chip is capable of communication at SDR104 speeds, and
> the pinmux was configured to support this, but the sdhc1 controller
> didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux
> as was originally intended.
>
> Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
This looks more like an improvement than bug fix.
Shawn
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> index 6de86a4f0ec4..90fd15e95798 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> @@ -217,8 +217,10 @@
> &usdhc1 {
> #address-cells = <1>;
> #size-cells = <0>;
> - pinctrl-names = "default";
> + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> pinctrl-0 = <&pinctrl_usdhc1>;
> + pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> + pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> bus-width = <4>;
> non-removable;
> cap-power-off-card;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing
2021-01-05 3:03 ` Shawn Guo
@ 2021-01-05 12:48 ` Adam Ford
2021-01-05 14:06 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Adam Ford @ 2021-01-05 12:48 UTC (permalink / raw)
To: Shawn Guo
Cc: arm-soc, Adam Ford-BE, Rob Herring, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
devicetree, Linux Kernel Mailing List
On Mon, Jan 4, 2021 at 9:03 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Wed, Dec 02, 2020 at 07:59:50AM -0600, Adam Ford wrote:
> > The WiFi chip is capable of communication at SDR104 speeds, and
> > the pinmux was configured to support this, but the sdhc1 controller
> > didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux
> > as was originally intended.
> >
> > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
>
> This looks more like an improvement than bug fix.
Do you want me to resubmit without the fixes tag?
adam
>
> Shawn
>
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > index 6de86a4f0ec4..90fd15e95798 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > @@ -217,8 +217,10 @@
> > &usdhc1 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > - pinctrl-names = "default";
> > + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > pinctrl-0 = <&pinctrl_usdhc1>;
> > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> > bus-width = <4>;
> > non-removable;
> > cap-power-off-card;
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing
2021-01-05 12:48 ` Adam Ford
@ 2021-01-05 14:06 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2021-01-05 14:06 UTC (permalink / raw)
To: Adam Ford
Cc: arm-soc, Adam Ford-BE, Rob Herring, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
devicetree, Linux Kernel Mailing List
On Tue, Jan 05, 2021 at 06:48:13AM -0600, Adam Ford wrote:
> On Mon, Jan 4, 2021 at 9:03 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Wed, Dec 02, 2020 at 07:59:50AM -0600, Adam Ford wrote:
> > > The WiFi chip is capable of communication at SDR104 speeds, and
> > > the pinmux was configured to support this, but the sdhc1 controller
> > > didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux
> > > as was originally intended.
> > >
> > > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> >
> > This looks more like an improvement than bug fix.
>
> Do you want me to resubmit without the fixes tag?
Yes, please. Also, update patch subject like below maybe.
arm64: dts: imx8mm-beacon: add more pinctrl states for usdhc1
Shawn
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-05 14:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 13:59 [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing Adam Ford
2021-01-05 3:03 ` Shawn Guo
2021-01-05 12:48 ` Adam Ford
2021-01-05 14:06 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).