From: Adam Ford <aford173@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
Amit Kucheria <amitk@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Keerthy <j-keerthy@ti.com>,
linux-pm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
Carl Philipp Klemm <philipp@uvos.xyz>,
Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [PATCH 1/3] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430
Date: Fri, 8 Jan 2021 13:41:44 -0600 [thread overview]
Message-ID: <CAHCN7xJkA1yi_AM-VjmsVC-cRCF4HX7byP2K1vUHAmDuiGAH_A@mail.gmail.com> (raw)
In-Reply-To: <CAHCN7xJNk=2_Kx4XS3asxcxVGZXaTZgmCkpoFGFHdOQuM3aKCQ@mail.gmail.com>
On Fri, Jan 8, 2021 at 12:31 PM Adam Ford <aford173@gmail.com> wrote:
>
> On Fri, Jan 8, 2021 at 7:45 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > On Fri, Jan 8, 2021 at 1:22 AM Tony Lindgren <tony@atomide.com> wrote:
> > >
> > > * H. Nikolaus Schaller <hns@goldelico.com> [201230 13:29]:
> > > > > Am 30.12.2020 um 13:55 schrieb Adam Ford <aford173@gmail.com>:
> > > > > On Wed, Dec 30, 2020 at 2:43 AM Tony Lindgren <tony@atomide.com> wrote:
> > > > >>
> > > > >> At least for 4430, trying to use the single conversion mode eventually
> > > > >> hangs the thermal sensor. This can be quite easily seen with errors:
> > > > >>
> > > > >> thermal thermal_zone0: failed to read out thermal zone (-5)
> > > ...
> > >
> > > > > I don't have an OMAP4, but if you want, I can test a DM3730.
> > > >
> > > > Indeed I remember a similar discussion from the DM3730 [1]. temp values were
> > > > always those from the last measurement. E.g. the first one was done
> > > > during (cold) boot and the first request after 10 minutes did show a
> > > > quite cold system... The next one did show a hot system independent
> > > > of what had been between (suspend or high activity).
> > > >
> > > > It seems as if it was even reproducible with a very old kernel on a BeagleBoard.
> > > > So it is quite fundamental.
> > > >
> > > > We tried to fix it but did not come to a solution [2]. So we opened an issue
> > > > in our tracker [3] and decided to stay with continuous conversion although this
> > > > raises idle mode processor load.
> > >
> > > Hmm so maybe eocz high always times out in single mode since it also
> > > triggers at least on dra7?
> > >
> > > Yes it would be great if you guys can the $subject patch a try at
> > > least on your omap36xx and omap5 boards and see if you see eocz
> > > time out warnings in dmesg.
I do see chatter.
[ 15.531005] ti-soc-thermal 48002524.bandgap: eocz timed out waiting low
[ 16.571075] ti-soc-thermal 48002524.bandgap: eocz timed out waiting low
[ 17.610961] ti-soc-thermal 48002524.bandgap: eocz timed out waiting low
and it repeats quite often.
I would say this patch series would cause a regression on the DM3730.
adam
> >
> > I should be able to try it on the dm3730 logicpd-torpedo kit this weekend.
>
> I am going to be a bit delayed testing this. I cannot boot omap2plus
> using Linux version 5.11.0-rc2.
>
> [ 2.666748] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xbc
> [ 2.673309] nand: Micron MT29F4G16ABBDA3W
> [ 2.677368] nand: 512 MiB, SLC, erase size: 128 KiB, page size:
> 2048, OOB size: 64
> [ 2.685119] nand: using OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
> [ 2.693237] Invalid ECC layout
> [ 2.696350] omap2-nand 30000000.nand: unable to use BCH library
> [ 2.702575] omap2-nand: probe of 30000000.nand failed with error -22
> [ 2.716094] 8<--- cut here ---
> [ 2.719207] Unable to handle kernel NULL pointer dereference at
> virtual address 00000018
> [ 2.727600] pgd = (ptrval)
> ...
> [ 3.050933] ---[ end trace 59640c7399a80a07 ]---
> [ 3.055603] Kernel panic - not syncing: Attempted to kill init!
> exitcode=0x0000000b
> [ 3.063323] ---[ end Kernel panic - not syncing: Attempted to kill
> init! exitcode=0x0000000b ]---
>
> Once I get past this, I'll try to test the thermal stuff.
>
> adam
>
> >
> > adam
> > >
> > > Regards,
> > >
> > > Tony
next prev parent reply other threads:[~2021-01-08 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 8:43 [PATCH 1/3] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430 Tony Lindgren
2020-12-30 8:43 ` [PATCH 2/3] thermal: ti-soc-thermal: Simplify polling with iopoll Tony Lindgren
2020-12-30 8:43 ` [PATCH 3/3] thermal: ti-soc-thermal: Use non-inverted define for omap4 Tony Lindgren
2020-12-30 12:55 ` [PATCH 1/3] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430 Adam Ford
2020-12-30 13:26 ` H. Nikolaus Schaller
2021-01-08 7:22 ` Tony Lindgren
2021-01-08 13:45 ` Adam Ford
2021-01-08 18:31 ` Adam Ford
2021-01-08 19:41 ` Adam Ford [this message]
2020-12-31 12:55 ` Péter Ujfalusi
2021-01-08 7:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHCN7xJkA1yi_AM-VjmsVC-cRCF4HX7byP2K1vUHAmDuiGAH_A@mail.gmail.com \
--to=aford173@gmail.com \
--cc=amitk@kernel.org \
--cc=andreas@kemnade.info \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=hns@goldelico.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=philipp@uvos.xyz \
--cc=rui.zhang@intel.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).