From: Adam Ford <aford173@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Adam Ford-BE <aford@beaconembedded.com>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 17/18] arm64: dts: renesas: Introduce r8a774b1-beacon-rzg2n-kit
Date: Tue, 22 Dec 2020 07:58:33 -0600 [thread overview]
Message-ID: <CAHCN7xKEBUjkgksdqP2V+P9wwC9ZH=EZg7kK=txxTWp8A8=rWA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWN91xmx5bVb2ww67iHm+b8umeB3WgBQdnR5M3_WcK=7Q@mail.gmail.com>
On Thu, Dec 17, 2020 at 5:49 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Adam,
>
> On Sun, Dec 13, 2020 at 7:38 PM Adam Ford <aford173@gmail.com> wrote:
> > Beacon EmebeddedWorks is introducing a new kit based on the
> > RZ/G2N SoC from Renesas.
> >
> > The SOM supports eMMC, WiFi and Bluetooth, along with a Cat-M1
> > cellular radio.
> >
> > The Baseboard has Ethernet, USB, HDMI, stereo audio in and out,
> > along with a variety of push buttons and LED's, and support for
> > a parallel RGB and an LVDS display. It uses the same baseboard
> > and SOM as the RZ/G2M.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> Thanks for your patch!
Thank you for the review!
>
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a774b1-beacon-rzg2n-kit.dts
> > @@ -0,0 +1,43 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright 2020, Compass Electronics Group, LLC
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "r8a774b1.dtsi"
> > +#include "beacon-renesom-som.dtsi"
> > +#include "beacon-renesom-baseboard.dtsi"
> > +
> > +/ {
> > + model = "Beacon Embedded Works RZ/G2N Development Kit";
> > + compatible = "beacon,beacon-rzg2n", "renesas,r8a774b1";
> > +
> > + aliases {
> > + serial0 = &scif2;
> > + serial1 = &hscif0;
> > + serial2 = &hscif1;
> > + serial3 = &scif0;
> > + serial4 = &hscif2;
> > + serial5 = &scif5;
> > + serial6 = &scif4;
> > + ethernet0 = &avb;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
>
> No memory nodes? Are you relying on U-Boot to fill them in?
> If yes, why do you have them in the other board DTS files?
There is already a memory node included in the beacon-renesom.dtsi
file which is defining memory@48000000 node which is common to the M,
N and H. If I understand it correctly, the extra memory nodes
defined in the higher-level dts for M and H variation are not
applicable on the N.
>
> > +};
> > +
> > +&du {
> > + status = "okay";
>
> Missing pinctrl properties?
>
oops. I'll fix.
> > +
> > + clocks = <&cpg CPG_MOD 724>,
> > + <&cpg CPG_MOD 723>,
> > + <&cpg CPG_MOD 721>,
> > + <&versaclock5 1>,
> > + <&x302_clk>,
> > + <&versaclock5 2>;
> > + clock-names = "du.0", "du.1", "du.3",
> > + "dclkin.0", "dclkin.1", "dclkin.3";
> > +};
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2020-12-22 13:59 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 18:37 [PATCH 00/18] arm64: dts: renesas: Cleanup Beacon Kit and support more SoC's Adam Ford
2020-12-13 18:37 ` [PATCH 01/18] arm64: dts: renesas: beacon kit: Configure programmable clocks Adam Ford
2020-12-16 14:55 ` Geert Uytterhoeven
2020-12-16 17:03 ` Adam Ford
2020-12-17 8:16 ` Geert Uytterhoeven
2020-12-17 11:52 ` Adam Ford
2020-12-18 13:16 ` Geert Uytterhoeven
2020-12-22 1:39 ` Adam Ford
2020-12-22 8:03 ` Geert Uytterhoeven
2020-12-24 13:52 ` Adam Ford
2020-12-28 12:33 ` Geert Uytterhoeven
2020-12-28 14:38 ` Adam Ford
2020-12-28 14:52 ` Geert Uytterhoeven
2021-05-05 12:07 ` Adam Ford
2020-12-13 18:37 ` [PATCH 02/18] arm64: dts: renesas: beacon kit: Fix choppy Bluetooth Audio Adam Ford
2020-12-17 10:41 ` Geert Uytterhoeven
2020-12-17 12:16 ` Adam Ford
2020-12-18 13:00 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 03/18] arm64: dts: renesas: beacon kit: Remove unnecessary nodes Adam Ford
2020-12-17 10:43 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 04/18] arm64: dts: renesas: beacon kit: Fix Audio Clock sources Adam Ford
2020-12-17 10:54 ` Geert Uytterhoeven
2020-12-17 12:01 ` Adam Ford
2020-12-18 13:05 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 05/18] arm64: dts: renesas: beacon: Fix audio-1.8V pin enable Adam Ford
2020-12-17 10:57 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 06/18] arm64: dts: renesas: beacon: Configure Audio CODEC clocks Adam Ford
2020-12-17 11:11 ` Geert Uytterhoeven
2020-12-17 13:33 ` Adam Ford
2020-12-17 17:58 ` Adam Ford
2020-12-18 12:57 ` Geert Uytterhoeven
2020-12-18 14:23 ` Adam Ford
2020-12-13 18:37 ` [PATCH 07/18] arm64: dts: renesas: beacon: Fix LVDS PWM Backlight Adam Ford
2020-12-17 11:14 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 08/18] arm64: dts: renesas: beacon: Enable SCIF4 Adam Ford
2020-12-17 11:20 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 09/18] arm64: dts: renesas: beacon: Fix RGB Display PWM Backlight Adam Ford
2020-12-17 11:24 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 10/18] arm64: dts: renesas: Don't make vccq_sdhi0 always on Adam Ford
2020-12-17 11:24 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 11/18] arm64: dts: renesas: beacon: Remove redundant audio code Adam Ford
2020-12-13 18:37 ` [PATCH 12/18] arm64: dts: renesas: beacon: Better describe keys Adam Ford
2020-12-17 11:31 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 13/18] arm64: dts: renesas: beacon: Enable SPI Adam Ford
2020-12-17 11:34 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 14/18] arm64: dts: renesas: beacon: Correct I2C bus speeds Adam Ford
2020-12-17 11:38 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 15/18] arm64: dts: renesas: beacon-rzg2m-kit: Rearange SoC unique functions Adam Ford
2020-12-17 11:41 ` Geert Uytterhoeven
2020-12-17 11:47 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 16/18] dt-bindings: arm: renesas: Add Beacon RZ/G2N and RZ/G2H boards Adam Ford
2020-12-15 17:03 ` Rob Herring
2020-12-17 11:42 ` Geert Uytterhoeven
2020-12-13 18:37 ` [PATCH 17/18] arm64: dts: renesas: Introduce r8a774b1-beacon-rzg2n-kit Adam Ford
2020-12-17 11:49 ` Geert Uytterhoeven
2020-12-22 13:58 ` Adam Ford [this message]
2020-12-22 14:26 ` Biju Das
2020-12-13 18:37 ` [PATCH 18/18] arm64: dts: renesas: Introduce r8a774e1-beacon-rzg2h-kit Adam Ford
2020-12-17 11:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHCN7xKEBUjkgksdqP2V+P9wwC9ZH=EZg7kK=txxTWp8A8=rWA@mail.gmail.com' \
--to=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).