* [PATCH] net: wwan: iosm: select CONFIG_RELAY
@ 2021-12-04 17:40 Arnd Bergmann
2021-12-04 18:15 ` Sergey Ryazanov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-12-04 17:40 UTC (permalink / raw)
To: Loic Poulain, Sergey Ryazanov, David S. Miller, Jakub Kicinski,
M Chetan Kumar
Cc: Arnd Bergmann, Johannes Berg, Stephan Gerhold, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The iosm driver started using relayfs, but is missing the Kconfig
logic to ensure it's built into the kernel:
x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler':
iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations'
x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler':
iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full'
x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write':
iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush'
x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx':
Fixes: 00ef32565b9b ("net: wwan: iosm: device trace collection using relayfs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wwan/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig
index bdb2b0e46c12..9f5111a77da9 100644
--- a/drivers/net/wwan/Kconfig
+++ b/drivers/net/wwan/Kconfig
@@ -85,6 +85,7 @@ config IOSM
tristate "IOSM Driver for Intel M.2 WWAN Device"
depends on INTEL_IOMMU
select NET_DEVLINK
+ select RELAY
help
This driver enables Intel M.2 WWAN Device communication.
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: wwan: iosm: select CONFIG_RELAY
2021-12-04 17:40 [PATCH] net: wwan: iosm: select CONFIG_RELAY Arnd Bergmann
@ 2021-12-04 18:15 ` Sergey Ryazanov
2021-12-05 6:08 ` Kumar, M Chetan
2021-12-07 0:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Ryazanov @ 2021-12-04 18:15 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Loic Poulain, David S. Miller, Jakub Kicinski, M Chetan Kumar,
Arnd Bergmann, Johannes Berg, Stephan Gerhold, netdev, open list
On Sat, Dec 4, 2021 at 8:40 PM Arnd Bergmann <arnd@kernel.org> wrote:
> The iosm driver started using relayfs, but is missing the Kconfig
> logic to ensure it's built into the kernel:
>
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler':
> iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler':
> iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write':
> iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx':
>
> Fixes: 00ef32565b9b ("net: wwan: iosm: device trace collection using relayfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: wwan: iosm: select CONFIG_RELAY
2021-12-04 17:40 [PATCH] net: wwan: iosm: select CONFIG_RELAY Arnd Bergmann
2021-12-04 18:15 ` Sergey Ryazanov
@ 2021-12-05 6:08 ` Kumar, M Chetan
2021-12-07 0:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Kumar, M Chetan @ 2021-12-05 6:08 UTC (permalink / raw)
To: Arnd Bergmann, Loic Poulain, Sergey Ryazanov, David S. Miller,
Jakub Kicinski
Cc: Arnd Bergmann, Johannes Berg, Stephan Gerhold, netdev, linux-kernel
On 12/4/2021 11:10 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The iosm driver started using relayfs, but is missing the Kconfig
> logic to ensure it's built into the kernel:
>
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler':
> iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler':
> iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write':
> iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx':
>
> Fixes: 00ef32565b9b ("net: wwan: iosm: device trace collection using relayfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: wwan: iosm: select CONFIG_RELAY
2021-12-04 17:40 [PATCH] net: wwan: iosm: select CONFIG_RELAY Arnd Bergmann
2021-12-04 18:15 ` Sergey Ryazanov
2021-12-05 6:08 ` Kumar, M Chetan
@ 2021-12-07 0:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-07 0:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: loic.poulain, ryazanov.s.a, davem, kuba, m.chetan.kumar, arnd,
johannes, stephan, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 4 Dec 2021 18:40:25 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The iosm driver started using relayfs, but is missing the Kconfig
> logic to ensure it's built into the kernel:
>
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler':
> iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler':
> iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write':
> iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx':
>
> [...]
Here is the summary with links:
- net: wwan: iosm: select CONFIG_RELAY
https://git.kernel.org/netdev/net-next/c/5382911f5d67
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-07 0:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-04 17:40 [PATCH] net: wwan: iosm: select CONFIG_RELAY Arnd Bergmann
2021-12-04 18:15 ` Sergey Ryazanov
2021-12-05 6:08 ` Kumar, M Chetan
2021-12-07 0:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).