linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device
@ 2018-02-26 14:49 Andrey Smirnov
  2018-02-26 14:49 ` [PATCH 2/2] ARM: dts: imx51-zii-rdu1: Add node for " Andrey Smirnov
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Andrey Smirnov @ 2018-02-26 14:49 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Andrey Smirnov, Rob Herring, Mark Rutland, Fabio Estevam,
	Guenter Roeck, Chris Healy, Lucas Stach, devicetree,
	linux-arm-kernel, linux-kernel

With MFD and watchdog drivers for RAVE SP device support added by
538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and
c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add
corresponding DT node for RDU2.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 72f52fcecee1..460931089509 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -305,6 +305,17 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart4>;
 	status = "okay";
+
+	rave-sp {
+		compatible = "zii,rave-sp-rdu2";
+		current-speed = <1000000>;
+		status = "okay";
+
+		watchdog {
+			compatible = "zii,rave-sp-watchdog";
+			status = "okay";
+		};
+	};
 };
 
 &ecspi1 {
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: imx51-zii-rdu1: Add node for RAVE SP device
  2018-02-26 14:49 [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device Andrey Smirnov
@ 2018-02-26 14:49 ` Andrey Smirnov
  2018-02-27 15:32   ` Fabio Estevam
  2018-02-27 15:32 ` [PATCH 1/2] ARM: dts: imx6: RDU2: Add " Fabio Estevam
  2018-02-28  6:31 ` Shawn Guo
  2 siblings, 1 reply; 6+ messages in thread
From: Andrey Smirnov @ 2018-02-26 14:49 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Andrey Smirnov, Rob Herring, Mark Rutland, Fabio Estevam,
	Guenter Roeck, Chris Healy, Lucas Stach, devicetree,
	linux-arm-kernel, linux-kernel

With MFD and watchdog drivers for RAVE SP device support added by
538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and
c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add
corresponding DT node for RDU.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 arch/arm/boot/dts/imx51-zii-rdu1.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index 5306b78de0ca..43cd06230751 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -568,6 +568,17 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart3>;
 	status = "okay";
+
+	rave-sp {
+		compatible = "zii,rave-sp-rdu1";
+		status = "okay";
+		current-speed = <38400>;
+
+		watchdog {
+			compatible = "zii,rave-sp-watchdog";
+			status = "okay";
+		};
+	};
 };
 
 &usbh1 {
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device
  2018-02-26 14:49 [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device Andrey Smirnov
  2018-02-26 14:49 ` [PATCH 2/2] ARM: dts: imx51-zii-rdu1: Add node for " Andrey Smirnov
@ 2018-02-27 15:32 ` Fabio Estevam
  2018-02-28  6:31 ` Shawn Guo
  2 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-02-27 15:32 UTC (permalink / raw)
  To: Andrey Smirnov
  Cc: Shawn Guo, Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel, Rob Herring, Guenter Roeck, Fabio Estevam,
	Chris Healy, Lucas Stach

On Mon, Feb 26, 2018 at 11:49 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> With MFD and watchdog drivers for RAVE SP device support added by
> 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and
> c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add
> corresponding DT node for RDU2.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx51-zii-rdu1: Add node for RAVE SP device
  2018-02-26 14:49 ` [PATCH 2/2] ARM: dts: imx51-zii-rdu1: Add node for " Andrey Smirnov
@ 2018-02-27 15:32   ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-02-27 15:32 UTC (permalink / raw)
  To: Andrey Smirnov
  Cc: Shawn Guo, Rob Herring, Mark Rutland, Fabio Estevam,
	Guenter Roeck, Chris Healy, Lucas Stach,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	linux-kernel

On Mon, Feb 26, 2018 at 11:49 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> With MFD and watchdog drivers for RAVE SP device support added by
> 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and
> c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add
> corresponding DT node for RDU.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device
  2018-02-26 14:49 [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device Andrey Smirnov
  2018-02-26 14:49 ` [PATCH 2/2] ARM: dts: imx51-zii-rdu1: Add node for " Andrey Smirnov
  2018-02-27 15:32 ` [PATCH 1/2] ARM: dts: imx6: RDU2: Add " Fabio Estevam
@ 2018-02-28  6:31 ` Shawn Guo
  2018-03-01 16:19   ` Andrey Smirnov
  2 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2018-02-28  6:31 UTC (permalink / raw)
  To: Andrey Smirnov
  Cc: Rob Herring, Mark Rutland, Fabio Estevam, Guenter Roeck,
	Chris Healy, Lucas Stach, devicetree, linux-arm-kernel,
	linux-kernel

On Mon, Feb 26, 2018 at 06:49:41AM -0800, Andrey Smirnov wrote:
> With MFD and watchdog drivers for RAVE SP device support added by
> 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and
> c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add
> corresponding DT node for RDU2.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 72f52fcecee1..460931089509 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -305,6 +305,17 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart4>;
>  	status = "okay";
> +
> +	rave-sp {
> +		compatible = "zii,rave-sp-rdu2";
> +		current-speed = <1000000>;
> +		status = "okay";

The okay status is to flip the state of devices that are initially
disabled.  I think it's unnecessary for the case here.

> +
> +		watchdog {
> +			compatible = "zii,rave-sp-watchdog";
> +			status = "okay";

Ditto

Shawn

> +		};
> +	};
>  };
>  
>  &ecspi1 {
> -- 
> 2.14.3
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device
  2018-02-28  6:31 ` Shawn Guo
@ 2018-03-01 16:19   ` Andrey Smirnov
  0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2018-03-01 16:19 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Mark Rutland, Fabio Estevam, Guenter Roeck,
	Chris Healy, Lucas Stach,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-arm-kernel, linux-kernel

On Tue, Feb 27, 2018 at 10:31 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Mon, Feb 26, 2018 at 06:49:41AM -0800, Andrey Smirnov wrote:
>> With MFD and watchdog drivers for RAVE SP device support added by
>> 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor") and
>> c3bb33345721 ("watchdog: Add RAVE SP watchdog driver") add
>> corresponding DT node for RDU2.
>>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Chris Healy <cphealy@gmail.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> index 72f52fcecee1..460931089509 100644
>> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> @@ -305,6 +305,17 @@
>>       pinctrl-names = "default";
>>       pinctrl-0 = <&pinctrl_uart4>;
>>       status = "okay";
>> +
>> +     rave-sp {
>> +             compatible = "zii,rave-sp-rdu2";
>> +             current-speed = <1000000>;
>> +             status = "okay";
>
> The okay status is to flip the state of devices that are initially
> disabled.  I think it's unnecessary for the case here.

Good point, will respin v2 without that bit shortly.

Thanks,
Andrey Smirnov

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-03-01 16:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 14:49 [PATCH 1/2] ARM: dts: imx6: RDU2: Add RAVE SP device Andrey Smirnov
2018-02-26 14:49 ` [PATCH 2/2] ARM: dts: imx51-zii-rdu1: Add node for " Andrey Smirnov
2018-02-27 15:32   ` Fabio Estevam
2018-02-27 15:32 ` [PATCH 1/2] ARM: dts: imx6: RDU2: Add " Fabio Estevam
2018-02-28  6:31 ` Shawn Guo
2018-03-01 16:19   ` Andrey Smirnov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).