[PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable

[PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable

[Daeseok Youn]

The bd variable in dgnc_tty_digiseta() is assigned with
ch->ch_bd but it is not used in this function except checking NULL.
The ch->ch_bd could be replaced with bd variable in dgnc_tty_digiseta()

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
 drivers/staging/dgnc/dgnc_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 7133d2c..b075350 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -2081,7 +2081,7 @@ static int dgnc_tty_digiseta(struct tty_struct *tty,
 	if (ch->ch_digi.digi_offlen > DIGI_PLEN)
 		ch->ch_digi.digi_offlen = DIGI_PLEN;
 
-	ch->ch_bd->bd_ops->param(tty);
+	bd->bd_ops->param(tty);
 
 	spin_unlock_irqrestore(&ch->ch_lock, flags);
 
-- 
2.7.4

Re: [PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable

[Greg KH]

On Sun, Mar 12, 2017 at 11:47:28PM +0900, Daeseok Youn wrote:
> The bd variable in dgnc_tty_digiseta() is assigned with
> ch->ch_bd but it is not used in this function except checking NULL.
> The ch->ch_bd could be replaced with bd variable in dgnc_tty_digiseta()
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please merge this with your first patch in the series and resend them.

thanks,

greg k-h

Re: [PATCH 3/3] staging: dngc: ch->ch_bd is already assigned to bd variable

[DaeSeok Youn]

2017-03-14 7:26 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> On Sun, Mar 12, 2017 at 11:47:28PM +0900, Daeseok Youn wrote:
>> The bd variable in dgnc_tty_digiseta() is assigned with
>> ch->ch_bd but it is not used in this function except checking NULL.
>> The ch->ch_bd could be replaced with bd variable in dgnc_tty_digiseta()
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>> ---
>>  drivers/staging/dgnc/dgnc_tty.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Please merge this with your first patch in the series and resend them.
Hi Greg,

Ok. I will merge this with my first patch and send them.

Thanks,
Regards,
Daeseok Youn.

>
> thanks,
>
> greg k-h