From: Yang Shi <shy828301@gmail.com>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>,
"Hugh Dickins" <hughd@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Peter Xu" <peterx@redhat.com>,
"Oscar Salvador" <osalvador@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>
Cc: Linux MM <linux-mm@kvack.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [v3 PATCH 1/5] mm: hwpoison: remove the unnecessary THP check
Date: Tue, 5 Oct 2021 19:35:35 -0700 [thread overview]
Message-ID: <CAHbLzkpyxnvm3w0M_CEU7cYRCYr0coNCoiY1DvtnBzqb1R1nsw@mail.gmail.com> (raw)
In-Reply-To: <20210930215311.240774-2-shy828301@gmail.com>
Hi Naoya,
Any comment on this patch and patch #3? I'd prefer to fix more
comments for a new version.
Thanks,
Yang
On Thu, Sep 30, 2021 at 2:53 PM Yang Shi <shy828301@gmail.com> wrote:
>
> When handling THP hwpoison checked if the THP is in allocation or free
> stage since hwpoison may mistreat it as hugetlb page. After
> commit 415c64c1453a ("mm/memory-failure: split thp earlier in memory error
> handling") the problem has been fixed, so this check is no longer
> needed. Remove it. The side effect of the removal is hwpoison may
> report unsplit THP instead of unknown error for shmem THP. It seems not
> like a big deal.
>
> The following patch depends on this, which fixes shmem THP with
> hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be
> backported to -stable as well.
>
> Cc: <stable@vger.kernel.org>
> Suggested-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> Signed-off-by: Yang Shi <shy828301@gmail.com>
> ---
> mm/memory-failure.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 54879c339024..ed28eba50f98 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1147,20 +1147,6 @@ static int __get_hwpoison_page(struct page *page)
> if (!HWPoisonHandlable(head))
> return -EBUSY;
>
> - if (PageTransHuge(head)) {
> - /*
> - * Non anonymous thp exists only in allocation/free time. We
> - * can't handle such a case correctly, so let's give it up.
> - * This should be better than triggering BUG_ON when kernel
> - * tries to touch the "partially handled" page.
> - */
> - if (!PageAnon(head)) {
> - pr_err("Memory failure: %#lx: non anonymous thp\n",
> - page_to_pfn(page));
> - return 0;
> - }
> - }
> -
> if (get_page_unless_zero(head)) {
> if (head == compound_head(page))
> return 1;
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-10-06 2:35 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 21:53 [RFC v3 PATCH 0/5] Solve silent data loss caused by poisoned page cache (shmem/tmpfs) Yang Shi
2021-09-30 21:53 ` [v3 PATCH 1/5] mm: hwpoison: remove the unnecessary THP check Yang Shi
2021-10-06 2:35 ` Yang Shi [this message]
2021-10-06 4:00 ` Naoya Horiguchi
2021-10-06 17:56 ` Yang Shi
2021-09-30 21:53 ` [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault Yang Shi
2021-10-01 7:23 ` Naoya Horiguchi
2021-10-01 21:07 ` Yang Shi
2021-10-04 14:06 ` Kirill A. Shutemov
2021-10-04 18:17 ` Yang Shi
2021-10-04 19:41 ` Kirill A. Shutemov
2021-10-04 20:13 ` Yang Shi
2021-10-06 19:54 ` Peter Xu
2021-10-06 23:41 ` Yang Shi
2021-10-07 16:14 ` Peter Xu
2021-10-07 18:28 ` Yang Shi
2021-10-08 9:35 ` Kirill A. Shutemov
2021-10-11 22:57 ` Peter Xu
2021-10-06 20:15 ` Peter Xu
2021-10-06 23:57 ` Yang Shi
2021-10-07 16:06 ` Peter Xu
2021-10-07 18:19 ` Yang Shi
2021-10-07 20:27 ` Yang Shi
2021-10-07 21:28 ` Yang Shi
2021-10-12 0:55 ` Peter Xu
2021-10-12 1:44 ` Peter Xu
2021-10-12 18:02 ` Yang Shi
2021-10-12 22:10 ` Peter Xu
2021-10-13 2:48 ` Yang Shi
2021-10-13 3:01 ` Peter Xu
2021-10-13 3:27 ` Yang Shi
2021-10-13 3:41 ` Peter Xu
2021-10-13 21:42 ` Yang Shi
2021-10-13 23:13 ` Peter Xu
2021-10-14 6:54 ` Naoya Horiguchi
2021-10-06 20:18 ` Peter Xu
2021-10-07 2:49 ` Yang Shi
2021-11-01 19:05 ` Naresh Kamboju
2021-11-01 19:26 ` Yang Shi
2021-09-30 21:53 ` [v3 PATCH 3/5] mm: hwpoison: refactor refcount check handling Yang Shi
2021-10-06 22:01 ` Peter Xu
2021-10-07 2:47 ` Yang Shi
2021-10-07 16:18 ` Peter Xu
2021-09-30 21:53 ` [v3 PATCH 4/5] mm: shmem: don't truncate page if memory failure happens Yang Shi
2021-10-01 7:05 ` Naoya Horiguchi
2021-10-01 21:08 ` Yang Shi
2021-10-12 1:57 ` Peter Xu
2021-10-12 19:17 ` Yang Shi
2021-10-12 22:26 ` Peter Xu
2021-10-13 3:00 ` Yang Shi
2021-10-13 3:06 ` Peter Xu
2021-10-13 3:29 ` Yang Shi
2021-09-30 21:53 ` [v3 PATCH 5/5] mm: hwpoison: handle non-anonymous THP correctly Yang Shi
2021-10-01 7:06 ` Naoya Horiguchi
2021-10-01 21:09 ` Yang Shi
2021-10-13 2:40 ` [RFC v3 PATCH 0/5] Solve silent data loss caused by poisoned page cache (shmem/tmpfs) Peter Xu
2021-10-13 3:09 ` Yang Shi
2021-10-13 3:24 ` Peter Xu
2021-10-14 6:54 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHbLzkpyxnvm3w0M_CEU7cYRCYr0coNCoiY1DvtnBzqb1R1nsw@mail.gmail.com \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).