From: Yang Shi <shy828301@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>,
"Hugh Dickins" <hughd@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Peter Xu" <peterx@redhat.com>,
"Oscar Salvador" <osalvador@suse.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Linux MM" <linux-mm@kvack.org>,
"Linux FS-devel Mailing List" <linux-fsdevel@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault
Date: Mon, 4 Oct 2021 13:13:07 -0700 [thread overview]
Message-ID: <CAHbLzkqcrGCksMXbW5p75ZK2ODv4bLcdQWs7Jz0NG4-=5N20zw@mail.gmail.com> (raw)
In-Reply-To: <20211004194130.6hdzanjl2e2np4we@box.shutemov.name>
On Mon, Oct 4, 2021 at 12:41 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Mon, Oct 04, 2021 at 11:17:29AM -0700, Yang Shi wrote:
> > On Mon, Oct 4, 2021 at 7:06 AM Kirill A. Shutemov <kirill@shutemov.name> wrote:
> > >
> > > On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote:
> > > > diff --git a/mm/filemap.c b/mm/filemap.c
> > > > index dae481293b5d..2acc2b977f66 100644
> > > > --- a/mm/filemap.c
> > > > +++ b/mm/filemap.c
> > > > @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page)
> > > > }
> > > >
> > > > if (pmd_none(*vmf->pmd) && PageTransHuge(page)) {
> > > > - vm_fault_t ret = do_set_pmd(vmf, page);
> > > > - if (!ret) {
> > > > - /* The page is mapped successfully, reference consumed. */
> > > > - unlock_page(page);
> > > > - return true;
> > > > - }
> > > > + vm_fault_t ret = do_set_pmd(vmf, page);
> > > > + if (!ret) {
> > > > + /* The page is mapped successfully, reference consumed. */
> > > > + unlock_page(page);
> > > > + return true;
> > > > + }
> > > > }
> > > >
> > > > if (pmd_none(*vmf->pmd)) {
> > >
> > > Hm. Is it unrelated whitespace fix?
> >
> > It is a coding style clean up. I thought it may be overkilling to have
> > a separate patch. Do you prefer separate one?
>
> Maybe. I tried to find what changed here. It's confusing.
Yeah, maybe. Anyway I will separate the real big fix and the cleanup
into two patches. This may be helpful for backporting too.
>
> --
> Kirill A. Shutemov
next prev parent reply other threads:[~2021-10-04 20:13 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 21:53 [RFC v3 PATCH 0/5] Solve silent data loss caused by poisoned page cache (shmem/tmpfs) Yang Shi
2021-09-30 21:53 ` [v3 PATCH 1/5] mm: hwpoison: remove the unnecessary THP check Yang Shi
2021-10-06 2:35 ` Yang Shi
2021-10-06 4:00 ` Naoya Horiguchi
2021-10-06 17:56 ` Yang Shi
2021-09-30 21:53 ` [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault Yang Shi
2021-10-01 7:23 ` Naoya Horiguchi
2021-10-01 21:07 ` Yang Shi
2021-10-04 14:06 ` Kirill A. Shutemov
2021-10-04 18:17 ` Yang Shi
2021-10-04 19:41 ` Kirill A. Shutemov
2021-10-04 20:13 ` Yang Shi [this message]
2021-10-06 19:54 ` Peter Xu
2021-10-06 23:41 ` Yang Shi
2021-10-07 16:14 ` Peter Xu
2021-10-07 18:28 ` Yang Shi
2021-10-08 9:35 ` Kirill A. Shutemov
2021-10-11 22:57 ` Peter Xu
2021-10-06 20:15 ` Peter Xu
2021-10-06 23:57 ` Yang Shi
2021-10-07 16:06 ` Peter Xu
2021-10-07 18:19 ` Yang Shi
2021-10-07 20:27 ` Yang Shi
2021-10-07 21:28 ` Yang Shi
2021-10-12 0:55 ` Peter Xu
2021-10-12 1:44 ` Peter Xu
2021-10-12 18:02 ` Yang Shi
2021-10-12 22:10 ` Peter Xu
2021-10-13 2:48 ` Yang Shi
2021-10-13 3:01 ` Peter Xu
2021-10-13 3:27 ` Yang Shi
2021-10-13 3:41 ` Peter Xu
2021-10-13 21:42 ` Yang Shi
2021-10-13 23:13 ` Peter Xu
2021-10-14 6:54 ` Naoya Horiguchi
2021-10-06 20:18 ` Peter Xu
2021-10-07 2:49 ` Yang Shi
2021-11-01 19:05 ` Naresh Kamboju
2021-11-01 19:26 ` Yang Shi
2021-09-30 21:53 ` [v3 PATCH 3/5] mm: hwpoison: refactor refcount check handling Yang Shi
2021-10-06 22:01 ` Peter Xu
2021-10-07 2:47 ` Yang Shi
2021-10-07 16:18 ` Peter Xu
2021-09-30 21:53 ` [v3 PATCH 4/5] mm: shmem: don't truncate page if memory failure happens Yang Shi
2021-10-01 7:05 ` Naoya Horiguchi
2021-10-01 21:08 ` Yang Shi
2021-10-12 1:57 ` Peter Xu
2021-10-12 19:17 ` Yang Shi
2021-10-12 22:26 ` Peter Xu
2021-10-13 3:00 ` Yang Shi
2021-10-13 3:06 ` Peter Xu
2021-10-13 3:29 ` Yang Shi
2021-09-30 21:53 ` [v3 PATCH 5/5] mm: hwpoison: handle non-anonymous THP correctly Yang Shi
2021-10-01 7:06 ` Naoya Horiguchi
2021-10-01 21:09 ` Yang Shi
2021-10-13 2:40 ` [RFC v3 PATCH 0/5] Solve silent data loss caused by poisoned page cache (shmem/tmpfs) Peter Xu
2021-10-13 3:09 ` Yang Shi
2021-10-13 3:24 ` Peter Xu
2021-10-14 6:54 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHbLzkqcrGCksMXbW5p75ZK2ODv4bLcdQWs7Jz0NG4-=5N20zw@mail.gmail.com' \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).