From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dan Carpenter <error27@gmail.com>, Eric Biggers <ebiggers@kernel.org>
Cc: linux-block@vger.kernel.org, Julia Lawall <julia.lawall@inria.fr>,
Luis Chamberlain <mcgrof@kernel.org>,
Hongchen Zhang <zhanghongchen@loongson.cn>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
"Christian Brauner (Microsoft)" <brauner@kernel.org>,
David Howells <dhowells@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
maobibo <maobibo@loongson.cn>,
Matthew Wilcox <willy@infradead.org>,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: block: sleeping in atomic warnings
Date: Tue, 7 Feb 2023 08:15:04 -0800 [thread overview]
Message-ID: <CAHk-=wg6ohuyrmLJYTfEpDbp2Jwnef54gkcpZ3-BYgy4C6UxRQ@mail.gmail.com> (raw)
In-Reply-To: <Y+Ja5SRs886CEz7a@kadam>
On Tue, Feb 7, 2023 at 6:06 AM Dan Carpenter <error27@gmail.com> wrote:
>
> block/blk-crypto-profile.c:382 __blk_crypto_evict_key() warn: sleeping in atomic context
> block/blk-crypto-profile.c:390 __blk_crypto_evict_key() warn: sleeping in atomic context
Yeah, that looks very real, but doesn't really seem to be a block bug.
__put_super() has a big comment that it's called under the sb_lock
spinlock, so it's all in atomic context, but then:
> -> __put_super()
> -> fscrypt_destroy_keyring()
> -> fscrypt_put_master_key_activeref()
> -> fscrypt_destroy_prepared_key()
> -> fscrypt_destroy_inline_crypt_key()
> -> blk_crypto_evict_key()
and we have a comment in __blk_crypto_evict_key() that it must be
called in "process context".
However, the *normal* unmount sequence does all the cleanup *before*
it gets sb_lock, and calls fscrypt_destroy_keyring() in process
context, which is probably why it never triggers in practice, because
the "last put" is normally there, not in __put_super.
Eric? Al?
It smells like __put_super() may need to do some parts delayed, not
under sb_lock.
Linus
next prev parent reply other threads:[~2023-02-07 16:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 6:04 [PATCH v4] pipe: use __pipe_{lock,unlock} instead of spinlock Hongchen Zhang
2023-01-29 7:33 ` Linus Torvalds
2023-02-03 2:24 ` Hongchen Zhang
2023-02-06 15:58 ` Luis Chamberlain
2023-02-06 16:07 ` Linus Torvalds
2023-02-06 16:13 ` Julia Lawall
2023-02-06 16:45 ` Dan Carpenter
2023-02-06 17:54 ` Luis Chamberlain
2023-02-07 7:02 ` Dan Carpenter
2023-02-06 18:25 ` Linus Torvalds
2023-02-07 13:37 ` xen: sleeping in atomic warnings Dan Carpenter
2023-02-07 14:03 ` Juergen Gross
2023-02-07 14:06 ` block: " Dan Carpenter
2023-02-07 16:15 ` Linus Torvalds [this message]
2023-02-07 17:53 ` Eric Biggers
2023-02-07 18:24 ` Linus Torvalds
2023-02-07 18:36 ` Eric Biggers
2023-02-07 18:57 ` Linus Torvalds
2023-02-07 19:09 ` Linus Torvalds
2023-02-07 19:35 ` Eric Biggers
2023-02-07 19:49 ` Linus Torvalds
2023-02-08 6:53 ` Eric Biggers
2023-02-07 18:31 ` Jens Axboe
2023-02-08 3:15 ` Yu Kuai
2023-02-03 1:42 ` [PATCH v4] pipe: use __pipe_{lock,unlock} instead of spinlock Hongchen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wg6ohuyrmLJYTfEpDbp2Jwnef54gkcpZ3-BYgy4C6UxRQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maobibo@loongson.cn \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zhanghongchen@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).