linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] kbuild: make multiple directory targets work properly
@ 2020-02-05  6:51 Masahiro Yamada
  2020-02-05  6:55 ` Linus Torvalds
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2020-02-05  6:51 UTC (permalink / raw)
  To: linux-kbuild, Linus Torvalds; +Cc: linux-kernel, Masahiro Yamada, Michal Marek

Currently, the single-target build does not work when two
or more sub-directories are given:

  $ make fs/ kernel/ lib/
    CALL    scripts/checksyscalls.sh
    CALL    scripts/atomic/check-atomics.sh
    DESCEND  objtool
  make[2]: Nothing to be done for 'kernel/'.
  make[2]: Nothing to be done for 'fs/'.
  make[2]: Nothing to be done for 'lib/'.

Make it work properly.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

Linus,

If you want to use this patch soon (seems useful since
you are travelling), please feel free to apply it directly.

If you wait for my next pull request, I will apply it to
my tree.

Either is fine with me.



 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 65a5dc653deb..ef8913a8eb2a 100644
--- a/Makefile
+++ b/Makefile
@@ -1679,7 +1679,7 @@ PHONY += descend $(build-dirs)
 descend: $(build-dirs)
 $(build-dirs): prepare
 	$(Q)$(MAKE) $(build)=$@ \
-	single-build=$(if $(filter-out $@/, $(single-no-ko)),1) \
+	single-build=$(if $(filter-out $@/, $(filter $@/%, $(single-no-ko))),1) \
 	need-builtin=1 need-modorder=1
 
 clean-dirs := $(addprefix _clean_, $(clean-dirs))
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kbuild: make multiple directory targets work properly
  2020-02-05  6:51 [PATCH] kbuild: make multiple directory targets work properly Masahiro Yamada
@ 2020-02-05  6:55 ` Linus Torvalds
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2020-02-05  6:55 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Linux Kbuild mailing list, Linux Kernel Mailing List, Michal Marek

On Wed, Feb 5, 2020 at 6:52 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> If you want to use this patch soon (seems useful since
> you are travelling), please feel free to apply it directly.
>
> If you wait for my next pull request, I will apply it to
> my tree.

I'll wait for the proper channels, I'm heading back home tomorrow
anyway, and it's not been a big problem for me.

Just an oddity I happened to hit because of doing slightly different
things while on the road.

Thanks,
                Linus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-05  6:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05  6:51 [PATCH] kbuild: make multiple directory targets work properly Masahiro Yamada
2020-02-05  6:55 ` Linus Torvalds

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).