From: Linus Torvalds <torvalds@linux-foundation.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Linux List Kernel Mailing" <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Andy Lutomirski" <luto@kernel.org>,
"Borislav Petkov" <bp@alien8.de>
Subject: Re: [PATCH] x86, retpolines: raise limit for generating indirect calls from switch-case
Date: Thu, 21 Feb 2019 14:27:49 -0800 [thread overview]
Message-ID: <CAHk-=wgNfnC-oe7aJGgNWoTbssc0LPYK6FyR=6LO4_U_dsphbg@mail.gmail.com> (raw)
In-Reply-To: <20190221221941.29358-1-daniel@iogearbox.net>
On Thu, Feb 21, 2019 at 2:20 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> In case of gcc, this setting is controlled by case-values-threshold
> which has an architecture global default that selects 4 or 5 (
Ack. For retpoline, that's much too low.
Patch looks sane, although it would be good to verify just which
versions of gcc this works for. All versions with retpoline?
Linus
next prev parent reply other threads:[~2019-02-21 22:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 22:19 [PATCH] x86, retpolines: raise limit for generating indirect calls from switch-case Daniel Borkmann
2019-02-21 22:27 ` Linus Torvalds [this message]
2019-02-21 22:56 ` Daniel Borkmann
2019-02-22 7:31 ` Jesper Dangaard Brouer
2019-02-26 18:20 ` Björn Töpel
2019-02-28 11:12 ` [tip:x86/build] x86, retpolines: Raise " tip-bot for Daniel Borkmann
2019-02-28 11:27 ` David Woodhouse
2019-02-28 12:53 ` H.J. Lu
2019-02-28 16:18 ` Daniel Borkmann
2019-02-28 16:25 ` H.J. Lu
2019-02-28 17:58 ` Daniel Borkmann
2019-02-28 18:09 ` H.J. Lu
2019-02-28 18:13 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgNfnC-oe7aJGgNWoTbssc0LPYK6FyR=6LO4_U_dsphbg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bp@alien8.de \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).