From: Linus Torvalds <torvalds@linux-foundation.org>
To: Lee Jones <lee@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Backlight for v6.1
Date: Wed, 5 Oct 2022 10:59:35 -0700 [thread overview]
Message-ID: <CAHk-=whK-q1W-X0q0f_nBJ9sKyta-DVJhEAS4BF_oKAVAUQ4Jw@mail.gmail.com> (raw)
In-Reply-To: <Yz18QA27+gN0oaM3@google.com>
On Wed, Oct 5, 2022 at 5:44 AM Lee Jones <lee@kernel.org> wrote:
>
> - Add support for MediaTek MT6370 Backlight
Hmm. This new driver has a
depends on MFD_MT6370
but there is no such symbol anywhere.
It turns out the same is true of the MT6370 regulator driver that was
added during the previous merge window.
I do see that MFD_MT6370 in linux-next, but I don't see any pull
request for this, and now that I started looking I do see that we had
this already in 6.0.
I do *not* believe that it's ok to randomly take "drivers" that depend
on functionality that hasn't even been merged yet, and that are
basically just dead code but hidden away this non-obvious way.
I've pulled this, but I want to just state that this is bad, bad, bad.
If it has dependencies that aren't met, it damn well shouldn't be sent
upstream in a form where upstream can't even build test the thing.
Linus
next prev parent reply other threads:[~2022-10-05 18:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 12:44 [GIT PULL] Backlight for v6.1 Lee Jones
2022-10-05 17:59 ` Linus Torvalds [this message]
2022-10-07 13:16 ` Lee Jones
2022-10-07 18:45 ` Linus Torvalds
2022-10-08 18:30 ` Andy Shevchenko
2022-10-08 19:02 ` Linus Torvalds
2022-10-08 19:59 ` Hans de Goede
2022-10-08 23:23 ` Linus Torvalds
2022-10-09 12:58 ` Hans de Goede
2022-10-20 3:31 ` Randy Dunlap
2022-10-20 13:48 ` Andy Shevchenko
2022-10-20 13:53 ` Hans de Goede
2022-10-10 7:42 ` Lee Jones
2022-10-05 18:40 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whK-q1W-X0q0f_nBJ9sKyta-DVJhEAS4BF_oKAVAUQ4Jw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).