linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>, Lee Jones <lee@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Backlight for v6.1
Date: Sat, 8 Oct 2022 12:02:25 -0700	[thread overview]
Message-ID: <CAHk-=wixtjmiENLbc1=Hds3mMSjVRA3ZiwXN7yg8mw_1MCg_QQ@mail.gmail.com> (raw)
In-Reply-To: <Y0HB3K8IRVhX5IvT@smile.fi.intel.com>

On Sat, Oct 8, 2022 at 11:31 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The Intel PMICs are the beasts when we want to run the code on the real
> hardware.

Yeah, I don't expect he driver to work on real hardware, but I'm
mostly worried about the fact that it also gets very little build
coverage.

The fact that I found the i2c semantic conflict mainly because I was
looking for it (it's cropped up multiple times this merge window) but
*without* seeing it as a build error, that's what worries me.

So I think the

    depends on I2C_DESIGNWARE_PLATFORM=y

might be better with a "|| COMPILE_TEST" to at least find the build
issues, even if actual runtime testing is a different anumal entirely.

               Linus

  reply	other threads:[~2022-10-08 19:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 12:44 [GIT PULL] Backlight for v6.1 Lee Jones
2022-10-05 17:59 ` Linus Torvalds
2022-10-07 13:16   ` Lee Jones
2022-10-07 18:45     ` Linus Torvalds
2022-10-08 18:30       ` Andy Shevchenko
2022-10-08 19:02         ` Linus Torvalds [this message]
2022-10-08 19:59           ` Hans de Goede
2022-10-08 23:23             ` Linus Torvalds
2022-10-09 12:58               ` Hans de Goede
2022-10-20  3:31                 ` Randy Dunlap
2022-10-20 13:48                   ` Andy Shevchenko
2022-10-20 13:53                     ` Hans de Goede
2022-10-10  7:42       ` Lee Jones
2022-10-05 18:40 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wixtjmiENLbc1=Hds3mMSjVRA3ZiwXN7yg8mw_1MCg_QQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).