linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Paul Burton <paul.burton@mips.com>,
	David Howells <dhowells@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [GIT PULL] MIPS changes
Date: Mon, 23 Sep 2019 11:18:19 -0700	[thread overview]
Message-ID: <CAHk-=wiC_B8R6th+83vKwGT1H-8vtFrmMg+1mK_P8n3VeWAWRg@mail.gmail.com> (raw)
In-Reply-To: <20190923180728.flp6jx4jc2bh7cys@pburton-laptop>

On Mon, Sep 23, 2019 at 11:07 AM Paul Burton <paul.burton@mips.com> wrote:
>
> Another issue is that there are currently 'expected' warnings dotted
> through the tree for various defconfigs

This is why I refuse to have _any_ warnings at all in my tree during
the merge window.

If you have expected warnings, you will ignore the new and valid ones.
So the only acceptable situation is "no warnings".

In honesty, I actually do have one warning in my tree:

  samples/vfs/test-statx.c:24:15: warning: ‘struct foo’ declared
inside parameter list will not be visible outside of this definition
or declaration
     24 | #define statx foo
        |               ^~~

but because it's in the sample code, it pretty much never gets rebuilt
for me unless I basically do a "git clean" to get rid of everything,
so I don't normally see it for any normal pull.

So I've ignored that one warning, although I've actually been tempted
to just remove the sample because of it.

Adding David and Al to the cc just in case they have some simple fixup
for it that is likely to work across different user headers.

I considered just adding a

     struct foo;

declaration, but the whole thing is incredibly ugly.

                  Linus

  reply	other threads:[~2019-09-23 18:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-21 23:10 [GIT PULL] MIPS changes Paul Burton
2019-09-22 16:45 ` pr-tracker-bot
2019-09-22 18:35 ` Linus Torvalds
2019-09-23 15:36   ` Florian Fainelli
2019-09-23 18:07   ` Paul Burton
2019-09-23 18:18     ` Linus Torvalds [this message]
2019-09-24 12:40     ` David Howells
2019-09-24 15:32       ` Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2020-01-31 17:55 Paul Burton
2020-01-31 19:35 ` pr-tracker-bot
2019-07-17 15:25 Paul Burton
2019-07-17 16:41 ` Linus Torvalds
2019-07-17 16:50 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wiC_B8R6th+83vKwGT1H-8vtFrmMg+1mK_P8n3VeWAWRg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).