From: Florian Fainelli <f.fainelli@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Paul Burton <paul.burton@mips.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [GIT PULL] MIPS changes
Date: Mon, 23 Sep 2019 08:36:54 -0700 [thread overview]
Message-ID: <ac8e3a45-5efe-0e60-3ee0-1a5dbcfa8fc2@gmail.com> (raw)
In-Reply-To: <CAHk-=wjmJbF3p9vZTW2nbeD4LkG-JZV+uqv8BnxzojJ5SZsLjw@mail.gmail.com>
On 9/22/2019 11:35 AM, Linus Torvalds wrote:
> On Sat, Sep 21, 2019 at 4:10 PM Paul Burton <paul.burton@mips.com> wrote:
>>
>> Here are the main MIPS changes for v5.4; please pull.
>
> Hmm. I pulled and because initial tests didn't show any issues, I
> already pushed out.
>
> But some unrelated further testing then shows that this:
>
>> Florian Fainelli (2):
>> firmware: bcm47xx_nvram: Correct size_t printf format
>> firmware: bcm47xx_nvram: Allow COMPILE_TEST
>
> causes problems, and commit feb4eb060c3a ("firmware: bcm47xx_nvram:
> Correct size_t printf format") is buggy:
>
> drivers/firmware/broadcom/bcm47xx_nvram.c: In function ‘nvram_init’:
> drivers/firmware/broadcom/bcm47xx_nvram.c:151: warning: format ‘%zu’
> expects argument of type ‘size_t’, but argument 2 has type ‘u32’ {aka
> ‘unsigned int’} [-Wformat=]
>
> and the change to use %zu was completely wrong.
>
> It prints out 'header.len', which is an u32, not nvram_len which is a size_t.
>
> Tssk tssk.
>
> I've fixed it in my tree, but this should have shown up in linux-next,
> or in MIPS testing. The process clearly failed.
Thanks for fixing that. The process worked, there was an email sent by
the kbuild robot but I saw it only now somehow and failed to address it
in time before Paul sent out the pull request.
--
Florian
next prev parent reply other threads:[~2019-09-23 15:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 23:10 [GIT PULL] MIPS changes Paul Burton
2019-09-22 16:45 ` pr-tracker-bot
2019-09-22 18:35 ` Linus Torvalds
2019-09-23 15:36 ` Florian Fainelli [this message]
2019-09-23 18:07 ` Paul Burton
2019-09-23 18:18 ` Linus Torvalds
2019-09-24 12:40 ` David Howells
2019-09-24 15:32 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2020-01-31 17:55 Paul Burton
2020-01-31 19:35 ` pr-tracker-bot
2019-07-17 15:25 Paul Burton
2019-07-17 16:41 ` Linus Torvalds
2019-07-17 16:50 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8e3a45-5efe-0e60-3ee0-1a5dbcfa8fc2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).