From: Linus Torvalds <torvalds@linux-foundation.org>
To: Guenter Roeck <linux@roeck-us.net>,
Thierry Reding <treding@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Vidya Sagar <vidyas@nvidia.com>,
Edmond Chung <edmondchung@google.com>,
Andrew Chant <achant@google.com>,
Will McVicker <willmcvicker@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: Linux 5.17-rc8
Date: Mon, 14 Mar 2022 13:13:59 -0700 [thread overview]
Message-ID: <CAHk-=wiEhs+4P1TNh2sNnk04D1FFdNThk6XLOMxzkRL72PEXFw@mail.gmail.com> (raw)
In-Reply-To: <20220314192522.GA3031157@roeck-us.net>
[ Adding more people to the cc, since this last change was triggered
by earlier changes.
On Mon, Mar 14, 2022 at 12:25 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Build results:
> total: 155 pass: 155 fail: 0
> Qemu test results:
> total: 488 pass: 484 fail: 4
Uhhuh. We got all the previous problems sorted out, but a new one instead.
> This is a new problem. It bisects to commit fc328a7d1fcc ("gpio: Revert
> regression in sysfs-gpio (gpiolib.c)"). The network connection fails
> in the affected tests. Reverting the offending commit (ie reverting the
> revert) fixes the problem.
Hmm. Looking at the changes since 5.16, that commit fc328a7d1fcc looks
somewhat suspicious.
It claims to "revert" things, but the behavior it reverts goes
basically all the way back to v5.7 (with one of the patches going into
5.10).
And it clearly breaks things that used to work much more recently (ie
this worked in rc7, but it was also the state in every release since
5.10).
So unless somebody can find the _real_ issue here, I suspect very
strongly that that "fix" that came in last week was just wrong.
It is also very non-specific "Some GPIO lines have stopped working"
with no pointer to actual reports.
LinusW? Thierry? Bartoz? Anybody?
Yes, there;s something bad going on here, but we can't randomly "fix"
things in an rc8 that have worked for several releases by now.
Linus
next prev parent reply other threads:[~2022-03-14 20:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 20:43 Linux 5.17-rc8 Linus Torvalds
2022-03-14 7:55 ` Build regressions/improvements in v5.17-rc8 Geert Uytterhoeven
2022-03-14 19:25 ` Linux 5.17-rc8 Guenter Roeck
2022-03-14 20:13 ` Linus Torvalds [this message]
2022-03-15 0:45 ` Marcelo Roberto Jimenez
2022-03-15 1:13 ` Guenter Roeck
2022-03-15 1:47 ` Linus Torvalds
2022-03-15 5:42 ` Thorsten Leemhuis
2022-03-15 16:48 ` Bartosz Golaszewski
2022-03-15 9:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiEhs+4P1TNh2sNnk04D1FFdNThk6XLOMxzkRL72PEXFw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=achant@google.com \
--cc=brgl@bgdev.pl \
--cc=edmondchung@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcelo.jimenez@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).