From: Linus Torvalds <firstname.lastname@example.org> To: Konstantin Komarov <email@example.com> Cc: firstname.lastname@example.org, linux-fsdevel <email@example.com>, Linux Kernel Mailing List <firstname.lastname@example.org> Subject: Re: [GIT PULL] ntfs3: new NTFS driver for 5.15 Date: Sat, 4 Sep 2021 11:08:58 -0700 [thread overview] Message-ID: <CAHk-=wjbtip559HcMG9VQLGPmkurh5Kc50y5BceL8Q8=aL0H3Q@mail.gmail.com> (raw) In-Reply-To: <CAHk-=whFAkqwGSNXqeN4KfNwXeCzp9-uoy69_mLExEydTajvGw@mail.gmail.com> On Sat, Sep 4, 2021 at 10:34 AM Linus Torvalds <email@example.com> wrote: > > For github accounts (or really, anything but kernel.org where I can > just trust the account management), I really want the pull request to > be a signed tag, not just a plain branch. Ok, to expedite this all and not cause any further pointless churn and jumping through hoops, I'll let it slide this time, but I'll ask that you sort out your pgp key for the future and use signed tags. Also, I notice that you have a github merge commit in there. That's another of those things that I *really* don't want to see - github creates absolutely useless garbage merges, and you should never ever use the github interfaces to merge anything. This is the complete commit message of that merge: Merge branch 'torvalds:master' into master Yeah, that's not an acceptable message. Not to mention that it has a bogus "github.com" committer etc. github is a perfectly fine hosting site, and it does a number of other things well too, but merges is not one of those things. Linux kernel merges need to be done *properly*. That means proper commit messages with information about what is being merged and *why* you merge something. But it also means proper authorship and committer information etc. All of which github entirely screws up. We had this same issue with the ksmbd pull request, and my response is the same: the initial pull often has a few oddities and I'll accept them now, but for continued development you need to do things properly. That means doing merges from the command line, not using the entirely broken github web interface. (Sadly, it looks like that ksmbd discussion was not on any mailing lists, so I can't link to it). Linus
next prev parent reply other threads:[~2021-09-04 18:18 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-03 15:19 Konstantin Komarov 2021-09-04 17:34 ` Linus Torvalds 2021-09-04 18:08 ` Linus Torvalds [this message] 2021-09-04 19:00 ` pr-tracker-bot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHk-=wjbtip559HcMG9VQLGPmkurh5Kc50y5BceL8Q8=aL0H3Q@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [GIT PULL] ntfs3: new NTFS driver for 5.15' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).