From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v7] lib/crypto: blake2s: include as built-in
Date: Tue, 4 Jan 2022 18:04:34 +0100 [thread overview]
Message-ID: <CAHmME9quP2W3WQzM1ZRSMPiinD=2bz3sxFv2mOFYT9U-+aPhLA@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXFhygHnB12g9MD0wMo_deZ6xd7FMEzbrvEvKVtqYdskAQ@mail.gmail.com>
Hi Ard,
On Tue, Jan 4, 2022 at 6:03 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> The only downside here is that the ARM/x86 accelerated shashes and the
> generic shash now use the same core transform, right? Given that the
> generic blake2s shash is never used for anything in the kernel, the
> only reason for its existence was to be able to use the randomized
> crypto testing infrastructure to test the arch code.
>
> Ergo, there is no point in retaining the blake2s shashes and we can
> simply remove all of them. (Note that blake2b is used as an shash via
> the crypto API by btrfs, but blake2s is only used via the library API)
That makes sense and is fine with me. Let's do that in a separate
commit later. I've got a bunch of things I'd like to fix up in the
general lib/crypto vs crypto split that are kind of interrelated.
Jason
next prev parent reply other threads:[~2022-01-04 17:04 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 14:11 [PATCH v2 1/2] lib/crypto: blake2s: include as built-in Jason A. Donenfeld
2021-12-23 14:11 ` [PATCH v2 2/2] random: use BLAKE2s instead of SHA1 in extraction Jason A. Donenfeld
2021-12-24 20:56 ` Eric Biggers
2022-01-05 21:42 ` Eric Biggers
2021-12-27 15:52 ` Theodore Ts'o
2022-01-11 11:38 ` Geert Uytterhoeven
2022-01-11 12:28 ` Jason A. Donenfeld
2022-01-11 12:50 ` Jason A. Donenfeld
2022-01-11 12:57 ` Geert Uytterhoeven
2022-01-11 13:00 ` Jason A. Donenfeld
2022-01-11 15:46 ` David Laight
2022-01-11 18:26 ` Jason A. Donenfeld
2022-01-14 17:27 ` David Laight
2022-01-14 17:31 ` Jason A. Donenfeld
2022-01-11 12:51 ` Geert Uytterhoeven
2022-01-11 13:02 ` Jason A. Donenfeld
2022-01-11 13:49 ` [PATCH crypto 0/2] smaller blake2s code size on m68k and other small platforms Jason A. Donenfeld
2022-01-11 13:49 ` [PATCH crypto 1/2] lib/crypto: blake2s-generic: reduce code size on small systems Jason A. Donenfeld
2022-01-12 10:57 ` Geert Uytterhoeven
2022-01-12 13:16 ` Jason A. Donenfeld
2022-01-12 18:31 ` Eric Biggers
2022-01-12 18:50 ` Jason A. Donenfeld
2022-01-12 21:27 ` David Laight
2022-01-12 22:00 ` Jason A. Donenfeld
2022-01-11 13:49 ` [PATCH crypto 2/2] lib/crypto: blake2s: move hmac construction into wireguard Jason A. Donenfeld
2022-01-11 14:43 ` Ard Biesheuvel
2022-01-12 18:35 ` Eric Biggers
2022-01-11 18:10 ` [PATCH crypto v2 0/2] reduce code size from blake2s on m68k and other small platforms Jason A. Donenfeld
2022-01-11 18:10 ` [PATCH crypto v2 1/2] lib/crypto: blake2s: move hmac construction into wireguard Jason A. Donenfeld
2022-01-11 18:10 ` [PATCH crypto v2 2/2] lib/crypto: sha1: re-roll loops to reduce code size Jason A. Donenfeld
2022-01-11 22:05 ` [PATCH crypto v3 0/2] reduce code size from blake2s on m68k and other small platforms Jason A. Donenfeld
2022-01-11 22:05 ` [PATCH crypto v3 1/2] lib/crypto: blake2s: move hmac construction into wireguard Jason A. Donenfeld
2022-01-11 22:05 ` [PATCH crypto v3 2/2] lib/crypto: sha1: re-roll loops to reduce code size Jason A. Donenfeld
2022-01-12 10:59 ` [PATCH crypto v3 0/2] reduce code size from blake2s on m68k and other small platforms Geert Uytterhoeven
2022-01-12 13:18 ` Jason A. Donenfeld
2022-01-18 6:42 ` Herbert Xu
2022-01-18 11:43 ` Jason A. Donenfeld
2022-01-18 12:44 ` David Laight
2022-01-18 12:50 ` Jason A. Donenfeld
2021-12-23 14:20 ` [PATCH v2 1/2] lib/crypto: blake2s: include as built-in Ard Biesheuvel
2021-12-24 13:35 ` Greg KH
2021-12-25 9:26 ` Masahiro Yamada
2021-12-25 10:26 ` Ard Biesheuvel
2021-12-25 15:47 ` Masahiro Yamada
2021-12-27 13:43 ` Jason A. Donenfeld
2021-12-27 13:47 ` [PATCH v3] " Jason A. Donenfeld
2021-12-27 14:20 ` [PATCH v4] " Jason A. Donenfeld
2022-01-01 15:59 ` [PATCH v5] " Jason A. Donenfeld
2022-01-02 20:42 ` [PATCH v6] " Jason A. Donenfeld
2022-01-03 3:23 ` Herbert Xu
2022-01-03 3:45 ` Jason A. Donenfeld
2022-01-03 4:06 ` Herbert Xu
2022-01-03 11:57 ` Jason A. Donenfeld
2022-01-03 12:31 ` [PATCH v7] " Jason A. Donenfeld
2022-01-04 1:21 ` Herbert Xu
2022-01-04 17:02 ` Ard Biesheuvel
2022-01-04 17:04 ` Jason A. Donenfeld [this message]
2022-01-05 0:28 ` Herbert Xu
2022-01-05 21:53 ` Eric Biggers
2022-01-05 22:01 ` Ard Biesheuvel
2022-01-05 22:09 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9quP2W3WQzM1ZRSMPiinD=2bz3sxFv2mOFYT9U-+aPhLA@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).