From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: George Spelvin <linux@sciencehorizons.net>
Cc: Andi Kleen <ak@linux.intel.com>,
David Miller <davem@davemloft.net>,
David Laight <David.Laight@aculab.com>,
"Daniel J . Bernstein" <djb@cr.yp.to>,
Eric Biggers <ebiggers3@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com>,
kernel-hardening@lists.openwall.com,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Netdev <netdev@vger.kernel.org>,
Tom Herbert <tom@herbertland.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: HalfSipHash Acceptable Usage
Date: Wed, 21 Dec 2016 17:37:12 +0100 [thread overview]
Message-ID: <CAHmME9rWWbk7SDxT=RtfNu5TAvMkY6f8ScA=MzQ01e6jrFtR+Q@mail.gmail.com> (raw)
In-Reply-To: <20161221155540.29529.qmail@ns.sciencehorizons.net>
Hi George,
On Wed, Dec 21, 2016 at 4:55 PM, George Spelvin
<linux@sciencehorizons.net> wrote:
> Actually, DJB just made a very relevant suggestion.
>
> As I've mentioned, the 32-bit performance problems are an x86-specific
> problem. ARM does very well, and other processors aren't bad at all.
>
> SipHash fits very nicely (and runs very fast) in the MMX registers.
>
> They're 64 bits, and there are 8 of them, so the integer registers can
> be reserved for pointers and loop counters and all that. And there's
> reference code available.
>
> How much does kernel_fpu_begin()/kernel_fpu_end() cost?
In my experience, these functions are only worth calling when
processing more significant amounts of data. I don't have any
benchmarks, but when I _remove_ all of these calls in a kernel,
accelerated crypto gets noticeably faster (until the system crashes).
We can measure it, though.
By the way, if somehow SipHash becomes acceptably fast on x86, would
you consider HalfSipHash for hash tables to be no longer needed? Or do
you suspect that HalfSipHash will always be faster even on, say,
32-bit ARM.
Jason
next prev parent reply other threads:[~2016-12-21 16:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 17:32 HalfSipHash Acceptable Usage Jason A. Donenfeld
[not found] ` <CAGiyFdduUNSGq24zfsk0ZU=hnOCmewAw8vw6XvDoS-3f+3UPKQ@mail.gmail.com>
2016-12-19 21:00 ` Jason A. Donenfeld
2016-12-20 21:36 ` Theodore Ts'o
2016-12-20 23:07 ` George Spelvin
2016-12-20 23:55 ` Eric Dumazet
2016-12-21 3:28 ` George Spelvin
2016-12-21 5:29 ` Eric Dumazet
2016-12-21 6:34 ` George Spelvin
2016-12-21 14:24 ` Jason A. Donenfeld
2016-12-21 15:55 ` George Spelvin
2016-12-21 16:37 ` Jason A. Donenfeld [this message]
2016-12-21 16:41 ` [kernel-hardening] " Rik van Riel
2016-12-21 17:25 ` Linus Torvalds
2016-12-21 18:07 ` George Spelvin
2016-12-22 1:54 ` Andy Lutomirski
2016-12-21 14:42 ` Jason A. Donenfeld
2016-12-21 15:56 ` Eric Dumazet
2016-12-21 16:33 ` Jason A. Donenfeld
2016-12-21 16:39 ` [kernel-hardening] " Rik van Riel
2016-12-21 17:08 ` Eric Dumazet
2016-12-21 18:37 ` George Spelvin
2016-12-21 18:40 ` Jason A. Donenfeld
2016-12-21 22:27 ` Theodore Ts'o
2016-12-22 0:18 ` George Spelvin
2016-12-22 1:13 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9rWWbk7SDxT=RtfNu5TAvMkY6f8ScA=MzQ01e6jrFtR+Q@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=David.Laight@aculab.com \
--cc=ak@linux.intel.com \
--cc=davem@davemloft.net \
--cc=djb@cr.yp.to \
--cc=ebiggers3@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=jeanphilippe.aumasson@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@sciencehorizons.net \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).