* [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface
@ 2017-04-27 6:52 Anatolij Gustschin
2017-04-27 14:07 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Anatolij Gustschin @ 2017-04-27 6:52 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: andy.shevchenko, linux-gpio, linux-kernel
Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
for the !GPIOLIB case to prevent build errors. Also add prototypes.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
Changes in v2:
move gpiod_lookup_table out of #ifdef
include/linux/gpio/consumer.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
index 8f702fc..f4a3fed 100644
--- a/include/linux/gpio/consumer.h
+++ b/include/linux/gpio/consumer.h
@@ -41,6 +41,8 @@ enum gpiod_flags {
GPIOD_FLAGS_BIT_DIR_VAL,
};
+struct gpiod_lookup_table;
+
#ifdef CONFIG_GPIOLIB
/* Return the number of GPIOs associated with a device / function */
@@ -144,6 +146,9 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev,
enum gpiod_flags flags,
const char *label);
+void gpiod_add_lookup_table(struct gpiod_lookup_table *table);
+void gpiod_remove_lookup_table(struct gpiod_lookup_table *table);
+
#else /* CONFIG_GPIOLIB */
static inline int gpiod_count(struct device *dev, const char *con_id)
@@ -435,6 +440,14 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev,
return ERR_PTR(-ENOSYS);
}
+static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table)
+{
+}
+
+static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table *table)
+{
+}
+
#endif /* CONFIG_GPIOLIB */
static inline
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface
2017-04-27 6:52 [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin
@ 2017-04-27 14:07 ` Andy Shevchenko
2017-04-27 14:25 ` Anatolij Gustschin
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2017-04-27 14:07 UTC (permalink / raw)
To: Anatolij Gustschin
Cc: Linus Walleij, Alexandre Courbot, linux-gpio, linux-kernel
On Thu, Apr 27, 2017 at 9:52 AM, Anatolij Gustschin <agust@denx.de> wrote:
> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
> for the !GPIOLIB case to prevent build errors. Also add prototypes.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Oh, has to take my tag back. See below why.
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
It is already defined in machine.h.
What you basically need is to add stubs for !GPIOLIB case
#ifdef ...
...existing prototypes...
#else /* GPIOLIB */
static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table
*table) {}
#endif /* !GPIOLIB */
P.S. please notice how I put the stubs. It would be good to keep them
in two lines.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface
2017-04-27 14:07 ` Andy Shevchenko
@ 2017-04-27 14:25 ` Anatolij Gustschin
2017-04-27 14:29 ` Anatolij Gustschin
0 siblings, 1 reply; 5+ messages in thread
From: Anatolij Gustschin @ 2017-04-27 14:25 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Alexandre Courbot, linux-gpio, linux-kernel
On Thu, 27 Apr 2017 17:07:23 +0300
Andy Shevchenko andy.shevchenko@gmail.com wrote:
>On Thu, Apr 27, 2017 at 9:52 AM, Anatolij Gustschin <agust@denx.de> wrote:
>> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
>> for the !GPIOLIB case to prevent build errors. Also add prototypes.
>>
>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
>Oh, has to take my tag back. See below why.
>
>
>> --- a/include/linux/gpio/consumer.h
>> +++ b/include/linux/gpio/consumer.h
>
>It is already defined in machine.h.
>
>What you basically need is to add stubs for !GPIOLIB case
>
>#ifdef ...
>...existing prototypes...
>#else /* GPIOLIB */
>static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
>static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table
>*table) {}
>#endif /* !GPIOLIB */
>
>P.S. please notice how I put the stubs. It would be good to keep them
>in two lines.
this will exceed 80 char line limit.
Thanks,
Anatolij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface
2017-04-27 14:25 ` Anatolij Gustschin
@ 2017-04-27 14:29 ` Anatolij Gustschin
2017-04-27 14:47 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Anatolij Gustschin @ 2017-04-27 14:29 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Alexandre Courbot, linux-gpio, linux-kernel
On Thu, 27 Apr 2017 16:25:34 +0200
Anatolij Gustschin agust@denx.de wrote:
>On Thu, 27 Apr 2017 17:07:23 +0300
>Andy Shevchenko andy.shevchenko@gmail.com wrote:
...
>>static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
>>static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table
>>*table) {}
>>#endif /* !GPIOLIB */
>>
>>P.S. please notice how I put the stubs. It would be good to keep them
>>in two lines.
>
>this will exceed 80 char line limit.
I'll go with
static inline
void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
static inline
void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {}
Is it okay?
Thanks,
Anatolij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface
2017-04-27 14:29 ` Anatolij Gustschin
@ 2017-04-27 14:47 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2017-04-27 14:47 UTC (permalink / raw)
To: Anatolij Gustschin
Cc: Linus Walleij, Alexandre Courbot, linux-gpio, linux-kernel
On Thu, Apr 27, 2017 at 5:29 PM, Anatolij Gustschin <agust@denx.de> wrote:
> On Thu, 27 Apr 2017 16:25:34 +0200
> Anatolij Gustschin agust@denx.de wrote:
>
>>On Thu, 27 Apr 2017 17:07:23 +0300
>>Andy Shevchenko andy.shevchenko@gmail.com wrote:
> ...
>>>static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
>>>static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table
>>>*table) {}
>>>#endif /* !GPIOLIB */
>>>
>>>P.S. please notice how I put the stubs. It would be good to keep them
>>>in two lines.
>>
>>this will exceed 80 char line limit.
Not for many (unimportant) symbols.
> I'll go with
>
> static inline
> void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
>
> static inline
> void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {}
>
> Is it okay?
Whatever Linus prefers. I'm fine with either.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-27 14:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 6:52 [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface Anatolij Gustschin
2017-04-27 14:07 ` Andy Shevchenko
2017-04-27 14:25 ` Anatolij Gustschin
2017-04-27 14:29 ` Anatolij Gustschin
2017-04-27 14:47 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).