[PATCH 1/2] kstrtox: delete end-of-string test

[PATCH 1/2] kstrtox: delete end-of-string test

[Alexey Dobriyan]

Standard "while (*s)" test is unnecessary because NUL won't pass
valid-digit test anyway. Save one branch per parsed character.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 lib/kstrtox.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/lib/kstrtox.c
+++ b/lib/kstrtox.c
@@ -51,7 +51,7 @@ unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long
 
 	res = 0;
 	rv = 0;
-	while (*s) {
+	while (1) {
 		unsigned int val;
 
 		if ('0' <= *s && *s <= '9')

Re: [PATCH 1/2] kstrtox: delete end-of-string test

[Andy Shevchenko]

On Sun, May 14, 2017 at 10:37 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Standard "while (*s)" test is unnecessary because NUL won't pass
> valid-digit test anyway. Save one branch per parsed character.

> -       while (*s) {
> +       while (1) {

In such cases I prefer

do {} while ();

Since it makes easier to reader to catch that the loop is going at
least once (and less error prone (1) vs. (l) depending on font in
use).

...however, I see that patch is already applied.

-- 
With Best Regards,
Andy Shevchenko