* [PATCH] platform/x86: hp-wmi: Fix tablet mode detection for convertibles
@ 2017-11-03 2:01 Stefan Brüns
2017-11-03 12:53 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Brüns @ 2017-11-03 2:01 UTC (permalink / raw)
To: platform-driver-x86
Cc: Stefan Brüns, Andy Shevchenko, Darren Hart, linux-kernel
Commit f9cf3b2880cc ("platform/x86: hp-wmi: Refactor dock and tablet
state fetchers") consolidated the methods for docking and laptop mode
detection, but omitted to apply the correct mask for the laptop mode
(it always uses the constant for docking).
Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
---
This change is untested, but restores the previous behaviour.
---
drivers/platform/x86/hp-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index b4ed3dc983d5..b4224389febe 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -297,7 +297,7 @@ static int hp_wmi_hw_state(int mask)
if (state < 0)
return state;
- return state & 0x1;
+ return !!(state & mask);
}
static int __init hp_wmi_bios_2008_later(void)
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: hp-wmi: Fix tablet mode detection for convertibles
2017-11-03 2:01 [PATCH] platform/x86: hp-wmi: Fix tablet mode detection for convertibles Stefan Brüns
@ 2017-11-03 12:53 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2017-11-03 12:53 UTC (permalink / raw)
To: Stefan Brüns
Cc: Platform Driver, Andy Shevchenko, Darren Hart, linux-kernel
On Fri, Nov 3, 2017 at 4:01 AM, Stefan Brüns
<stefan.bruens@rwth-aachen.de> wrote:
> Commit f9cf3b2880cc ("platform/x86: hp-wmi: Refactor dock and tablet
> state fetchers") consolidated the methods for docking and laptop mode
> detection, but omitted to apply the correct mask for the laptop mode
> (it always uses the constant for docking).
>
Looks like a good catch!
Applied to my review and testing queue.
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
>
> ---
>
> This change is untested, but restores the previous behaviour.
> ---
> drivers/platform/x86/hp-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index b4ed3dc983d5..b4224389febe 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -297,7 +297,7 @@ static int hp_wmi_hw_state(int mask)
> if (state < 0)
> return state;
>
> - return state & 0x1;
> + return !!(state & mask);
> }
>
> static int __init hp_wmi_bios_2008_later(void)
> --
> 2.14.3
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-03 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 2:01 [PATCH] platform/x86: hp-wmi: Fix tablet mode detection for convertibles Stefan Brüns
2017-11-03 12:53 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).