From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
"Enrico Weigelt, metux IT consult" <lkml@metux.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 2/2] gpio: sch: Add interrupt support
Date: Fri, 26 Apr 2019 21:26:50 +0300 [thread overview]
Message-ID: <CAHp75Vd6CtNRFZ1-7OSe5xzqNXNYQQP4-vck=3rMeq2QVZ7pCw@mail.gmail.com> (raw)
In-Reply-To: <20190426175237.GA31751@Mani-XPS-13-9360>
On Fri, Apr 26, 2019 at 8:52 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
> On Fri, Apr 26, 2019 at 08:44:36PM +0300, Andy Shevchenko wrote:
> > On Fri, Apr 26, 2019 at 8:33 PM Manivannan Sadhasivam
> > <manivannan.sadhasivam@linaro.org> wrote:
> > > On Fri, Apr 26, 2019 at 08:20:19PM +0300, Andy Shevchenko wrote:
> > > > On Fri, Apr 26, 2019 at 7:05 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > > > > On 26.04.19 16:42, Enrico Weigelt, metux IT consult wrote:
> > > > > > On 26.04.19 15:36, Jan Kiszka wrote:
> >
> > > > The problem here is opaque number. This has to be chip + *relative* pin number/
> > > > See this:
> > > > https://stackoverflow.com/questions/55532410/how-do-linux-gpio-numbers-get-their-values/55579640#55579640
> > > >
> > >
> > > But for platform like 96Boards we don't need controller specific lookup, these
> > > are all handled by the platform code [1] so that the users can use the standard
> > > pinout number to access GPIOs.
> >
> > This is a complete mistake.
> >
> > There is *no* global GPIO numbers anymore in Linux. (I don't count
> > very old legacy platforms)
> > Read above, it applies to DT or whatever resource provider.
> >
>
> I think you misunderstood what I said.
I think you misunderstood what I said. :)
> I referred the standard 96Boards
> pinout and in the MRAA platform code, individual boards just map their
> GPIO chip and line number based on that. I didn't mean the deprecated
> global linux numbering.
It can be easily broken by shuffling DT, kernel cnfiguration and
adding some GPIO expanders. Note, no C-code mangling is involved.
>
> https://github.com/intel-iot-devkit/mraa/blob/master/src/arm/96boards.c#L109
>
> And of couse as Jan mentioned, the chip number will change when some
> other external GPIO controller got probed before but so far we haven't
> got to it!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-04-26 18:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 9:23 [PATCH 0/2] gpio: sch: Interrupt support Jan Kiszka
2019-04-18 9:23 ` [PATCH 1/2] gpio: sch: Remove write-only core_base Jan Kiszka
2019-04-23 11:09 ` Linus Walleij
2019-04-18 9:23 ` [PATCH 2/2] gpio: sch: Add interrupt support Jan Kiszka
2019-04-23 11:10 ` Linus Walleij
2019-04-24 7:58 ` Mika Westerberg
2019-04-24 8:12 ` Jan Kiszka
2019-04-24 8:18 ` Mika Westerberg
2019-04-24 8:25 ` Jan Kiszka
2019-04-24 8:42 ` Mika Westerberg
2019-04-24 9:36 ` Jan Kiszka
2019-04-24 9:45 ` Mika Westerberg
2019-04-24 9:48 ` Jan Kiszka
2019-04-24 10:01 ` Mika Westerberg
2019-04-24 10:19 ` Jan Kiszka
2019-04-24 10:33 ` Mika Westerberg
2019-04-24 10:39 ` Jan Kiszka
2019-04-24 10:46 ` Mika Westerberg
2019-04-24 12:41 ` Jan Kiszka
2019-04-24 13:13 ` Mika Westerberg
2019-04-24 14:24 ` Jan Kiszka
2019-04-24 15:33 ` Mika Westerberg
2019-04-26 13:06 ` Andy Shevchenko
2019-04-26 13:36 ` Jan Kiszka
2019-04-26 14:42 ` Enrico Weigelt, metux IT consult
2019-04-26 15:31 ` Manivannan Sadhasivam
2019-04-26 16:03 ` Jan Kiszka
2019-04-26 17:20 ` Andy Shevchenko
2019-04-26 17:33 ` Manivannan Sadhasivam
2019-04-26 17:39 ` Jan Kiszka
2019-04-26 17:46 ` Manivannan Sadhasivam
2019-04-26 17:52 ` Jan Kiszka
2019-04-26 17:56 ` Manivannan Sadhasivam
2019-04-26 17:44 ` Andy Shevchenko
2019-04-26 17:52 ` Manivannan Sadhasivam
2019-04-26 18:26 ` Andy Shevchenko [this message]
2019-04-26 17:37 ` Jan Kiszka
2019-04-29 11:09 ` Enrico Weigelt, metux IT consult
2019-05-16 12:20 ` Linus Walleij
2019-04-26 14:41 ` Linus Walleij
2019-04-26 15:44 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd6CtNRFZ1-7OSe5xzqNXNYQQP4-vck=3rMeq2QVZ7pCw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=jan.kiszka@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).