From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matt Domsch <Matt_Domsch@dell.com>,
Luca Barbieri <luca@luca-barbieri.com>,
George Spelvin <linux@horizon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] lib: Add module support to glob tests
Date: Wed, 4 Jan 2017 11:22:12 +0200 [thread overview]
Message-ID: <CAHp75Vd6Y32BVPC13za0Lbmiiuju0oVkYU8tT1KHnOLxrqj7WQ@mail.gmail.com> (raw)
In-Reply-To: <1483470276-10517-2-git-send-email-geert@linux-m68k.org>
On Tue, Jan 3, 2017 at 9:04 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Extract the glob test code into its own source file, to allow to
> compile it either to a loadable module, or builtin into the kernel.
To the whole series
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
One minor comment below.
> +obj-$(CONFIG_GLOB_SELFTEST) += globtest.o
Can we use pattern test_*, or at least *_test.*?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-01-04 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 19:04 [PATCH 1/3] lib: Add module support to crc32 tests Geert Uytterhoeven
2017-01-03 19:04 ` [PATCH 2/3] lib: Add module support to glob tests Geert Uytterhoeven
2017-01-04 9:22 ` Andy Shevchenko [this message]
2017-01-03 19:04 ` [PATCH 3/3] lib: Add module support to atomic64 tests Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vd6Y32BVPC13za0Lbmiiuju0oVkYU8tT1KHnOLxrqj7WQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Matt_Domsch@dell.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=luca@luca-barbieri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).