* [PATCH] pinctrl: samsung: improve wake irq info on console
@ 2022-01-30 23:21 Martin Jücker
2022-02-01 8:14 ` Krzysztof Kozlowski
2022-02-01 20:29 ` Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Martin Jücker @ 2022-01-30 23:21 UTC (permalink / raw)
To: Tomasz Figa, Krzysztof Kozlowski, Sylwester Nawrocki,
Linus Walleij, linux-arm-kernel, linux-samsung-soc, linux-gpio,
linux-kernel
Cc: Martin Jücker
Improve the wake irq message by also printing the bank name and hwirq
number that matches this irq number.
Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
---
drivers/pinctrl/samsung/pinctrl-exynos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index 0489c899b401..30293fc23354 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -344,7 +344,8 @@ static int exynos_wkup_irq_set_wake(struct irq_data *irqd, unsigned int on)
struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd);
unsigned long bit = 1UL << (2 * bank->eint_offset + irqd->hwirq);
- pr_info("wake %s for irq %d\n", on ? "enabled" : "disabled", irqd->irq);
+ pr_info("wake %s for irq %u (%s-%lu)\n", on ? "enabled" : "disabled",
+ irqd->irq, bank->name, irqd->hwirq);
if (!on)
*our_chip->eint_wake_mask_value |= bit;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: samsung: improve wake irq info on console
2022-01-30 23:21 [PATCH] pinctrl: samsung: improve wake irq info on console Martin Jücker
@ 2022-02-01 8:14 ` Krzysztof Kozlowski
2022-02-01 20:29 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-01 8:14 UTC (permalink / raw)
To: linux-gpio, Linus Walleij, linux-arm-kernel, Sylwester Nawrocki,
linux-kernel, Martin Jücker, Tomasz Figa, linux-samsung-soc
Cc: Krzysztof Kozlowski
On Mon, 31 Jan 2022 00:21:22 +0100, Martin Jücker wrote:
> Improve the wake irq message by also printing the bank name and hwirq
> number that matches this irq number.
>
>
Applied, thanks!
[1/1] pinctrl: samsung: improve wake irq info on console
commit: 3652dc070bad335d6feb31402bb4ab1ad58d5cb6
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: samsung: improve wake irq info on console
2022-01-30 23:21 [PATCH] pinctrl: samsung: improve wake irq info on console Martin Jücker
2022-02-01 8:14 ` Krzysztof Kozlowski
@ 2022-02-01 20:29 ` Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-02-01 20:29 UTC (permalink / raw)
To: Martin Jücker
Cc: Tomasz Figa, Krzysztof Kozlowski, Sylwester Nawrocki,
Linus Walleij, linux-arm Mailing List, Linux Samsung SOC,
open list:GPIO SUBSYSTEM, Linux Kernel Mailing List
On Tue, Feb 1, 2022 at 5:11 PM Martin Jücker <martin.juecker@gmail.com> wrote:
>
> Improve the wake irq message by also printing the bank name and hwirq
> number that matches this irq number.
Perhaps wait a bit and replace the first argument with str_enabled_disabled()?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-01 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-30 23:21 [PATCH] pinctrl: samsung: improve wake irq info on console Martin Jücker
2022-02-01 8:14 ` Krzysztof Kozlowski
2022-02-01 20:29 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).