* [PATCH v3] fjes: Check for error irq
@ 2021-12-23 12:01 Jiasheng Jiang
2021-12-23 12:02 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2021-12-23 12:01 UTC (permalink / raw)
To: andy.shevchenko, davem, kuba, yangyingliang, sashal
Cc: netdev, linux-kernel, Jiasheng Jiang
On Thursday, December 23, 2021, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> Always think a bit, don't be an appendix to the dumb machine.
Sorry, the v2 message has a mistake.
Here is the right one.
This one is also corrected.
Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:
v2 -> v3
*Change 1. Using error variable to check.
*Change 2. Correct the word.
---
drivers/net/fjes/fjes_main.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index e449d9466122..17f2fd937e4d 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -1268,7 +1268,12 @@ static int fjes_probe(struct platform_device *plat_dev)
}
hw->hw_res.start = res->start;
hw->hw_res.size = resource_size(res);
- hw->hw_res.irq = platform_get_irq(plat_dev, 0);
+
+ err = platform_get_irq(plat_dev, 0);
+ if (err < 0)
+ goto err_free_control_wq;
+ hw->hw_res.irq = err;
+
err = fjes_hw_init(&adapter->hw);
if (err)
goto err_free_control_wq;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] fjes: Check for error irq
2021-12-23 12:01 [PATCH v3] fjes: Check for error irq Jiasheng Jiang
@ 2021-12-23 12:02 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-12-23 12:02 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: David S. Miller, Jakub Kicinski, Yang Yingliang, Sasha Levin,
netdev, Linux Kernel Mailing List
On Thu, Dec 23, 2021 at 2:01 PM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:
> On Thursday, December 23, 2021, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > Always think a bit, don't be an appendix to the dumb machine.
>
> Sorry, the v2 message has a mistake.
> Here is the right one.
>
> This one is also corrected.
Same as per previous patches from you, fix the commit message and send v4.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-23 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23 12:01 [PATCH v3] fjes: Check for error irq Jiasheng Jiang
2021-12-23 12:02 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).