[PATCH v2] dell-wmi: Set correct keycode for Fn + left arrow hotkey

[PATCH v2] dell-wmi: Set correct keycode for Fn + left arrow hotkey

[Pali Rohár]

From: Henk <henk.vergonet@gmail.com>

Fn + left arrow hotkey combination is used for enabling/disabling automatic
display brigthness based on integrated ALS sensor. For this purpose there
is standard linux key KEY_BRIGHTNESS_AUTO so use it instead of KEY_UNKNOWN.

Tested on Dell Lattitude E6500.

Signed-off-by: Henk Vergonet <henk.vergonet@gmail.com>
Reviewed-By: Pali Rohár <pali.rohar@gmail.com>
Reviewed-By: Mario Limonciello <mario.limonciello@dell.com>
---
Changes since v1 by Pali
* Update commit description
---
 drivers/platform/x86/dell-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 8d102195..7c918e37 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -233,7 +233,7 @@ static const u16 bios_to_linux_keycode[256] = {
 	[18]	= KEY_PROG1,
 	[19]	= KEY_BRIGHTNESSDOWN,
 	[20]	= KEY_BRIGHTNESSUP,
-	[21]	= KEY_UNKNOWN,
+	[21]	= KEY_BRIGHTNESS_AUTO,
 	[22]	= KEY_KBDILLUMTOGGLE,
 	[23]	= KEY_UNKNOWN,
 	[24]	= KEY_SWITCHVIDEOMODE,
-- 
2.11.0

Re: [PATCH v2] dell-wmi: Set correct keycode for Fn + left arrow hotkey

[Andy Shevchenko]

On Tue, May 1, 2018 at 2:11 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> From: Henk <henk.vergonet@gmail.com>
>
> Fn + left arrow hotkey combination is used for enabling/disabling automatic
> display brigthness based on integrated ALS sensor. For this purpose there
> is standard linux key KEY_BRIGHTNESS_AUTO so use it instead of KEY_UNKNOWN.
>
> Tested on Dell Lattitude E6500.
>

Pushed to my review and testing queue, thanks!


> Signed-off-by: Henk Vergonet <henk.vergonet@gmail.com>
> Reviewed-By: Pali Rohár <pali.rohar@gmail.com>
> Reviewed-By: Mario Limonciello <mario.limonciello@dell.com>
> ---
> Changes since v1 by Pali
> * Update commit description
> ---
>  drivers/platform/x86/dell-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 8d102195..7c918e37 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -233,7 +233,7 @@ static const u16 bios_to_linux_keycode[256] = {
>         [18]    = KEY_PROG1,
>         [19]    = KEY_BRIGHTNESSDOWN,
>         [20]    = KEY_BRIGHTNESSUP,
> -       [21]    = KEY_UNKNOWN,
> +       [21]    = KEY_BRIGHTNESS_AUTO,
>         [22]    = KEY_KBDILLUMTOGGLE,
>         [23]    = KEY_UNKNOWN,
>         [24]    = KEY_SWITCHVIDEOMODE,
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko