[PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Antonio Rosario Intilisano]

    Now that we have informed the firmware that the Power Button driver is
    active, laptops such as the Acer Swift 3 will generate
    a WMI key event with code 0x87 when the power button key is
    pressed. 
    
    Add this keycode to the table so that it is converted to an appropriate
    input event.

Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
Cc: Chris Chiu <chiu@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1be71f956d5c..8952173dd380 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { 	{KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
 	{KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
 	{KE_KEY, 0x86, {KEY_WLAN} },
+	{KE_KEY, 0x87, {KEY_POWER} },
 	{KE_END, 0}
 };
 
-- 
2.15.1

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Gianfranco Costamagna]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello,

On 20/04/2018 23:26, Antonio Rosario Intilisano wrote:
>     Now that we have informed the firmware that the Power Button driver is
>     active, laptops such as the Acer Swift 3 will generate
>     a WMI key event with code 0x87 when the power button key is
>     pressed. 
>     
>     Add this keycode to the table so that it is converted to an appropriate
>     input event.
> 

I don't know why Acer folks didn't merge this into the kernel yet, but this patch
seems to fix a real issue, so I'm thinking about uploading it in Ubuntu right now.

Antonio, I forgot to tell you before, can you please open an Ubuntu bug so we can track the change?
(ubuntu-bug linux should do the trick)

Gianfranco

> Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
> Cc: Chris Chiu <chiu@endlessm.com>
> Cc: Daniel Drake <drake@endlessm.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> ---
>  drivers/platform/x86/acer-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1be71f956d5c..8952173dd380 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { 	{KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
>  	{KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>  	{KE_KEY, 0x86, {KEY_WLAN} },
> +	{KE_KEY, 0x87, {KEY_POWER} },
>  	{KE_END, 0}
>  };
>  
> 

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJa24WoAAoJEPNPCXROn13Zih8P/R8TOet5JdpAqdu9o/YUjP6b
iBhygp3rPJgXjzEnGtHvrukzu1MviL82iE1evelbUrmNuT6/aw++PabZ89rTzGwE
TVGJcjG6gl05UjCLjNE9G0xscb0aj3+bLf7ogZ+boUrjOU0xpZrutlGwh7XhSd26
sp+3PnkxccnLI6rSLXOVZqB3JaDa5+QJRlb/NudboawHp5dH4QiYdcHv/lOiKIh4
3ur+HaMfDannMQDzwN5FMWrP5jepjsEPq7R5D0QkUc/ivY6Nod7722aKU8Vilxol
tPPcUHWm/fGjYM4AGp8z1zH31FUCWyJjg404Ncb5AOcnoV2iVwN6KZkCM/WSjtwu
R+G2tYy2cX6DPqK5jUw5LyriA595DkpsHUa3p13nm0NhgpkM6EQT787AlTn6QJqQ
/MAJBfwRYuqc7+aG2CWg4OpKjFn6v8wfh2wEa6sMcbsemaqL9ct1ZS6NzNHAbuNS
BJRyuEnrmrQ9DEkPoLUo7pK1zeCNT5M0PkQy4BIPxD7FLh7IFVr24kOrUw6zq6sL
MomvE37pfqAb3FBWsVch32ERrBhA+8nBjl17j54F9N2DUfl1ZL6ZvIL77ah1ZpY1
7oBMDKpYwJbL36uDV7vXOO3FlO1vUjUMckmEer2lDskbZyFazYTRF4aUTS6uvAWJ
R9QJxPQbHC339wL5tEDm
=qQE6
-----END PGP SIGNATURE-----

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Andy Shevchenko]

On Sat, Apr 21, 2018 at 9:40 PM, Gianfranco Costamagna
<locutusofborg@debian.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hello,
>
> On 20/04/2018 23:26, Antonio Rosario Intilisano wrote:
>>     Now that we have informed the firmware that the Power Button driver is
>>     active, laptops such as the Acer Swift 3 will generate
>>     a WMI key event with code 0x87 when the power button key is
>>     pressed.
>>
>>     Add this keycode to the table so that it is converted to an appropriate
>>     input event.
>>
>
> I don't know why Acer folks didn't merge this into the kernel yet, but this patch
> seems to fix a real issue, so I'm thinking about uploading it in Ubuntu right now.

Can you give your corresponding tag as well?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Gianfranco Costamagna]

Hello,

>Can you give your corresponding tag as well?


we are implementing the fix right now, please follow bug
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1766054

G.

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Andy Shevchenko]

On Mon, Apr 23, 2018 at 5:48 PM, Gianfranco Costamagna
<locutusofborg@debian.org> wrote:
> Hello,
>
>>Can you give your corresponding tag as well?
>
>
> we are implementing the fix right now, please follow bug
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1766054

OK, I postpone this patch until new version.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Andy Shevchenko]

On Tue, 2018-04-24 at 19:15 +0300, Andy Shevchenko wrote:
> On Mon, Apr 23, 2018 at 5:48 PM, Gianfranco Costamagna
> <locutusofborg@debian.org> wrote:
> > Hello,
> > 
> > > Can you give your corresponding tag as well?
> > 
> > 
> > we are implementing the fix right now, please follow bug
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1766054
> 
> OK, I postpone this patch until new version.

Or I missed the point and it's working? Tell me what to do with it.

For now I pushed to my review and testing queue, thanks!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Gianfranco Costamagna]

Hello Andy,

>Or I missed the point and it's working? Tell me what to do with it.
>For now I pushed to my review and testing queue, thanks!


Antonio did patch and build a custom kernel locally (testing was successful), and submitted
the patch to me.

I pinged some Ubuntu folks to get it applied, and also testing with the .deb provided
by kernel team was good, so I presume this is a safe patch that can be applied right now
as-is.
(this is a trivial patch, Antonio told me in another channel that he can also create and post
failures logs before and after, as well as do some video with the key pressed).

I don't think this is needed, but if you want it for historical purposes, just ask and we will
do our best to provide them!

Gianfranco

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Andy Shevchenko]

On Tue, Apr 24, 2018 at 9:23 PM, Gianfranco Costamagna
<locutusofborg@debian.org> wrote:
> Hello Andy,
>
>>Or I missed the point and it's working? Tell me what to do with it.
>>For now I pushed to my review and testing queue, thanks!
>
>
> Antonio did patch and build a custom kernel locally (testing was successful), and submitted
> the patch to me.
>
> I pinged some Ubuntu folks to get it applied, and also testing with the .deb provided
> by kernel team was good, so I presume this is a safe patch that can be applied right now
> as-is.
> (this is a trivial patch, Antonio told me in another channel that he can also create and post
> failures logs before and after, as well as do some video with the key pressed).
>
> I don't think this is needed, but if you want it for historical purposes, just ask and we will
> do our best to provide them!

Thanks for a sync.

What I asked before still stands, i.e. would be nice to have Tested-by
tag by someone who actually tested the change.

Feel free to respond here with it I hope patchwork catch it up.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Andy Shevchenko]

On Sat, Apr 28, 2018 at 12:50 AM, Antonio Rosario Intilisano
<antonio.intilisano@gmail.com> wrote:
>     Now that we have informed the firmware that the Power Button driver is
>     active, laptops such as the Acer Swift 3 will generate
>     a WMI key event with code 0x87 when the power button key is
>     pressed.
>
>     Add this keycode to the table so that it is converted to an appropriate
>     input event.

I pushed it to my review and testing queue, thanks!

Though, see below.

>
> Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
> Tested-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Cc: Chris Chiu <chiu@endlessm.com>
> Cc: Daniel Drake <drake@endlessm.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> ---
>  drivers/platform/x86/acer-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1be71f956d5c..8952173dd380 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = {     {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },

This is malformed patch. It states 6 lines for context, though only 4
provided. Please, fix your tools.

>         {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>         {KE_KEY, 0x86, {KEY_WLAN} },
> +       {KE_KEY, 0x87, {KEY_POWER} },
>         {KE_END, 0}
>  };
>
> --
> 2.15.1
>



-- 
With Best Regards,
Andy Shevchenko

[PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Antonio Rosario Intilisano]

    Now that we have informed the firmware that the Power Button driver is
    active, laptops such as the Acer Swift 3 will generate
    a WMI key event with code 0x87 when the power button key is
    pressed. 
    
    Add this keycode to the table so that it is converted to an appropriate
    input event.

Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
Tested-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
Cc: Chris Chiu <chiu@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1be71f956d5c..8952173dd380 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { 	{KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
 	{KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
 	{KE_KEY, 0x86, {KEY_WLAN} },
+	{KE_KEY, 0x87, {KEY_POWER} },
 	{KE_END, 0}
 };
 
-- 
2.15.1

[PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode

[Antonio Rosario Intilisano]

    Now that we have informed the firmware that the Power Button driver is
    active, laptops such as the Acer Swift 3 will generate
    a WMI key event with code 0x87 when the power button key is
    pressed. 
    
    Add this keycode to the table so that it is converted to an appropriate
    input event.

Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
Cc: Chris Chiu <chiu@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1be71f956d5c..8952173dd380 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { 	{KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
 	{KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
 	{KE_KEY, 0x86, {KEY_WLAN} },
+	{KE_KEY, 0x87, {KEY_POWER} },
 	{KE_END, 0}
 };
 
-- 
2.15.1