linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'
@ 2018-06-29  3:33 YueHaibing
  2018-06-29  3:35 ` Randy Dunlap
  0 siblings, 1 reply; 5+ messages in thread
From: YueHaibing @ 2018-06-29  3:33 UTC (permalink / raw)
  To: linux-kernel
  Cc: akpm, keescook, mawilcox, kstewart, aryabinin, gregkh, YueHaibing

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 lib/string.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/string.c b/lib/string.c
index 2c0900a..23ed944 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
  * @s1: one string
  * @s2: another string
  *
- * This routine returns true iff two strings are equal, treating both
+ * This routine returns true if two strings are equal, treating both
  * NUL and newline-then-NUL as equivalent string terminations.  It's
  * geared for use with sysfs input strings, which generally terminate
  * with newlines but are compared against values without newlines.
-- 
2.7.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'
  2018-06-29  3:33 [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if' YueHaibing
@ 2018-06-29  3:35 ` Randy Dunlap
  2018-06-29  3:44   ` YueHaibing
  0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2018-06-29  3:35 UTC (permalink / raw)
  To: YueHaibing, linux-kernel
  Cc: akpm, keescook, mawilcox, kstewart, aryabinin, gregkh

On 06/28/2018 08:33 PM, YueHaibing wrote:
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  lib/string.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi,

This isn't a typo.  "iff" means "if and only if".

> diff --git a/lib/string.c b/lib/string.c
> index 2c0900a..23ed944 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
>   * @s1: one string
>   * @s2: another string
>   *
> - * This routine returns true iff two strings are equal, treating both
> + * This routine returns true if two strings are equal, treating both
>   * NUL and newline-then-NUL as equivalent string terminations.  It's
>   * geared for use with sysfs input strings, which generally terminate
>   * with newlines but are compared against values without newlines.
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'
  2018-06-29  3:35 ` Randy Dunlap
@ 2018-06-29  3:44   ` YueHaibing
  2018-06-29 15:30     ` David Laight
  0 siblings, 1 reply; 5+ messages in thread
From: YueHaibing @ 2018-06-29  3:44 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel
  Cc: akpm, keescook, mawilcox, kstewart, aryabinin, gregkh



On 2018/6/29 11:35, Randy Dunlap wrote:
> On 06/28/2018 08:33 PM, YueHaibing wrote:
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  lib/string.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi,
> 
> This isn't a typo.  "iff" means "if and only if".

ok, my poor english, thank you.

> 
>> diff --git a/lib/string.c b/lib/string.c
>> index 2c0900a..23ed944 100644
>> --- a/lib/string.c
>> +++ b/lib/string.c
>> @@ -609,7 +609,7 @@ EXPORT_SYMBOL(strsep);
>>   * @s1: one string
>>   * @s2: another string
>>   *
>> - * This routine returns true iff two strings are equal, treating both
>> + * This routine returns true if two strings are equal, treating both
>>   * NUL and newline-then-NUL as equivalent string terminations.  It's
>>   * geared for use with sysfs input strings, which generally terminate
>>   * with newlines but are compared against values without newlines.
>>
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'
  2018-06-29  3:44   ` YueHaibing
@ 2018-06-29 15:30     ` David Laight
  2018-06-29 20:25       ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: David Laight @ 2018-06-29 15:30 UTC (permalink / raw)
  To: 'YueHaibing', Randy Dunlap, linux-kernel
  Cc: akpm, keescook, mawilcox, kstewart, aryabinin, gregkh

From: YueHaibing
> Sent: 29 June 2018 04:45
> 
> On 2018/6/29 11:35, Randy Dunlap wrote:
> > On 06/28/2018 08:33 PM, YueHaibing wrote:
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >> ---
> >>  lib/string.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Hi,
> >
> > This isn't a typo.  "iff" means "if and only if".
> 
> ok, my poor english, thank you.

It's not really english, but a shorthand used by mathematicians.

	David


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'
  2018-06-29 15:30     ` David Laight
@ 2018-06-29 20:25       ` Andy Shevchenko
  0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-06-29 20:25 UTC (permalink / raw)
  To: David Laight
  Cc: YueHaibing, Randy Dunlap, linux-kernel, akpm, keescook, mawilcox,
	kstewart, aryabinin, gregkh

On Fri, Jun 29, 2018 at 6:30 PM, David Laight <David.Laight@aculab.com> wrote:
> From: YueHaibing
>> Sent: 29 June 2018 04:45
>>
>> On 2018/6/29 11:35, Randy Dunlap wrote:
>> > On 06/28/2018 08:33 PM, YueHaibing wrote:
>> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> >> ---
>> >>  lib/string.c | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > Hi,
>> >
>> > This isn't a typo.  "iff" means "if and only if".
>>
>> ok, my poor english, thank you.
>
> It's not really english, but a shorthand used by mathematicians.

I remember I did a very same mistake (and sent a patch!).

Perhaps better to fully spell it to avoid "once per 3 years" activity?

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-06-29 20:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-29  3:33 [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if' YueHaibing
2018-06-29  3:35 ` Randy Dunlap
2018-06-29  3:44   ` YueHaibing
2018-06-29 15:30     ` David Laight
2018-06-29 20:25       ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).