* [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board
@ 2019-08-20 9:56 Enrico Weigelt, metux IT consult
2019-08-22 19:47 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-08-20 9:56 UTC (permalink / raw)
To: linux-kernel; +Cc: info, dvhart, andy, platform-driver-x86
GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
need to match on DMI data.
Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
---
drivers/platform/x86/pcengines-apuv2.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index e4c68ef..ea0c6bb 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -178,6 +178,33 @@
},
.driver_data = (void *)&board_apu2,
},
+ /* APU4 w/ legacy bios < 4.0.8 */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "APU4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
+ /* APU4 w/ legacy bios >= 4.0.8 */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "apu4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
+ /* APU4 w/ mainline bios */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "PC Engines apu4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
{}
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board
2019-08-20 9:56 [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board Enrico Weigelt, metux IT consult
@ 2019-08-22 19:47 ` Andy Shevchenko
2019-08-28 11:37 ` Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2019-08-22 19:47 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: Linux Kernel Mailing List, Darren Hart, Andy Shevchenko, Platform Driver
On Tue, Aug 20, 2019 at 12:56 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
> need to match on DMI data.
>
> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
Wrong format.
W/o SoB tag I can't take it.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board
2019-08-22 19:47 ` Andy Shevchenko
@ 2019-08-28 11:37 ` Enrico Weigelt, metux IT consult
2019-09-07 17:31 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-08-28 11:37 UTC (permalink / raw)
To: Andy Shevchenko, Enrico Weigelt, metux IT consult
Cc: Linux Kernel Mailing List, Darren Hart, Andy Shevchenko, Platform Driver
On 22.08.19 21:47, Andy Shevchenko wrote:
>> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
>
> Wrong format.
>
> W/o SoB tag I can't take it.
What's the correct format (what command shall I use to
create it correctly ?)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board
2019-08-28 11:37 ` Enrico Weigelt, metux IT consult
@ 2019-09-07 17:31 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-09-07 17:31 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: Enrico Weigelt, metux IT consult, Linux Kernel Mailing List,
Darren Hart, Andy Shevchenko, Platform Driver
On Wed, Aug 28, 2019 at 2:37 PM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:
>
> On 22.08.19 21:47, Andy Shevchenko wrote:
>
> >> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
> >
> > Wrong format.
> >
> > W/o SoB tag I can't take it.
>
> What's the correct format (what command shall I use to
> create it correctly ?)
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Section 11
And for this one Fixes is not needed. The APUv4 never worked before, correct?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board
@ 2019-12-12 13:27 Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 7+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-12-12 13:27 UTC (permalink / raw)
To: linux-kernel; +Cc: info, platform-driver-x86
GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
need to match on DMI data.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/platform/x86/pcengines-apuv2.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index 48b112b4f0b0..49f25bffce3c 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -189,6 +189,33 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
+ /* APU4 w/ legacy bios < 4.0.8 */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "APU4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
+ /* APU4 w/ legacy bios >= 4.0.8 */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "apu4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
+ /* APU4 w/ mainline bios */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "PC Engines apu4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
{}
};
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board
2019-11-21 15:57 Enrico Weigelt, metux IT consult
@ 2019-11-25 11:15 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-11-25 11:15 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: Linux Kernel Mailing List, Platform Driver
On Thu, Nov 21, 2019 at 5:58 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
> need to match on DMI data.
>
> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
The Fixes tag format is wrong.
You are not first time contributor...
Also the question why do you have it here? Do we have any regression
(something worked and stopped working)?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board
@ 2019-11-21 15:57 Enrico Weigelt, metux IT consult
2019-11-25 11:15 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-11-21 15:57 UTC (permalink / raw)
To: linux-kernel; +Cc: info, platform-driver-x86
GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
need to match on DMI data.
Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/platform/x86/pcengines-apuv2.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index 48b112b4f0b0..49f25bffce3c 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -189,6 +189,33 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
+ /* APU4 w/ legacy bios < 4.0.8 */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "APU4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
+ /* APU4 w/ legacy bios >= 4.0.8 */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "apu4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
+ /* APU4 w/ mainline bios */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "PC Engines apu4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
{}
};
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-12 13:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 9:56 [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board Enrico Weigelt, metux IT consult
2019-08-22 19:47 ` Andy Shevchenko
2019-08-28 11:37 ` Enrico Weigelt, metux IT consult
2019-09-07 17:31 ` Andy Shevchenko
2019-11-21 15:57 Enrico Weigelt, metux IT consult
2019-11-25 11:15 ` Andy Shevchenko
2019-12-12 13:27 Enrico Weigelt, metux IT consult
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).