From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v4 1/2] gpio: gpio-mlxbf3: Add gpio driver support
Date: Sat, 18 Feb 2023 01:07:18 +0200 [thread overview]
Message-ID: <CAHp75VdeVpjzg5Y_4Y+Ke9=3wog28vUBN4Fd8zxfa8dWGrqUUA@mail.gmail.com> (raw)
In-Reply-To: <28f0d670407c127614b64d9c382b11c795f5077d.1676668853.git.asmaa@nvidia.com>
On Fri, Feb 17, 2023 at 11:27 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
>
> Add support for the BlueField-3 SoC GPIO driver.
> This driver configures and handles GPIO interrupts. It also enables a user
> to manipulate certain GPIO pins via libgpiod tools or other kernel drivers.
> The usables pins are defined via the gpio-reserved-ranges property.
Probably
"gpio-reserved-ranges"
(in double quotes).
...
> + depends on (MELLANOX_PLATFORM && ARM64 && ACPI) || (64BIT && COMPILE_TEST)
But do you really need the ACPI dependency? I don't see a single bit
of it in the driver.
(Yes, I know about IDs.)
Also, how 64BIT is needed for testing?
...
> +#include <linux/version.h>
I believe it's included automatically. Please, double check the header
inclusions to make sure you don't have some spurious ones in the list.
> +struct mlxbf3_gpio_context {
> + struct gpio_chip gc;
> +
> + /* YU GPIO block address */
> + void __iomem *gpio_io;
> +
> + /* YU GPIO cause block address */
> + void __iomem *gpio_cause_io;
> +};
...
> + int offset = irqd_to_hwirq(irqd);
It returns irq_hw_number_t IIRC. It's an unsigned type. Otherwise you
may have interesting effects.
...
> + int offset = irqd_to_hwirq(irqd);
Ditto.
...
> + raw_spin_lock_irqsave(&gs->gc.bgpio_lock, flags);
> +
> + switch (type & IRQ_TYPE_SENSE_MASK) {
> + case IRQ_TYPE_EDGE_BOTH:
> + val = readl(gs->gpio_io + MLXBF_GPIO_CAUSE_FALL_EN);
> + val |= BIT(offset);
> + writel(val, gs->gpio_io + MLXBF_GPIO_CAUSE_FALL_EN);
> + val = readl(gs->gpio_io + MLXBF_GPIO_CAUSE_RISE_EN);
> + val |= BIT(offset);
> + writel(val, gs->gpio_io + MLXBF_GPIO_CAUSE_RISE_EN);
> + break;
> + case IRQ_TYPE_EDGE_RISING:
> + val = readl(gs->gpio_io + MLXBF_GPIO_CAUSE_RISE_EN);
> + val |= BIT(offset);
> + writel(val, gs->gpio_io + MLXBF_GPIO_CAUSE_RISE_EN);
> + break;
> + case IRQ_TYPE_EDGE_FALLING:
> + val = readl(gs->gpio_io + MLXBF_GPIO_CAUSE_FALL_EN);
> + val |= BIT(offset);
> + writel(val, gs->gpio_io + MLXBF_GPIO_CAUSE_FALL_EN);
> + break;
> + default:
Dead lock starts here.
> + return -EINVAL;
> + }
> +
> + raw_spin_unlock_irqrestore(&gs->gc.bgpio_lock, flags);
...
> + irq_set_handler_locked(irqd, handle_simple_irq);
Why not using propert handler type (edge)?
...
> +static const struct irq_chip gpio_mlxbf3_irqchip = {
> + .name = "MLNXBF33",
> + .irq_set_type = mlxbf3_gpio_irq_set_type,
> + .irq_enable = mlxbf3_gpio_irq_enable,
> + .irq_disable = mlxbf3_gpio_irq_disable,
> +};
Seems missing two things (dunno if bgpio_init() helps with that):
- IMMUTABLE flag
- actual calls to enable and disable IRQs for internal GPIO library usage
See other drivers how it's done. There are even plenty of patches to
enable this thing separately.
...
> +static int
> +mlxbf3_gpio_probe(struct platform_device *pdev)
Doesn't it perfectly fit one line?
...
> + npins = MLXBF3_GPIO_MAX_PINS_PER_BLOCK;
> + device_property_read_u32(dev, "npins", &npins);
I don't see DT bindings for this property (being added in this
series). Is it already established one?
...
> + girq->default_type = IRQ_TYPE_NONE;
Assigning handle_bad_irq() is missing.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-17 23:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:39 [PATCH v3 0/2] Add NVIDIA BlueField-3 GPIO driver and pin controller Asmaa Mnebhi
2023-02-10 15:39 ` [PATCH v3 1/2] Support NVIDIA BlueField-3 GPIO controller Asmaa Mnebhi
2023-02-11 7:37 ` kernel test robot
2023-02-11 11:51 ` Andy Shevchenko
2023-02-13 23:14 ` Asmaa Mnebhi
2023-02-13 23:39 ` andy.shevchenko
2023-02-10 15:39 ` [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver Asmaa Mnebhi
2023-02-11 11:55 ` Andy Shevchenko
2023-02-16 17:50 ` Asmaa Mnebhi
2023-02-16 18:38 ` Andy Shevchenko
2023-02-16 18:44 ` Asmaa Mnebhi
2023-02-16 18:53 ` Andy Shevchenko
2023-02-16 19:26 ` Asmaa Mnebhi
2023-02-11 11:58 ` [PATCH v3 0/2] Add NVIDIA BlueField-3 GPIO driver and pin controller Andy Shevchenko
2023-02-17 21:26 ` [PATCH v4 0/2] Support Nvidia " Asmaa Mnebhi
2023-02-17 21:26 ` [PATCH v4 1/2] gpio: gpio-mlxbf3: Add gpio driver support Asmaa Mnebhi
2023-02-17 23:07 ` Andy Shevchenko [this message]
2023-02-22 18:40 ` Asmaa Mnebhi
2023-02-23 11:06 ` Andy Shevchenko
2023-02-23 19:08 ` Asmaa Mnebhi
2023-02-23 19:58 ` Andy Shevchenko
2023-02-23 22:51 ` Asmaa Mnebhi
2023-02-24 9:47 ` Andy Shevchenko
2023-02-24 14:42 ` Asmaa Mnebhi
2023-02-24 15:12 ` Andy Shevchenko
2023-02-24 15:59 ` Asmaa Mnebhi
2023-02-24 15:13 ` Andy Shevchenko
2023-02-24 15:14 ` Andy Shevchenko
2023-02-18 1:05 ` kernel test robot
2023-02-23 12:29 ` Linus Walleij
2023-02-17 21:26 ` [PATCH v4 2/2] pinctrl: pinctrl-mlxbf: Add pinctrl " Asmaa Mnebhi
2023-02-17 23:24 ` Andy Shevchenko
2023-02-23 21:07 ` Asmaa Mnebhi
2023-02-24 9:44 ` Andy Shevchenko
2023-03-14 20:30 ` Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdeVpjzg5Y_4Y+Ke9=3wog28vUBN4Fd8zxfa8dWGrqUUA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=asmaa@nvidia.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).